From patchwork Fri Jun 4 14:16:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Kardach X-Patchwork-Id: 93878 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59AC0A0A0F; Fri, 4 Jun 2021 16:16:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D728410F8; Fri, 4 Jun 2021 16:16:33 +0200 (CEST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mails.dpdk.org (Postfix) with ESMTP id CF84540147 for ; Fri, 4 Jun 2021 16:16:29 +0200 (CEST) Received: by mail-lj1-f181.google.com with SMTP id a4so11736883ljq.9 for ; Fri, 04 Jun 2021 07:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mB50Spo5m4touFl9YbRJvRQyWal0n9W5zCKa7kv95xQ=; b=SdddHDoHz8YFC+fNIPPHW3hdzwv2wQjUb9VcQvNLMHl1rw48AcsajVALNHWlYg/ggT KaBLCUgGqOSWxhPPxJcrjh4gGcMmt3pNkce6Cbgin/WKmNWQe8Qm9VO4h2tZRlka8SEQ KIi7EyK9Nc5rsFYSDBfBBJp6mRfUlq2Faxxe7mIBdMNcwV686UmflAzMF/+H0zBtNeeS Xb+olo1Oq74vje0+g/AHEK/wC+SXngvkimvRZRaDdUhUGRf75DZoiAJyzgOzSl85M1Ph JYHErf+Rwjaf1G4BZnv5/PCDGuwOC1c20T2sZnebyUbWxT//xIXGBLKXA+O+bjfUFLyb 30YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mB50Spo5m4touFl9YbRJvRQyWal0n9W5zCKa7kv95xQ=; b=PmN1otKJkHOe6F+Tjgr1l6ybyXU3+6nsGYCzrjWLheJuEH0BLPKzrrTqNFFDF/HEpn F7oaxnVigHXz6QnQkjr7yLCc+w5a655FuPGbPH2Aax88Ds3RT8mwLG9KvZUMKuSEGt52 RKBbT0kngxXgq9F0ZL79ZtntXrpyFxp+A01+0HA/udVTl1GSUI4MaPoo4e1dxWbbOp05 NRF3p2QvcdM/rJcu0MU3FsW6VRjKoYbIRqTlkQbGZsUDrBmRGb/DZUpS/1bqv5lpvXbs 5JCvGpcB7+61KoH5T2PGBYG16bQqDXszppZWagYuyhjqtMonoCfYNjsobDJf+n54ClJ9 bl3A== X-Gm-Message-State: AOAM530+/P/qvEQQu/SpRrfTeOvkcU5S+R5O60WlzItjv0HOUY835JmS AVR3ZSIrMfnrffYQFdXK8c6O0Q== X-Google-Smtp-Source: ABdhPJwXUPnz0ND285aVbBs2n1Xl1sLjB04mZrZi8X552gcA1yjGYtLXJ4owQxFT0barMW3tx8blag== X-Received: by 2002:a2e:b4ba:: with SMTP id q26mr3658473ljm.222.1622816189418; Fri, 04 Jun 2021 07:16:29 -0700 (PDT) Received: from localhost.localdomain (89-73-146-138.dynamic.chello.pl. [89.73.146.138]) by smtp.gmail.com with ESMTPSA id h13sm706377lji.101.2021.06.04.07.16.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 07:16:29 -0700 (PDT) From: Stanislaw Kardach To: Anatoly Burakov Cc: dev@dpdk.org, Stanislaw Kardach , pablo.de.lara.guarch@intel.com Date: Fri, 4 Jun 2021 16:16:01 +0200 Message-Id: <20210604141601.275430-4-kda@semihalf.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210604141601.275430-1-kda@semihalf.com> References: <20210604141601.275430-1-kda@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 3/3] test: fix the -n unit test description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When -n argument became optional, the test logic was fixed (by 1e0b51fd4) but the comment indicating why --no-huge and --no-shconf are used was not changed. Today those flags are used for compatibility with FreeBSD (see b5d878e6d), so change the comment to reflect that. Signed-off-by: Stanislaw Kardach Fixes: b5d878e6db56 ("test: fix EAL flags autotest on FreeBSD") Cc: anatoly.burakov@intel.com Fixes: 1e0b51fd4b75 ("app/test: fix unit test for option -n") Cc: pablo.de.lara.guarch@intel.com --- app/test/test_eal_flags.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index e2248a5d9a..b1ab87cf8d 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -666,8 +666,8 @@ test_main_lcore_flag(void) /* * Test that the app doesn't run with invalid -n flag option. * Final test ensures it does run with valid options as sanity check - * Since -n is not compulsory for MP, we instead use --no-huge and --no-shconf - * flags. + * For compatibility with BSD use --no-huge and --no-shconf flags as we need to + * run a primary process. */ static int test_invalid_n_flag(void)