doc: announce changes in security session struct
Checks
Commit Message
The structure rte_security_session is not directly used
by the application. The application just need an opaque
pointer to attached to the mbuf or rte_crypto_op while
enqueue. Hence, it can be hidden inside the library
and would prevent unnecessary indirection to the priv
session data in fastpath.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
Comments
> The structure rte_security_session is not directly used
> by the application. The application just need an opaque
> pointer to attached to the mbuf or rte_crypto_op while
> enqueue. Hence, it can be hidden inside the library
> and would prevent unnecessary indirection to the priv
> session data in fastpath.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index c540c90f8e..8da1c2648c 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -159,3 +159,7 @@ Deprecation Notices
> * security: The functions ``rte_security_set_pkt_metadata`` and
> ``rte_security_get_userdata`` will be made inline functions and additional
> flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> +
> +* security: Hide stucture ``rte_security_session`` and expose an opaque
> + pointer for the private data to the application which can be attached
> + to the packet while enqueuing.
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.25.1
On Tue, Aug 3, 2021 at 5:36 AM Ananyev, Konstantin
<konstantin.ananyev@intel.com> wrote:
>
>
> > The structure rte_security_session is not directly used
> > by the application. The application just need an opaque
> > pointer to attached to the mbuf or rte_crypto_op while
> > enqueue. Hence, it can be hidden inside the library
> > and would prevent unnecessary indirection to the priv
> > session data in fastpath.
> >
> > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index c540c90f8e..8da1c2648c 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -159,3 +159,7 @@ Deprecation Notices
> > * security: The functions ``rte_security_set_pkt_metadata`` and
> > ``rte_security_get_userdata`` will be made inline functions and additional
> > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> > +
> > +* security: Hide stucture ``rte_security_session`` and expose an opaque
> > + pointer for the private data to the application which can be attached
> > + to the packet while enqueuing.
> > --
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> > 2.25.1
>
> Subject: [EXT] Re: [PATCH] doc: announce changes in security session struct
>
>
> On Tue, Aug 3, 2021 at 5:36 AM Ananyev, Konstantin
> <konstantin.ananyev@intel.com> wrote:
> >
> >
> > > The structure rte_security_session is not directly used
> > > by the application. The application just need an opaque
> > > pointer to attached to the mbuf or rte_crypto_op while
> > > enqueue. Hence, it can be hidden inside the library
> > > and would prevent unnecessary indirection to the priv
> > > session data in fastpath.
> > >
> > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > > ---
> > > doc/guides/rel_notes/deprecation.rst | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> > > index c540c90f8e..8da1c2648c 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -159,3 +159,7 @@ Deprecation Notices
> > > * security: The functions ``rte_security_set_pkt_metadata`` and
> > > ``rte_security_get_userdata`` will be made inline functions and additional
> > > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> > > +
> > > +* security: Hide stucture ``rte_security_session`` and expose an opaque
> > > + pointer for the private data to the application which can be attached
> > > + to the packet while enqueuing.
> > > --
> >
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
On Thu, Aug 5, 2021 at 9:45 AM Anoob Joseph <anoobj@marvell.com> wrote:
>
> > Subject: [EXT] Re: [PATCH] doc: announce changes in security session struct
> >
> >
> > On Tue, Aug 3, 2021 at 5:36 AM Ananyev, Konstantin
> > <konstantin.ananyev@intel.com> wrote:
> > >
> > >
> > > > The structure rte_security_session is not directly used
> > > > by the application. The application just need an opaque
> > > > pointer to attached to the mbuf or rte_crypto_op while
> > > > enqueue. Hence, it can be hidden inside the library
> > > > and would prevent unnecessary indirection to the priv
> > > > session data in fastpath.
> > > >
> > > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > > > ---
> > > > doc/guides/rel_notes/deprecation.rst | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > > > index c540c90f8e..8da1c2648c 100644
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > @@ -159,3 +159,7 @@ Deprecation Notices
> > > > * security: The functions ``rte_security_set_pkt_metadata`` and
> > > > ``rte_security_get_userdata`` will be made inline functions and additional
> > > > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> > > > +
> > > > +* security: Hide stucture ``rte_security_session`` and expose an opaque
> > > > + pointer for the private data to the application which can be attached
> > > > + to the packet while enqueuing.
> > > > --
> > >
> > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> > > > > The structure rte_security_session is not directly used
> > > > > by the application. The application just need an opaque
> > > > > pointer to attached to the mbuf or rte_crypto_op while
> > > > > enqueue. Hence, it can be hidden inside the library
> > > > > and would prevent unnecessary indirection to the priv
> > > > > session data in fastpath.
> > > > >
> > > > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > > > > ---
> > > > > +* security: Hide stucture ``rte_security_session`` and expose an opaque
> > > > > + pointer for the private data to the application which can be attached
> > > > > + to the packet while enqueuing.
> > > >
> > > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Acked-by: Anoob Joseph <anoobj@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks.
@@ -159,3 +159,7 @@ Deprecation Notices
* security: The functions ``rte_security_set_pkt_metadata`` and
``rte_security_get_userdata`` will be made inline functions and additional
flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
+
+* security: Hide stucture ``rte_security_session`` and expose an opaque
+ pointer for the private data to the application which can be attached
+ to the packet while enqueuing.