From patchwork Tue Aug 17 06:47:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenjun Wu X-Patchwork-Id: 96968 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FFF5A0548; Tue, 17 Aug 2021 09:06:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4438E4014E; Tue, 17 Aug 2021 09:06:06 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 2FFE040143 for ; Tue, 17 Aug 2021 09:06:04 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="203208698" X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="203208698" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 00:05:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="676373925" Received: from wuwenjun.sh.intel.com ([10.67.110.178]) by fmsmga006.fm.intel.com with ESMTP; 17 Aug 2021 00:05:56 -0700 From: Wenjun Wu To: dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com Cc: Wenjun Wu Date: Tue, 17 Aug 2021 14:47:47 +0800 Message-Id: <20210817064747.159948-1-wenjun1.wu@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/2] net/iavf: fix default RSS field for IP fragment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously IP ID field is supported in default RSS for IP fragment packets. Actually it is not expected. This patch removes redundant default RSS field for IP fragment packets. The default RSS only needs to support the src and dst IP fields. Fixes: 9e29a278bc0c ("net/iavf: support default RSS for IP fragment") Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf_hash.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index 2b03dad858..eba55ecea5 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/drivers/net/iavf/iavf_hash.c @@ -624,34 +624,12 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add) } if (rss_hf & ETH_RSS_FRAG_IPV4) { - struct virtchnl_proto_hdrs hdr = { - .tunnel_level = TUNNEL_LEVEL_OUTER, - .count = 3, - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv4, - { - VIRTCHNL_PROTO_HDR_IPV4_FRAG, - FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_FRAG_PKID), - {BUFF_NOUSED}, - }, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv4_tmplt; iavf_add_del_rss_cfg(ad, &rss_cfg, add); } if (rss_hf & ETH_RSS_FRAG_IPV6) { - struct virtchnl_proto_hdrs hdr = { - .tunnel_level = TUNNEL_LEVEL_OUTER, - .count = 3, - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv6, - proto_hdr_ipv6_frag, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv6_tmplt; iavf_add_del_rss_cfg(ad, &rss_cfg, add); }