[v1] stack: remove duplicated include of atomic
Checks
Commit Message
In stack module, remove the duplicated header file rte_atomic.h
as it has been included in rte_spinlock.h/rte_pause.h
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_stack.c | 1 -
lib/stack/rte_stack.c | 1 -
lib/stack/rte_stack.h | 1 -
3 files changed, 3 deletions(-)
Comments
Hi Joyce,
On Sun, Aug 22, 2021 at 10:20:34PM -0500, Joyce Kong wrote:
> In stack module, remove the duplicated header file rte_atomic.h
> as it has been included in rte_spinlock.h/rte_pause.h
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Sorry for the late feedback.
No objection about the patch itself, but I don't think the commit log
should say that rte_atomic.h is indirectly included by
rte_spinlock.h/rte_pause.h.
To me, it is not a good reason to remove an include. However, it looks
that no function from rte_atomic.h is used in these files, especially
since commit c51e67c2ee18 ("test/stack: remove thread synchronisation")
for the test app.
Thanks,
Olivier
@@ -4,7 +4,6 @@
#include <string.h>
-#include <rte_atomic.h>
#include <rte_lcore.h>
#include <rte_malloc.h>
#include <rte_random.h>
@@ -5,7 +5,6 @@
#include <string.h>
#include <rte_string_fns.h>
-#include <rte_atomic.h>
#include <rte_eal.h>
#include <rte_eal_memconfig.h>
#include <rte_errno.h>
@@ -19,7 +19,6 @@
extern "C" {
#endif
-#include <rte_atomic.h>
#include <rte_compat.h>
#include <rte_debug.h>
#include <rte_errno.h>