net/i40e: solve the failure of vf vlan filtering
Checks
Commit Message
When vf driver port promiscuous is turned on, the vlan filtering function
is invalid.
Through communication with PAE expert, this is a limitation of the i40e
chip. Before adding or removing VLANs, you must first disable unicast
promiscuous or multicast promiscuous, then operate the vlan, and finally
restore unicast promiscuous or multicast promiscuous state.
Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
---
drivers/net/i40e/i40e_ethdev_vf.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
@@ -1900,12 +1900,30 @@ static int
i40evf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
{
int ret;
+ struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
+ struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+ bool promisc_unicast_enabled = vf->promisc_unicast_enabled;
+ bool promisc_multicast_enabled = vf->promisc_multicast_enabled;
- if (on)
+ if (promisc_unicast_enabled)
+ i40evf_dev_promiscuous_disable(dev);
+
+ if (promisc_multicast_enabled)
+ i40evf_dev_allmulticast_disable(dev);
+
+ if (on) {
ret = i40evf_add_vlan(dev, vlan_id);
- else
+ if ((dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_VLAN_STRIP) == 0)
+ i40evf_disable_vlan_strip(dev);
+ } else
ret = i40evf_del_vlan(dev,vlan_id);
+ if (promisc_unicast_enabled)
+ i40evf_dev_promiscuous_enable(dev);
+
+ if (promisc_multicast_enabled)
+ i40evf_dev_allmulticast_enable(dev);
+
return ret;
}