vhost: add log print of socket path on adding connection
Checks
Commit Message
Add log print of socket path in vhost_user_add_connection.
It's useful when adding a mass of socket connections,
because the information of every connection is more clearer.
Fixes: a277c7159876 ("vhost: refactor code structure")
Cc: stable@dpdk.org
Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
---
lib/vhost/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Gaoxiang,
> -----Original Message-----
> From: Gaoxiang Liu <gaoxiangliu0@163.com>
> Sent: Saturday, September 4, 2021 10:28 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; Gaoxiang Liu <gaoxiangliu0@163.com>;
> stable@dpdk.org
> Subject: [PATCH] vhost: add log print of socket path on adding connection
>
> Add log print of socket path in vhost_user_add_connection.
> It's useful when adding a mass of socket connections,
> because the information of every connection is more clearer.
More clearer -> clearer
>
> Fixes: a277c7159876 ("vhost: refactor code structure")
I think it should be this commit:
8f972312b8f4 ("vhost: support vhost-user")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
Do you have issue sending with this email address? If not, please use
the same for one commit.
And please use 'Plain Text' when replying comments. I noticed you are
using HTML for other patches, which is not suggested.
Thanks,
Chenbo
> ---
> lib/vhost/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
> index d6f9414c4..c6548608a 100644
> --- a/lib/vhost/socket.c
> +++ b/lib/vhost/socket.c
> @@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket
> *vsocket)
> dev->async_copy = 1;
> }
>
> - VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
> + VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid,
> vsocket->path);
>
> if (vsocket->notify_ops->new_connection) {
> ret = vsocket->notify_ops->new_connection(vid);
> --
> 2.32.0
>
Hi chenbo,
I will fix the issues in [PATCH v2].
Thanks.
Gaoxiang.
At 2021-09-06 13:35:23, "Xia, Chenbo" <chenbo.xia@intel.com> wrote:
>Hi Gaoxiang,
>
>> -----Original Message-----
>> From: Gaoxiang Liu <gaoxiangliu0@163.com>
>> Sent: Saturday, September 4, 2021 10:28 PM
>> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
>> Cc: dev@dpdk.org; liugaoxiang@huawei.com; Gaoxiang Liu <gaoxiangliu0@163.com>;
>> stable@dpdk.org
>> Subject: [PATCH] vhost: add log print of socket path on adding connection
>>
>> Add log print of socket path in vhost_user_add_connection.
>> It's useful when adding a mass of socket connections,
>> because the information of every connection is more clearer.
>
>More clearer -> clearer
>
>>
>> Fixes: a277c7159876 ("vhost: refactor code structure")
>
>I think it should be this commit:
>
>8f972312b8f4 ("vhost: support vhost-user")
>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
>
>Do you have issue sending with this email address? If not, please use
>the same for one commit.
>
>And please use 'Plain Text' when replying comments. I noticed you are
>using HTML for other patches, which is not suggested.
>
>Thanks,
>Chenbo
>
>> ---
>> lib/vhost/socket.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
>> index d6f9414c4..c6548608a 100644
>> --- a/lib/vhost/socket.c
>> +++ b/lib/vhost/socket.c
>> @@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket
>> *vsocket)
>> dev->async_copy = 1;
>> }
>>
>> - VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
>> + VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid,
>> vsocket->path);
>>
>> if (vsocket->notify_ops->new_connection) {
>> ret = vsocket->notify_ops->new_connection(vid);
>> --
>> 2.32.0
>>
>
@@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)
dev->async_copy = 1;
}
- VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
+ VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid, vsocket->path);
if (vsocket->notify_ops->new_connection) {
ret = vsocket->notify_ops->new_connection(vid);