diff mbox series

[v6,06/10] lib: pdump is not supported on Windows

Message ID 20210909233329.190021-7-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Headers
Series Packet capture framework enhancements |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Sept. 9, 2021, 11:33 p.m. UTC 
  The original version of the pdump library was building on
Windows, but it was useless since the pdump utility was not being
built.

The new version of pdump with filtering now has dependency
on bpf. But bpf library is not available on Windows.

For now, just stop trying to build pdump on Windows.
Eventually, bpf library, pdump library, dumpcap tool,
and pdump tool can be converted to work on Windows.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Cc: Dmitry Malloy <dmitrym@microsoft.com>
Cc: Pallavi Kadam <pallavi.kadam@intel.com>
---
 lib/meson.build | 1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Kozlyuk Sept. 10, 2021, 8:17 a.m. UTC | #1 
2021-09-09 16:33 (UTC-0700), Stephen Hemminger:
> The original version of the pdump library was building on
> Windows, but it was useless since the pdump utility was not being
> built.
> 
> The new version of pdump with filtering now has dependency
> on bpf. But bpf library is not available on Windows.
> 
> For now, just stop trying to build pdump on Windows.
> Eventually, bpf library, pdump library, dumpcap tool,
> and pdump tool can be converted to work on Windows.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
> Cc: Dmitry Malloy <dmitrym@microsoft.com>
> Cc: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
>  lib/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/meson.build b/lib/meson.build
> index 51bf9c2d11f0..ba88e9eabc58 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -85,7 +85,6 @@ if is_windows
>              'gro',
>              'gso',
>              'latencystats',
> -            'pdump',
>      ] # only supported libraries for windows
>  endif
>  

Anyway pdump relies on multiprocess not supported on Windows.

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
diff mbox series

Patch

diff --git a/lib/meson.build b/lib/meson.build
index 51bf9c2d11f0..ba88e9eabc58 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -85,7 +85,6 @@  if is_windows
             'gro',
             'gso',
             'latencystats',
-            'pdump',
     ] # only supported libraries for windows
 endif