From patchwork Fri Oct 1 19:52:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 100359 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72DA3A0032; Fri, 1 Oct 2021 21:52:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D8BC41206; Fri, 1 Oct 2021 21:52:53 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2053.outbound.protection.outlook.com [40.107.243.53]) by mails.dpdk.org (Postfix) with ESMTP id E818D411C1 for ; Fri, 1 Oct 2021 21:52:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0urBMGfou9Gh2TbpW/w6C4Nw2ZDsh8hApqhvBcpSUYtST0yfVeZC1dOPZsD4p504uU/vtwjXhwpevNz4c4vEtlncxY6PFzs9gMQiUg2Ba7jxqgCA5FVWytl1IAhn0EDHQyStoDXHI/PbNdjAvKJkzuljaqPvYl/DXuHoX6tJlTIVF2Ia+aUj2yfENk7sO6s96uHuJXHf65g8e6s0hNgIS66V7k6d1CEV1kG8M/nBHZfPeSFv5eSsChqoa+8wikPsEU0oRwTkNsqJ/GGWR83DU4LQf6b/ygPD7NjZWJFggVlJrDa+HT8z/andIgz4ofv6oay+vcof2VRH7OjYqx0Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r1VAVO0Qo3E8TuGdakkmVxva1n2sKVKepKfRmCn0lEw=; b=KeToesSXznzmopL5mgZPdl8lgt0MF1XtLmu9NBTbnBjDFcAHz7HpImfFQXrHoAV8D1np6WS+C1sZL59+LgYv8HtnkZhYTzIQhHtYUWTxRlMKWj1J8Bkfkgv8hjNv+CD14kI5P/EXRHJ/y5MMMq7eThxVKzS4t3nJK0crxNaLVaIFJ25iQH+28YT1UOTY8FZ9TuvLIwmwaMqspqc+Qs8ziYCI5Wfe7GP8JEJJ9OaNFjAIqRgJd5Ui6ZEJONB0y8cU6J64nZVou57Dkqe6ALkYXoMtWnAoth+8+5tmPe7dgEdOizPZ+9ecAu1uMYKdk8ofS1PrFfuacihGQXVnSRo6Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1VAVO0Qo3E8TuGdakkmVxva1n2sKVKepKfRmCn0lEw=; b=KsBWcAj5aelPRjeldXN19WL/yfTrsbFhHmt3VMGHS61eHXExc2IyfBVWE0I9u19W8LB9xiX1+Hkq2CzgAuEa1BnSLenKsXFu4x+b6j5ombWInfVz431MpXUezcIxr/WqsJUDgaoITgzm/1At+9tplE7yu6bKkgtrBbwL7GA6pJUZraAZGiyUlrJd606NlAwcN4PZqfNI8ggWOQTZ7BvexDuWBB0sBi7dqmNHwWj5nzNmg5A4LtugG7i5eqREWufkn74VHfgeqsP4v7dTx928p90SVUX783BirpCjHLr2GfPyIEXLGTQoPOxsoFRnj2U1lVZ7nRJzqzgedl3gp7mbbQ== Received: from CO1PR15CA0047.namprd15.prod.outlook.com (2603:10b6:101:1f::15) by BL1PR12MB5078.namprd12.prod.outlook.com (2603:10b6:208:313::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Fri, 1 Oct 2021 19:52:49 +0000 Received: from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:101:1f:cafe::6b) by CO1PR15CA0047.outlook.office365.com (2603:10b6:101:1f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 19:52:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 19:52:48 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 1 Oct 2021 19:52:46 +0000 From: Viacheslav Ovsiienko To: CC: , , , , , Date: Fri, 1 Oct 2021 22:52:21 +0300 Message-ID: <20211001195223.31909-2-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20211001195223.31909-1-viacheslavo@nvidia.com> References: <20210910141609.8410-1-viacheslavo@nvidia.com> <20211001195223.31909-1-viacheslavo@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c71ba64-c801-4096-162a-08d985150bc6 X-MS-TrafficTypeDiagnostic: BL1PR12MB5078: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9z30IZTh/F2bVzqmWv11O8YBFP72Ww1ZoGD57gqmcf9Xa61VtGRLYyy96kxTEjjf8F3labCYzxC4V9S1M3fr/P7ce662N9qxeOXHBZ9zce4aBeLo8nFD7tgI18LiXutATeJV3K0t6Nr1gRPdvww93vQcusaOdtjxo5qK/1vbtYy5D1r+QCd/T/y9tw9yFgYh8X2cphqy9nclSqpMUxipP74wZOTPuhaozMFAjJYf402dYKgeFBE18GwI3PrEVvF8vEBQLkWKWbm8Jo2rFnumRP0bdedLCFYWiV+W/HcRqKTYkIMhVF2kEgK/FCSTiAf1nqkNK1K+Vd8GxCjvuV8Is1SfpCP8xCQwhSbOMkCvuEEonSd8o4KzVRPldTmThpvSS5Ap+ckRYGfxlsdm0jFsWct2clLJqk7VhV2MQ0dxlNVNSV9rD3oriAKC91oqLKmf04Eaa8g5oVK2F63dGcCZL5+V+hZgNc1pIHUK1FleXtaQvBV8EEEmYhjheqb1sgKS5J5kxUSwv41irKz+y+70MnctwRqgKpQvIxZphmiJ8N48BTKE6fNd3z5WgNHaYTdWm8AQKHkA+rU8LssAylBdw/VDZnLMDT/D/SZJNGOZO8gqExFdfgUXLM2HquG++Pivh7eHqns7JA4wFYhAv89Lgce18J9cUZCz/pJwgd3wdRXe5TF/b+UfrLGIH92pfC61cFeUUrLOqCQDiGppsd82kboOlo4229UcUM/b8/pvaWc= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(83380400001)(36756003)(8676002)(70586007)(508600001)(36860700001)(7636003)(8936002)(47076005)(336012)(6286002)(1076003)(316002)(2906002)(356005)(7696005)(426003)(2616005)(5660300002)(70206006)(26005)(186003)(6666004)(86362001)(54906003)(6916009)(4326008)(15650500001)(55016002)(16526019)(82310400003)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 19:52:48.7304 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c71ba64-c801-4096-162a-08d985150bc6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5078 Subject: [dpdk-dev] [PATCH 1/3] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the byte ordering for 64-bit integer was not specified. Many fields have lesser lengths and byte ordering is crucial. - how the bit offset is applied to the immediate source field was not defined and documented - 64-bit integer size is not enough to provide MAC and IPv6 addresses In order to cover the issues and exclude any ambiguities the following is done: - introduce the explicit pointer field in rte_flow_action_modify_data structure - replace the 64-bit unsigned integer with 16-byte array - update the modify field flow action documentation [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") Signed-off-by: Viacheslav Ovsiienko --- doc/guides/prog_guide/rte_flow.rst | 8 ++++++++ doc/guides/rel_notes/release_21_11.rst | 7 +++++++ lib/ethdev/rte_flow.h | 15 ++++++++++++--- 3 files changed, 27 insertions(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 2b42d5ec8c..a54760a7b4 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -2835,6 +2835,14 @@ a packet to any other part of it. ``value`` sets an immediate value to be used as a source or points to a location of the value in memory. It is used instead of ``level`` and ``offset`` for ``RTE_FLOW_FIELD_VALUE`` and ``RTE_FLOW_FIELD_POINTER`` respectively. +The data in memory should be presented exactly in the same byte order and +length as in the relevant flow item, i.e. data for field with type +RTE_FLOW_FIELD_MAC_DST should follow the conventions of dst field +in rte_flow_item_eth structure, with type RTE_FLOW_FIELD_IPV6_SRC - +rte_flow_item_ipv6 conventions, and so on. The bitfield exatracted from the +memory being applied as second operation parameter is defined by width and +the destination field offset. If the field size is large than 16 bytes the +pattern can be provided as pointer only. .. _table_rte_flow_action_modify_field: diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 73e377a007..7db6cccab0 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -170,6 +170,10 @@ API Changes the crypto/security operation. This field will be used to communicate events such as soft expiry with IPsec in lookaside mode. +* ethdev: ``rte_flow_action_modify_data`` structure udpdated, immediate data + array is extended, data pointer field is explicitly added to union, the + action behavior is defined in more strict fashion and documentation uddated. + ABI Changes ----------- @@ -206,6 +210,9 @@ ABI Changes and hard expiry limits. Limits can be either in number of packets or bytes. +* ethdev: ``rte_flow_action_modify_data`` structure udpdated. + + Known Issues ------------ diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 7b1ed7f110..af4c693ead 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -3204,6 +3204,9 @@ enum rte_flow_field_id { }; /** + * @warning + * @b EXPERIMENTAL: this structure may change without prior notice + * * Field description for MODIFY_FIELD action. */ struct rte_flow_action_modify_data { @@ -3217,10 +3220,16 @@ struct rte_flow_action_modify_data { uint32_t offset; }; /** - * Immediate value for RTE_FLOW_FIELD_VALUE or - * memory address for RTE_FLOW_FIELD_POINTER. + * Immediate value for RTE_FLOW_FIELD_VALUE, presented in the + * same byte order and length as in relevant rte_flow_item_xxx. */ - uint64_t value; + uint8_t value[16]; + /* + * Memory address for RTE_FLOW_FIELD_POINTER, memory layout + * should be the same as for relevant field in the + * rte_flow_item_xxx structure. + */ + void *pvalue; }; };