From patchwork Wed Oct 13 18:27:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 101464 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39D80A0C55; Wed, 13 Oct 2021 20:33:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6836411D8; Wed, 13 Oct 2021 20:32:13 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41]) by mails.dpdk.org (Postfix) with ESMTP id 43AD9411FF for ; Wed, 13 Oct 2021 20:32:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gfwj1CnoqO4Tmyn5JikJL/xbVhZZGj96y/LpoTbBx8XGB2wJeXZebT6+GKH1HcwOF8q+ARbvACprttLvUM2yGhrzpVIsGrZpBlPr7JnSZe29PqC0Jyk+1Hp0QHadaFsTv3y8g6QsgICfEvcXIzS3AXz59C3I+tyNn+gPMyypnVE+wsXHtowaJk1LRRXmoQLl4+NtahtNzG+3Y950AookMohVlhgqSXjJA78xX03lxwRgN333LqctVs2z8SZjD2HzU66MslLgsrsuTAf94fjZ6DHom/LRQ1VYA7wMRCucPq4pBSv2hwZathEf4ffK5xT3Nm1la6UR+yLWOHh7KcPjpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hM1YExVC9ypiO1YsXFiAyDaTqzgZZszZZhcVa+m2EoY=; b=Iz7o8/CAt7OTYlxEF6TTeVQmjcjNwr/o4R1TB3SIUK7bZLs/8EO+0x+vs9e0K3qafmyEKAV/tylzCZdVL2rL+eCFLGrRwXIaz6+3XwHZ+sSZs7s8kkxYDve++x/g/VdlxItHMUlebj5/ylALj1vZQi6PJvbRfY3MnN9kmT/KbNWJDPSPw90hiD4MuE5SueMt56TdCCQVeKk899F3pdBzbclkyykcv/WeM5qq9DSnFqpHCMz6HAFlQtS4bvCao57Uktrdet1XyrFStxBej3tikK8j0293MTbyipQGlufpd3ZqU6L0/jF+9DFCt5pQDNO7QKYVIts9vSWP4hn/ydPb0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hM1YExVC9ypiO1YsXFiAyDaTqzgZZszZZhcVa+m2EoY=; b=GmqP8XvrLtEqj+lpxTY+JLIcOyW6MCliWGkBN70aGIQ1HIDdVz93am30Hz55jT2/T6jS6btG+dsv7pp8oVAPxtbpX0qf/j/CINnNFsMI9LZbgp3LbLYWP1tJjVMquXv/ybDxdHiQMjyyjC4qXuTnjXbAqqcHmERY/UIDvtVqpbc= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8630.eurprd04.prod.outlook.com (2603:10a6:10:2dd::15) by DU2PR04MB8805.eurprd04.prod.outlook.com (2603:10a6:10:2e0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 18:32:11 +0000 Received: from DU2PR04MB8630.eurprd04.prod.outlook.com ([fe80::945d:e362:712d:1b80]) by DU2PR04MB8630.eurprd04.prod.outlook.com ([fe80::945d:e362:712d:1b80%3]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021 18:32:11 +0000 From: Hemant Agrawal To: dev@dpdk.org, gakhil@marvell.com Cc: roy.fan.zhang@intel.com, konstantin.ananyev@intel.com, Gagandeep Singh Date: Wed, 13 Oct 2021 23:57:15 +0530 Message-Id: <20211013182720.32486-11-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211013182720.32486-1-hemant.agrawal@nxp.com> References: <20211013182720.32486-1-hemant.agrawal@nxp.com> X-ClientProxiedBy: SG3P274CA0016.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::28) To DU2PR04MB8630.eurprd04.prod.outlook.com (2603:10a6:10:2dd::15) MIME-Version: 1.0 Received: from dpdk-xeon.ap.freescale.net (92.120.0.67) by SG3P274CA0016.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 18:32:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 611a27a5-1358-487f-4c79-08d98e77c52a X-MS-TrafficTypeDiagnostic: DU2PR04MB8805: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1051; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lsA7GtdZjIahtgFXc0adO92293IQSUqkCxbjcXFqvDb7H1CxBO7+q1MUvDbQTX2pU8ZyXbvOwVyDRlu/6Lq4ulvk9GRXYrIYdwv2zVJjSpgh/5kB7w3hzXVMHpjSc7DthISnsdoF6YohfIR8Xsti6XU+VzfSbqmUGlfh+l6fjX0mVsPVMBTty+z+3/rXN66kD6e9N9AvejI+ITNuCOzOyYnjwK2Rmo1N8NIndldz6KFFONi0QcgsfsKgZtL5bEANAQcoAp3gvy1sXVUpuLXeNmyDeK1Zcd3ZEf/WG2QJ22h/jHc/9zbpNexqleZ521C/JOTuK3libr5VYELwuTgB3yfDrBr0wiUIldran+OSqlBK20rBm2aLWjU/bz7PCQLo9nR5cT+htBE1P5/OVrGfqvljx4j2qh7ygtb/Azm8MGWFNDJjTS9aMTa9ayhlNc6Ur5jAJ2V+CKF9UbM8nPJDP0/sM0wv0maEzRKRxfOJkn9Ugc2yi8UKQg5buAWPIee0EgvAdzsONl5LvF8MjDk4yltZMqDqTAjEw+pPTMTwX03FidLFK8BkIeCZPnMxeUrLs2YqzQGAoaIMzvtgWcoXXyg2uwrGXs/GqjRx9mJvjC2MxVFZ2lMuXm7Ayx1eMOVsk4+qFa2Cms4+JOCUKzlhe72G6j3+8DMhZ6Q5k/Sl/Dxwe+5EPFLYV6PWLi7ilxtKUyeiyb1uO2OFe9BVerim/w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8630.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6666004)(956004)(186003)(66476007)(26005)(44832011)(66556008)(52116002)(83380400001)(66946007)(8936002)(36756003)(8676002)(2616005)(1076003)(4326008)(508600001)(38100700002)(6486002)(86362001)(6506007)(38350700002)(316002)(2906002)(5660300002)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xVwnIgdIUy48W4IqAt+D1ra9s4wCdZo2xp96Af6xv3dXDRBIkKwLaKbsLLBhWtJ0lqjMsAGw4+CvKatNC1otL9m7O7ZDKXC3SWonZOzNSq/VXI78H4LVFBaNAIdudPPzeALXMrWL8m9LFyelRQKQH9dZtu4iTwxTuH0ANTvYRw9faHxDiCfApGsBgWm04FTTX3rWyYV7qEBseoFoLmrAGJuB5XZpry3Bvbe+/D212NKd9841bo5XLafv2X0szAHrw+s2IsXATcxn2srOjDMND7MU6yJ4UDKEbILYPck7wp4inMITTllI3nfOXuNM4EXkCL24L6e9fY9tKa5eZGrWwfbAa/ZMylmCD4IJ5YJxBuzF7oKLylEXcMO0uY3nB3+sCqmkngTeQmaXFtzY49h5s7TmW2JoLG0dnD9sgPNFrOhsOPdBABV0WN2oBDPsP8NMX8vBYasncTIbjamLQftdwdXi9JdIrW031jhGPxtMj8O3VAg9Jq0R7qDLdzSDc5+YtQ7jy3BhF/ExrhGKKhVWJiGUy3cFGyONDSe7Tv8bLey+wlrVMTiSH0CAnQNZmPkRW6FgzbYXn89WA923pNoCYksu8riwSz7t7qT/GypWqkfBO9ZVipgbWWqZGcLxlwI7DVAdsYIBagWK6jIVJeLR7ODQfyeZh4/VLkH0lu5kuFJ+TLLdsU49jU6xykExlm/r1mgsqZrDI6RbVKhUCiofsqTIdDTYYvWHXFw3MsGWvgAYHI8GghoQeSmAh9in9J8qmOaak0DpL7LGyBpIFS/FzFJKPa64QnPqWEp7THrLPwW40Y8oTJSOzyjf/F8GFW/JpBS9EbOJct3h/UXbQWJ6V+c4UllCH1JuVQQ2VBjb9VPtERE0UtxdVGvc5IuZvgdCbjSm6MDXG9fOdcFoKUWptePRZKWquev01nNmWrSvrHqO1QNKzTSbzS67cZVLbqYbfeS87St35eQTHKxfWW4m1CXUXVDqqhHfRKXHtRwa+dWM0MjaFGiAbkigbl8NHV6NNSvDU3gAmo4WHvRDDom1RRzOLw29emsvN+pi2tlPnh6bFsz+EgJp6HnbRBMMGPnhgv+SyuoMDpd0hYcQIvonkpmNJg4cXf6sK7kGC2MNa6/IqExwQWLo0NaPOHPrBRxmGeYa1DwxaHyGQ1vE/BWilBFGb72vAi526X/umToxOg0+ai3SKazsrriPcc7YOtj06wLyMAYD939mh1NEa498DM3/OCWH4j0Jt0LpWDnyWcVKhSJHYlKesdwg1kSNR0wX14XdSxrDJvD0c9FeEXtCsqOgevZPACLxuwXd8FdtCTf41qZMDU2IaATKhdt9SBuD X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 611a27a5-1358-487f-4c79-08d98e77c52a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8630.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 18:32:11.1733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /pcvXiTJ/T9DerVPtJQqkkj1QUuBYr7P5EGmcIF6UtpQ8QqHFzoBrWmFEPTPmmQOf1N7ag183zlg155bfdeVVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8805 Subject: [dpdk-dev] [PATCH v3 10/15] crypto/dpaa2_sec: enhance error checks with raw buffer APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Gagandeep Singh This patch improves error conditions and support of Wireless algos with raw buffers. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 31 ++++----------------- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c index 4f78cef9c0..a2ffc6c02f 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c @@ -355,16 +355,7 @@ build_raw_dp_auth_fd(uint8_t *drv_ctx, data_len = total_len - ofs.ofs.auth.head - ofs.ofs.auth.tail; data_offset = ofs.ofs.auth.head; - if (sess->auth_alg == RTE_CRYPTO_AUTH_SNOW3G_UIA2 || - sess->auth_alg == RTE_CRYPTO_AUTH_ZUC_EIA3) { - if ((data_len & 7) || (data_offset & 7)) { - DPAA2_SEC_ERR("AUTH: len/offset must be full bytes"); - return -ENOTSUP; - } - - data_len = data_len >> 3; - data_offset = data_offset >> 3; - } + /* For SNOW3G and ZUC, lengths in bits only supported */ fle = (struct qbman_fle *)rte_malloc(NULL, FLE_SG_MEM_SIZE(2 * sgl->num), RTE_CACHE_LINE_SIZE); @@ -609,17 +600,7 @@ build_raw_dp_cipher_fd(uint8_t *drv_ctx, data_len = total_len - ofs.ofs.cipher.head - ofs.ofs.cipher.tail; data_offset = ofs.ofs.cipher.head; - if (sess->cipher_alg == RTE_CRYPTO_CIPHER_SNOW3G_UEA2 || - sess->cipher_alg == RTE_CRYPTO_CIPHER_ZUC_EEA3) { - if ((data_len & 7) || (data_offset & 7)) { - DPAA2_SEC_ERR("CIPHER: len/offset must be full bytes"); - return -ENOTSUP; - } - - data_len = data_len >> 3; - data_offset = data_offset >> 3; - } - + /* For SNOW3G and ZUC, lengths in bits only supported */ /* first FLE entry used to store mbuf and session ctxt */ fle = (struct qbman_fle *)rte_malloc(NULL, FLE_SG_MEM_SIZE(2*sgl->num), @@ -878,7 +859,7 @@ dpaa2_sec_raw_dequeue_burst(void *qp_data, uint8_t *drv_ctx, struct qbman_result *dq_storage; uint32_t fqid = dpaa2_qp->rx_vq.fqid; int ret, num_rx = 0; - uint8_t is_last = 0, status; + uint8_t is_last = 0, status, is_success = 0; struct qbman_swp *swp; const struct qbman_fd *fd; struct qbman_pull_desc pulldesc; @@ -957,11 +938,11 @@ dpaa2_sec_raw_dequeue_burst(void *qp_data, uint8_t *drv_ctx, /* TODO Parse SEC errors */ DPAA2_SEC_ERR("SEC returned Error - %x", fd->simple.frc); - status = RTE_CRYPTO_OP_STATUS_ERROR; + is_success = false; } else { - status = RTE_CRYPTO_OP_STATUS_SUCCESS; + is_success = true; } - post_dequeue(user_data, num_rx, status); + post_dequeue(user_data, num_rx, is_success); num_rx++; dq_storage++;