[v2,1/4] mbuf: remove duplicate definition of cksum offload flags

Message ID 20211015192408.21798-2-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series mbuf: offload flags namespace |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Olivier Matz Oct. 15, 2021, 7:24 p.m. UTC
  The flags PKT_RX_L4_CKSUM_BAD and PKT_RX_IP_CKSUM_BAD are defined
twice with the same value. Remove one of the occurence, which was
marked as "deprecated".

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 lib/mbuf/rte_mbuf_core.h | 18 ------------------
 1 file changed, 18 deletions(-)
  

Comments

Andrew Rybchenko Oct. 16, 2021, 7:47 a.m. UTC | #1
On 10/15/21 10:24 PM, Olivier Matz wrote:
> The flags PKT_RX_L4_CKSUM_BAD and PKT_RX_IP_CKSUM_BAD are defined
> twice with the same value. Remove one of the occurence, which was
> marked as "deprecated".
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
  

Patch

diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index d6f1679944..e1e0f4b51b 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -55,24 +55,6 @@  extern "C" {
  /** RX packet with FDIR match indicate. */
 #define PKT_RX_FDIR          (1ULL << 2)
 
-/**
- * Deprecated.
- * Checking this flag alone is deprecated: check the 2 bits of
- * PKT_RX_L4_CKSUM_MASK.
- * This flag was set when the L4 checksum of a packet was detected as
- * wrong by the hardware.
- */
-#define PKT_RX_L4_CKSUM_BAD  (1ULL << 3)
-
-/**
- * Deprecated.
- * Checking this flag alone is deprecated: check the 2 bits of
- * PKT_RX_IP_CKSUM_MASK.
- * This flag was set when the IP checksum of a packet was detected as
- * wrong by the hardware.
- */
-#define PKT_RX_IP_CKSUM_BAD  (1ULL << 4)
-
 /**
  * This flag is set when the outermost IP header checksum is detected as
  * wrong by the hardware.