From patchwork Thu Nov 4 09:40:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 103715 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32911A0548; Thu, 4 Nov 2021 10:41:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B13AB40E5A; Thu, 4 Nov 2021 10:40:59 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2045.outbound.protection.outlook.com [40.107.102.45]) by mails.dpdk.org (Postfix) with ESMTP id 4620940DFD; Thu, 4 Nov 2021 10:40:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=apGr6fC5rajFRjzkZFvuMRWxxQGSmGfBtN0SqQojx8WzFZcdBfPyVoYPMpyvvwdvLl9OllWFwUsuKzU6qmF+KmFCMMxBiELu/6R7PVcKaS+TeaMC+FnwtkHzRL8JMRMekbHGF0K2JkM+1EU85EAj1lXTZ1JlyZjBjImStANb23DKVE2fAfbQnlxLep96Gb+B+vYeXmBKzXvA4xCUy/JsjJs0Pi/1pI9weL4rZWbY0JQGcscoLflEJKXmIitm5tNcpWNWr31yJj7mPrBpKELFAUTHSPwUDkYXmYFeghZITCOfXmRPzJfi2gyJllYKOYcy6lQxloLx/OPYtA4kj0IiLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mkjsfSNr7zk510hUoXLfp8FkRmrdhzvb7sh9oxZWRPc=; b=fdkbW9VIME8LaN6Fixsj8ZQ6lvAVHKte1m5yTBW82yjTlvwHt36EZyI8/SbO2wLhoe5hdG9ptE9oNqcHpkBqmpwXCRPkebRPUwYyruEVnIvyUyjNWaksNgulJcKeKJevRR7tQ7lLtpCOXonLym6UcLe782i6nYlvoQGHjr6YQmfiZeTFckJlQx1iMHavPxXvCAcwthjSZzCVmr42+D/WCmwYeTT4ZhUGkXX6y/yr1h0Uo5qUfYp6WYI5akurP248g9YWb1SXWXjG+nV+BvfQDZSbjqtsza8lwmlwCJD8uDmCljgUWjV231dkhVaEwT3VH6hT5h50WhZroyiUJ74yTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkjsfSNr7zk510hUoXLfp8FkRmrdhzvb7sh9oxZWRPc=; b=L8rDum6Wt6M6Qs5ObnhSdi77IfJkaCjYM9ySpnpD3JLYJ7nkkzG9HfUAoefrq2T7IMvBLufN64lmqaV1gYW8H0yk6NoPsZU5r2pULvIS4Rxc/cuPPE55PqaAcARjAMlk/Vmik7HE5VnuOlvx1rx/5j8MaUyc+1DSSpf4DhvUdU4f8kdD2zp8fW9CvYoPnxktt5yHD5hJDLmi0mLElFsQetO0TaAlT3GShBMJDH0/gAigZD9Oy4dv6nTDvydW3fUY+2J5uT8JGVeK0FzejPeMLwKIsD/tQLc9O0WBq3xASQVVsszV+C61hGx35shQSxqNpGTO+OQyK4FvFSqT1oUw7w== Received: from BN0PR10CA0021.namprd10.prod.outlook.com (2603:10b6:408:143::24) by DM6PR12MB2860.namprd12.prod.outlook.com (2603:10b6:5:186::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Thu, 4 Nov 2021 09:40:56 +0000 Received: from BN8NAM11FT062.eop-nam11.prod.protection.outlook.com (2603:10b6:408:143:cafe::14) by BN0PR10CA0021.outlook.office365.com (2603:10b6:408:143::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Thu, 4 Nov 2021 09:40:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT062.mail.protection.outlook.com (10.13.177.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Thu, 4 Nov 2021 09:40:54 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 4 Nov 2021 09:40:52 +0000 From: Raslan Darawsheh To: CC: , , Ori Kam , Xiaoyun Li Date: Thu, 4 Nov 2021 11:40:25 +0200 Message-ID: <20211104094027.9329-1-rasland@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211104093518.8922-1-rasland@nvidia.com> References: <20211104093518.8922-1-rasland@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5edfe74-ca57-4527-ab00-08d99f7732ca X-MS-TrafficTypeDiagnostic: DM6PR12MB2860: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QR6mnXmwQSBfdye6jviA9e/ZoRPDGd4Ri1AW2wMR1iqCuNQjIC7HfQ5fPRJuFzw5QdEmAoUMS5rBAk+KZ7gQ6K/zwZbdoSmDS1oa0+f311fRdSzmYOr1naCU8GVl1UZ9YpNJMiGtNXa3g9lsk7T2+d+6sn74xL2EswUeg300+duED8J7QYsmgP44y6BhVzrx5+Wo9pgJnv8qg8Q2c1Ft9UDNiztLTWVg0/ZPyOpk2aHNxCTV6j8asB6wyhNaUmbpldKLtQ1+V5F2nJWNl/O1u/7sMvpufwVWE0dgbhyyVDBkpEJ1GX5ZUyCPh9e8JViRzt+uYxqNxNzUgU8u8TQ+BkpqXWquMb9mPeQr8ZLJV+hr8Gz6m9O8pxjnNC+f76AHEzxlt6q/WQYkuDt6auk+OUguRa1wknyvwpH0HjPdjcx3p1dLF3rVvGuypm2+PiD0DtsUoXXtpJ1omy9OoceDI4ZE953dPkLKQHG92ShmoNCsbRwySaOJ3qv7ki3bXU93EFENQu9m0xC4z4lRyvAAJNf29IOapTbFaGnAxg0UQsobJz8PvQvsVymhAEYDyp5wmTpuPey/OQ1PRyRPi70QnzMTqucyh4BPcTmudCwtXpoQU22myARwjTtG+MOFKyTTqjllTzKTxtKA/+8U5KdIuQRUY2Pk400BWCX5Px+UnQCgkc4wY7BlwOTsaQE7r/T3Ta4ZqRfP8/GrBBehwXNFGw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(2906002)(47076005)(5660300002)(8676002)(70586007)(82310400003)(426003)(4326008)(70206006)(508600001)(6286002)(36756003)(356005)(6916009)(8936002)(26005)(86362001)(4744005)(7636003)(336012)(1076003)(54906003)(36860700001)(7696005)(6666004)(55016002)(186003)(16526019)(2616005)(316002)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 09:40:54.9364 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5edfe74-ca57-4527-ab00-08d99f7732ca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT062.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2860 Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Current implementation for raw encap sets the length to be in bytes, but, GTP 'extension' header length is an 8-bit field in 4-octet units. This fixes the length calculation of the header length. Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets") Cc: viacheslavo@nvidia.com Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh Reviewed-by: Viacheslav Ovsiienko --- v2: fix spelling issues --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 24b224e632..b4c5aacdbe 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in) uint8_t qfi:6; uint8_t next; } psc; - psc.len = sizeof(psc); + psc.len = sizeof(psc) / 4; psc.pdu_type = opt->hdr.type; psc.qfi = opt->hdr.qfi; psc.next = 0;