ci: enable ppc64le cross compilation in GHA

Message ID 20211105204020.1098032-1-drc@linux.vnet.ibm.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series ci: enable ppc64le cross compilation in GHA |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-spell-check-testing warning Testing issues
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

David Christensen Nov. 5, 2021, 8:40 p.m. UTC
  Enable Github Actions to cross-compile code for POWER systems.

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
 .ci/linux-build.sh                      |  6 +++++-
 .github/workflows/build.yml             | 15 ++++++++++++++-
 config/ppc/ppc64le-power8-linux-gcc-GHA | 11 +++++++++++
 3 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 config/ppc/ppc64le-power8-linux-gcc-GHA
  

Comments

David Marchand Nov. 8, 2021, 12:06 p.m. UTC | #1
On Fri, Nov 5, 2021 at 9:40 PM David Christensen <drc@linux.vnet.ibm.com> wrote:
>
> Enable Github Actions to cross-compile code for POWER systems.
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
>  .ci/linux-build.sh                      |  6 +++++-
>  .github/workflows/build.yml             | 15 ++++++++++++++-
>  config/ppc/ppc64le-power8-linux-gcc-GHA | 11 +++++++++++
>  3 files changed, 30 insertions(+), 2 deletions(-)
>  create mode 100644 config/ppc/ppc64le-power8-linux-gcc-GHA
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index e1f5255327..52766b3811 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -64,6 +64,10 @@ if [ "$AARCH64" = "true" ]; then
>      fi
>  fi
>
> +if [ "$PPC64LE" = "true" ]; then
> +    OPTS="$OPTS --cross-file config/ppc/ppc64le-power8-linux-gcc-GHA"
> +fi
> +
>  if [ "$BUILD_DOCS" = "true" ]; then
>      OPTS="$OPTS -Denable_docs=true"
>  fi
> @@ -86,7 +90,7 @@ OPTS="$OPTS -Dcheck_includes=true"
>  meson build --werror $OPTS
>  ninja -C build
>
> -if [ "$AARCH64" != "true" ]; then
> +if [ "$AARCH64" != "true" ] && [ "$PPC64LE" != "true" ]; then
>      failed=
>      configure_coredump
>      devtools/test-null.sh || failed="true"
> diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> index 9cc96121b6..4151cafee7 100644
> --- a/.github/workflows/build.yml
> +++ b/.github/workflows/build.yml
> @@ -21,6 +21,7 @@ jobs:
>        CC: ccache ${{ matrix.config.compiler }}
>        DEF_LIB: ${{ matrix.config.library }}
>        LIBABIGAIL_VERSION: libabigail-1.8
> +      PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
>        REF_GIT_TAG: none
>        RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}
>
> @@ -56,6 +57,14 @@ jobs:
>              compiler: gcc
>              library: shared
>              cross: aarch64
> +          - os: ubuntu-18.04
> +            compiler: gcc
> +            library: static
> +            cross: ppc64le
> +          - os: ubuntu-18.04
> +            compiler: gcc
> +            library: shared
> +            cross: ppc64le
>
>      steps:
>      - name: Checkout sources
> @@ -107,8 +116,12 @@ jobs:
>        if: env.AARCH64 == 'true'
>        run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
>          pkg-config-aarch64-linux-gnu
> +    - name: Install ppc64le cross compiling packages
> +      if: env.PPC64LE == 'true'
> +      run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross
> +        pkg-config-powerpc-linux-gnu
>      - name: Install test tools packages
> -      if: env.AARCH64 != 'true' || env.RUN_TESTS == 'true'
> +      if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RUN_TESTS == 'true'
>        run: sudo apt install -y gdb
>      - name: Install doc generation packages
>        if: env.BUILD_DOCS == 'true'
> diff --git a/config/ppc/ppc64le-power8-linux-gcc-GHA b/config/ppc/ppc64le-power8-linux-gcc-GHA
> new file mode 100644
> index 0000000000..803c612cbc
> --- /dev/null
> +++ b/config/ppc/ppc64le-power8-linux-gcc-GHA
> @@ -0,0 +1,11 @@
> +[binaries]
> +c = 'powerpc64le-linux-gnu-gcc'
> +cpp = 'powerpc64le-linux-gnu-cpp'
> +ar = 'powerpc64le-linux-gnu-ar'
> +strip = 'powerpc64le-linux-gnu-strip'
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'ppc64'
> +cpu = 'power8'
> +endian = 'little'
> --
> 2.27.0
>

There is nothing specific to GHA in this cross compilation config file.
I would call it config/ppc/ppc64le-power8-linux-gcc-ubuntu1804 (in the
same way we have one a config for arm).

The rest lgtm.
  

Patch

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index e1f5255327..52766b3811 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -64,6 +64,10 @@  if [ "$AARCH64" = "true" ]; then
     fi
 fi
 
+if [ "$PPC64LE" = "true" ]; then
+    OPTS="$OPTS --cross-file config/ppc/ppc64le-power8-linux-gcc-GHA"
+fi
+
 if [ "$BUILD_DOCS" = "true" ]; then
     OPTS="$OPTS -Denable_docs=true"
 fi
@@ -86,7 +90,7 @@  OPTS="$OPTS -Dcheck_includes=true"
 meson build --werror $OPTS
 ninja -C build
 
-if [ "$AARCH64" != "true" ]; then
+if [ "$AARCH64" != "true" ] && [ "$PPC64LE" != "true" ]; then
     failed=
     configure_coredump
     devtools/test-null.sh || failed="true"
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9cc96121b6..4151cafee7 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -21,6 +21,7 @@  jobs:
       CC: ccache ${{ matrix.config.compiler }}
       DEF_LIB: ${{ matrix.config.library }}
       LIBABIGAIL_VERSION: libabigail-1.8
+      PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
       REF_GIT_TAG: none
       RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}
 
@@ -56,6 +57,14 @@  jobs:
             compiler: gcc
             library: shared
             cross: aarch64
+          - os: ubuntu-18.04
+            compiler: gcc
+            library: static
+            cross: ppc64le
+          - os: ubuntu-18.04
+            compiler: gcc
+            library: shared
+            cross: ppc64le
 
     steps:
     - name: Checkout sources
@@ -107,8 +116,12 @@  jobs:
       if: env.AARCH64 == 'true'
       run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
         pkg-config-aarch64-linux-gnu
+    - name: Install ppc64le cross compiling packages
+      if: env.PPC64LE == 'true'
+      run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross
+        pkg-config-powerpc-linux-gnu
     - name: Install test tools packages
-      if: env.AARCH64 != 'true' || env.RUN_TESTS == 'true'
+      if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RUN_TESTS == 'true'
       run: sudo apt install -y gdb
     - name: Install doc generation packages
       if: env.BUILD_DOCS == 'true'
diff --git a/config/ppc/ppc64le-power8-linux-gcc-GHA b/config/ppc/ppc64le-power8-linux-gcc-GHA
new file mode 100644
index 0000000000..803c612cbc
--- /dev/null
+++ b/config/ppc/ppc64le-power8-linux-gcc-GHA
@@ -0,0 +1,11 @@ 
+[binaries]
+c = 'powerpc64le-linux-gnu-gcc'
+cpp = 'powerpc64le-linux-gnu-cpp'
+ar = 'powerpc64le-linux-gnu-ar'
+strip = 'powerpc64le-linux-gnu-strip'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'ppc64'
+cpu = 'power8'
+endian = 'little'