diff mbox series

common/qat: fix overrun of qp config

Message ID 20211112120156.12862-1-arkadiuszx.kusztal@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series common/qat: fix overrun of qp config |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Arkadiusz Kusztal Nov. 12, 2021, 12:01 p.m. UTC 
  This commint fixes overrun of ring configuration
due to insufficient check.

Fixes: 4badfb0205f7 ("common/qat: fix queue pairs number")
Cc: przemyslawx.zegan@intel.com

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/common/qat/dev/qat_dev_gen1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Power, Ciara Nov. 12, 2021, 2:03 p.m. UTC | #1 
Hi Arek,

>-----Original Message-----
>From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
>Sent: Friday 12 November 2021 12:02
>To: dev@dpdk.org
>Cc: gakhil@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Power,
>Ciara <ciara.power@intel.com>; Kusztal, ArkadiuszX
><arkadiuszx.kusztal@intel.com>; Zegan, PrzemyslawX
><przemyslawx.zegan@intel.com>
>Subject: [PATCH] common/qat: fix overrun of qp config
>
>This commint fixes overrun of ring configuration due to insufficient check.
Small typo here: commint -> commit

>
>Fixes: 4badfb0205f7 ("common/qat: fix queue pairs number")
>Cc: przemyslawx.zegan@intel.com
>
>Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>---

Asides from that, the patch looks good to me.
Acked-by: Ciara Power <ciara.power@intel.com>
Akhil Goyal Nov. 16, 2021, 7:31 a.m. UTC | #2 
> >Subject: [PATCH] common/qat: fix overrun of qp config
> >
> >This commint fixes overrun of ring configuration due to insufficient check.
> Small typo here: commint -> commit

Fixed while merging.
> 
> >
> >Fixes: 4badfb0205f7 ("common/qat: fix queue pairs number")
> >Cc: przemyslawx.zegan@intel.com
> >
> >Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> >---
> 
> Asides from that, the patch looks good to me.
> Acked-by: Ciara Power <ciara.power@intel.com>

Applied to dpdk-next-crypto
Cc:stable@dpdk.org
diff mbox series

Patch

diff --git a/drivers/common/qat/dev/qat_dev_gen1.c b/drivers/common/qat/dev/qat_dev_gen1.c
index 64d02e4817..c34ae5a51c 100644
--- a/drivers/common/qat/dev/qat_dev_gen1.c
+++ b/drivers/common/qat/dev/qat_dev_gen1.c
@@ -95,7 +95,7 @@  qat_qp_rings_per_service_gen1(struct qat_pci_device *qat_dev,
 
 		if (hw_qps == NULL)
 			continue;
-		if (hw_qps->service_type == service)
+		if (hw_qps->service_type == service && hw_qps->tx_msg_size)
 			count++;
 	}