From patchwork Mon Nov 15 03:29:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Wang X-Patchwork-Id: 104293 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AB34A0C43; Mon, 15 Nov 2021 04:31:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAF3840E01; Mon, 15 Nov 2021 04:31:05 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 76B3640141 for ; Mon, 15 Nov 2021 04:31:04 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="319580322" X-IronPort-AV: E=Sophos;i="5.87,235,1631602800"; d="scan'208";a="319580322" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2021 19:31:03 -0800 X-IronPort-AV: E=Sophos;i="5.87,235,1631602800"; d="scan'208";a="505733457" Received: from dpdk.cd.intel.com ([10.240.178.133]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2021 19:31:01 -0800 From: Jie Wang To: dev@dpdk.org Cc: yuying.zhang@intel.com, xiaoyun.li@intel.com, stevex.yang@intel.com, Jie Wang Subject: [PATCH v3] app/testpmd: fix DCB in VT configuration Date: Mon, 15 Nov 2021 11:29:58 +0800 Message-Id: <20211115032958.2535862-1-jie1x.wang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211110090842.912936-1-jie1x.wang@intel.com> References: <20211110090842.912936-1-jie1x.wang@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When set port DCB in VT mode enabled, it should remove RSS HASH offload before reconfiguring the device and queues. Because port multi-queue mode is changed from RSS to DCB in VT. Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") Signed-off-by: Jie Wang Acked-by: Aman Deep Singh --- v3: * update commit log. * remove RSS HASh offload from DCB in VT. v2: * update commit log. * remove RSS HASH offload from port->rx_conf[i].offloads. --- app/test-pmd/testpmd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index a66dfb297c..c18942279a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3948,6 +3948,13 @@ init_port_dcb_config(portid_t pid, if (retval < 0) return retval; port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER; + /* remove RSS HASH offload for DCB in vt mode */ + if (port_conf.rxmode.mq_mode == RTE_ETH_MQ_RX_VMDQ_DCB) { + port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH; + for (i = 0; i < nb_rxq; i++) + rte_port->rx_conf[i].offloads &= + ~RTE_ETH_RX_OFFLOAD_RSS_HASH; + } /* re-configure the device . */ retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);