diff mbox series

[v1] app/testpmd: avoid the process ID out of range

Message ID 20211115060509.216653-1-haiyue.wang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v1] app/testpmd: avoid the process ID out of range |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Wang, Haiyue Nov. 15, 2021, 6:05 a.m. UTC 
  The 'proc-id' should be less than 'num-procs', if not, exit the testpmd
and show the error message.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 app/test-pmd/parameters.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

humin (Q) Nov. 15, 2021, 8:56 a.m. UTC | #1 
Acked-by:  Min Hu (Connor) <humin29@huawei.com>

在 2021/11/15 14:05, Haiyue Wang 写道:
> The 'proc-id' should be less than 'num-procs', if not, exit the testpmd
> and show the error message.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>   app/test-pmd/parameters.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index 0974b0a38f..5251722d0f 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -1527,6 +1527,12 @@ launch_args_parse(int argc, char** argv)
>   		rte_exit(EXIT_FAILURE, "Command line is incorrect\n");
>   	}
>   
> +	if (proc_id >= (int)num_procs)
> +		rte_exit(EXIT_FAILURE,
> +			 "The multi-process option '%s(%d)' should be less than '%s(%u)'\n",
> +			 PARAM_PROC_ID, proc_id,
> +			 PARAM_NUM_PROCS, num_procs);
> +
>   	/* Set offload configuration from command line parameters. */
>   	rx_mode.offloads = rx_offloads;
>   	tx_mode.offloads = tx_offloads;
>
Ferruh Yigit Nov. 15, 2021, 3:18 p.m. UTC | #2 
On 11/15/2021 8:56 AM, Min Hu (Connor) wrote:

> 
> 在 2021/11/15 14:05, Haiyue Wang 写道:
>> The 'proc-id' should be less than 'num-procs', if not, exit the testpmd
>> and show the error message.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>>
>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > Acked-by:  Min Hu (Connor) <humin29@huawei.com>> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 0974b0a38f..5251722d0f 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -1527,6 +1527,12 @@  launch_args_parse(int argc, char** argv)
 		rte_exit(EXIT_FAILURE, "Command line is incorrect\n");
 	}
 
+	if (proc_id >= (int)num_procs)
+		rte_exit(EXIT_FAILURE,
+			 "The multi-process option '%s(%d)' should be less than '%s(%u)'\n",
+			 PARAM_PROC_ID, proc_id,
+			 PARAM_NUM_PROCS, num_procs);
+
 	/* Set offload configuration from command line parameters. */
 	rx_mode.offloads = rx_offloads;
 	tx_mode.offloads = tx_offloads;