diff mbox series

net/bnxt: fix autoneg on PAM4 links

Message ID 20211118040439.24583-1-somnath.kotur@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ajit Khaparde
Headers
Series net/bnxt: fix autoneg on PAM4 links |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Somnath Kotur Nov. 18, 2021, 4:04 a.m. UTC 
  If autonegotiation was enabled, driver was not passing the
'auto_pam4_link_speeds' obtained during init and stored in bp->link_info
to bnxt_hwrm_port_phy_cfg(). This would result in an incorrect setting
being passed to the HW during PHY configuration. This in turn, would
result in invalid settings being retrieved and configured in subsequent
application loads resulting in launch failures.

Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link")

Reported-by: Charlie Brtee <cfb@hpe.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ajit Khaparde Nov. 18, 2021, 4:55 a.m. UTC | #1 
On Wed, Nov 17, 2021 at 8:11 PM Somnath Kotur
<somnath.kotur@broadcom.com> wrote:
>
> If autonegotiation was enabled, driver was not passing the
> 'auto_pam4_link_speeds' obtained during init and stored in bp->link_info
> to bnxt_hwrm_port_phy_cfg(). This would result in an incorrect setting
> being passed to the HW during PHY configuration. This in turn, would
> result in invalid settings being retrieved and configured in subsequent
> application loads resulting in launch failures.
>
> Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link")
>
> Reported-by: Charlie Brtee <cfb@hpe.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Merged in dpdk-next-net-brcm.

Fixed up typo in Charle's name.
Added Bugzilla ID and stable@dpdk.org

Thanks
Ajit

> ---
>  drivers/net/bnxt/bnxt_hwrm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index 67ed807dad..df75047e2d 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -3247,6 +3247,8 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up)
>                 link_req.auto_link_speed_mask =
>                         bnxt_parse_eth_link_speed_mask(bp,
>                                                        dev_conf->link_speeds);
> +               link_req.auto_pam4_link_speeds =
> +                       bp->link_info->auto_pam4_link_speeds;
>         } else {
>                 if (bp->link_info->phy_type ==
>                     HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASET ||
> --
> 2.28.0.497.g54e85e7
>
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 67ed807dad..df75047e2d 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -3247,6 +3247,8 @@  int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up)
 		link_req.auto_link_speed_mask =
 			bnxt_parse_eth_link_speed_mask(bp,
 						       dev_conf->link_speeds);
+		link_req.auto_pam4_link_speeds =
+			bp->link_info->auto_pam4_link_speeds;
 	} else {
 		if (bp->link_info->phy_type ==
 		    HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASET ||