From patchwork Fri Nov 19 05:38:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 104526 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF10DA0C47; Fri, 19 Nov 2021 06:40:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F8C740143; Fri, 19 Nov 2021 06:40:27 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 021A440140 for ; Fri, 19 Nov 2021 06:40:27 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id b13so7306290plg.2 for ; Thu, 18 Nov 2021 21:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version; bh=Yh7eiaHaqiODpyBO+O57HJAFoXFvAgtPgYOY87D+cbs=; b=WND6nNFCog8giUGCyQCSkHvVU6Z5Z1J9F5QJT2fUz68lvCr1/NeRVPsunvBf4RLUAR j/o4/m5zoTb7EUNmT5AbkzZ7p5MhLXIeLyorQZWLlw1F1Gkw+FRCkPJ0SwLVCWQVhjz1 ie9qsSybIZtnvw1t76qHdMpzXYIUo6iEipHa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=Yh7eiaHaqiODpyBO+O57HJAFoXFvAgtPgYOY87D+cbs=; b=Rlz68IgFXs2WEtQ5j5XHsOWRL63e/+bNYhWDPWZ0obD6RQ1op6eL9dW+oveanVRmHC IjN0uGvLBXx8cTDqWgE3iL8bRp/d9F3b/M9hmeE3jrnFT7MjMn8vZB1RR0XNzxOrJSH7 35shDNguGd3iApsGivYZAuJs1CcA/f7ZIbXvCGZ1zEsV0Y9tRQIM8lVdBIDIOylicYHQ Fl7Q5kL4+BDUhYOV0so/gBEGHh3IZaO4WOy5tcjlr1CE3VktdzFif3bi3egX2AlT/X/l 5gHeUKurPMv0J52kEDrv9ZT9DiaJ731Uq/zXrRz6VTN3uL8dhAc7+//zoHutaO7B+67Z 1hqg== X-Gm-Message-State: AOAM530bXjMOEwOb9FPV1UIwzkczO/1TsImlQW2/Z5f0Bcwr7+6/xUKs ltHXqGSnLcwVE6jJZobe8d96KPLM3nRsg3cLztk88dn57vp893erlk762x9s73ybtQ0ebx2VHuM UVLuj12Zoh0mGz6VMJaxVcAIsn0OZC+4+D0czsuZTBGgRUugnCz3ubH73S0JiMPI= X-Google-Smtp-Source: ABdhPJxOBpqD3VxxPkflIJsdnxPk8INo2MGWmpEwVSZ0Zy+FTevl7245R9ERqjwfBLnfl/g3s+tbpA== X-Received: by 2002:a17:90b:92:: with SMTP id bb18mr1417258pjb.133.1637300425742; Thu, 18 Nov 2021 21:40:25 -0800 (PST) Received: from localhost.localdomain ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id i2sm1446078pfg.90.2021.11.18.21.40.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Nov 2021 21:40:25 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Somnath Kotur , Kalesh AP Subject: [PATCH] net/bnxt: fail init when mbuf allocation fails Date: Thu, 18 Nov 2021 21:38:21 -0800 Message-Id: <20211119053821.93989-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix driver init when Rx mbuf allocation fails. If we continue to use the driver with whatever rings were created successfully, it can cause unexpected behavior. Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_hwrm.c | 41 ++++++++++++++++++++++-------------- drivers/net/bnxt/bnxt_ring.c | 5 +++-- drivers/net/bnxt/bnxt_rxr.c | 8 +++---- 3 files changed, 32 insertions(+), 22 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 7f51c61097..f53f8632fe 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2633,6 +2633,8 @@ bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp) cpr = bp->rx_queues[i]->cp_ring; if (BNXT_HAS_RING_GRPS(bp)) bp->grp_info[i].fw_stats_ctx = -1; + if (cpr == NULL) + continue; rc = bnxt_hwrm_stat_ctx_free(bp, cpr); if (rc) return rc; @@ -2640,6 +2642,8 @@ bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp) for (i = 0; i < bp->tx_cp_nr_rings; i++) { cpr = bp->tx_queues[i]->cp_ring; + if (cpr == NULL) + continue; rc = bnxt_hwrm_stat_ctx_free(bp, cpr); if (rc) return rc; @@ -2697,16 +2701,17 @@ void bnxt_free_cp_ring(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) void bnxt_free_hwrm_rx_ring(struct bnxt *bp, int queue_index) { struct bnxt_rx_queue *rxq = bp->rx_queues[queue_index]; - struct bnxt_rx_ring_info *rxr = rxq->rx_ring; - struct bnxt_ring *ring = rxr->rx_ring_struct; - struct bnxt_cp_ring_info *cpr = rxq->cp_ring; + struct bnxt_rx_ring_info *rxr = rxq ? rxq->rx_ring : NULL; + struct bnxt_ring *ring = rxr ? rxr->rx_ring_struct : NULL; + struct bnxt_cp_ring_info *cpr = rxq ? rxq->cp_ring : NULL; if (BNXT_HAS_RING_GRPS(bp)) bnxt_hwrm_ring_grp_free(bp, queue_index); - bnxt_hwrm_ring_free(bp, ring, - HWRM_RING_FREE_INPUT_RING_TYPE_RX, - cpr->cp_ring_struct->fw_ring_id); + if (ring != NULL && cpr != NULL) + bnxt_hwrm_ring_free(bp, ring, + HWRM_RING_FREE_INPUT_RING_TYPE_RX, + cpr->cp_ring_struct->fw_ring_id); if (BNXT_HAS_RING_GRPS(bp)) bp->grp_info[queue_index].rx_fw_ring_id = INVALID_HW_RING_ID; @@ -2715,22 +2720,26 @@ void bnxt_free_hwrm_rx_ring(struct bnxt *bp, int queue_index) * but we may have to deal with agg ring struct before the offload * flags are updated. */ - if (!bnxt_need_agg_ring(bp->eth_dev) || rxr->ag_ring_struct == NULL) + if (!bnxt_need_agg_ring(bp->eth_dev) || + (rxr && rxr->ag_ring_struct == NULL)) goto no_agg; - ring = rxr->ag_ring_struct; - bnxt_hwrm_ring_free(bp, ring, - BNXT_CHIP_P5(bp) ? - HWRM_RING_FREE_INPUT_RING_TYPE_RX_AGG : - HWRM_RING_FREE_INPUT_RING_TYPE_RX, - cpr->cp_ring_struct->fw_ring_id); + ring = rxr ? rxr->ag_ring_struct : NULL; + if (ring != NULL && cpr != NULL) { + bnxt_hwrm_ring_free(bp, ring, + BNXT_CHIP_P5(bp) ? + HWRM_RING_FREE_INPUT_RING_TYPE_RX_AGG : + HWRM_RING_FREE_INPUT_RING_TYPE_RX, + cpr->cp_ring_struct->fw_ring_id); + } if (BNXT_HAS_RING_GRPS(bp)) bp->grp_info[queue_index].ag_fw_ring_id = INVALID_HW_RING_ID; no_agg: - bnxt_hwrm_stat_ctx_free(bp, cpr); - - bnxt_free_cp_ring(bp, cpr); + if (cpr != NULL) { + bnxt_hwrm_stat_ctx_free(bp, cpr); + bnxt_free_cp_ring(bp, cpr); + } if (BNXT_HAS_RING_GRPS(bp)) bp->grp_info[queue_index].cp_fw_ring_id = INVALID_HW_RING_ID; diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c index 7940d489a1..dc437f314e 100644 --- a/drivers/net/bnxt/bnxt_ring.c +++ b/drivers/net/bnxt/bnxt_ring.c @@ -648,8 +648,9 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index) if (rxq->rx_started) { if (bnxt_init_one_rx_ring(rxq)) { - PMD_DRV_LOG(ERR, "bnxt_init_one_rx_ring failed!\n"); - bnxt_rx_queue_release_op(bp->eth_dev, queue_index); + PMD_DRV_LOG(ERR, + "ring%d bnxt_init_one_rx_ring failed!\n", + queue_index); rc = -ENOMEM; goto err_out; } diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index e2f09ad3a0..44247d7200 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -1332,9 +1332,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq) if (unlikely(!rxr->rx_buf_ring[i])) { if (bnxt_alloc_rx_data(rxq, rxr, raw_prod) != 0) { PMD_DRV_LOG(WARNING, - "init'ed rx ring %d with %d/%d mbufs only\n", + "RxQ %d allocated %d of %d mbufs\n", rxq->queue_id, i, ring->ring_size); - break; + return -ENOMEM; } } rxr->rx_raw_prod = raw_prod; @@ -1362,9 +1362,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq) if (unlikely(!rxr->ag_buf_ring[i])) { if (bnxt_alloc_ag_data(rxq, rxr, raw_prod) != 0) { PMD_DRV_LOG(WARNING, - "init'ed AG ring %d with %d/%d mbufs only\n", + "RxQ %d allocated %d of %d mbufs\n", rxq->queue_id, i, ring->ring_size); - break; + return -ENOMEM; } } rxr->ag_raw_prod = raw_prod;