| Message ID | 20211125100152.2838529-1-thomas@monjalon.net (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2] maintainers: update for testpmd | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-x86_64-compile-testing | success | Testing PASS |
| ci/iol-x86_64-unit-testing | success | Testing PASS |
| ci/iol-aarch64-compile-testing | success | Testing PASS |
| ci/iol-aarch64-unit-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/github-robot: build | success | github build: passed |
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
On 11/25/2021 10:01 AM, Thomas Monjalon wrote: > From: Aman Singh <aman.deep.singh@intel.com> > > Add Aman Singh as co-maintainer of testpmd. > > Make the title description more accurate for this tool. > > Signed-off-by: Aman Singh <aman.deep.singh@intel.com> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- > v2: update the section title > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d785363c5c..1b259a3d98 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com> > F: app/test/sample_packet_forward.c > F: app/test/sample_packet_forward.h > > -Driver testing tool > +Networking features testing tool "Networking features" scope is a little wide. Not sure if "Networking features" or "Networking drivers" suits better, according previous title it is for driver testing. > M: Xiaoyun Li <xiaoyun.li@intel.com> > +M: Aman Singh <aman.deep.singh@intel.com> > T: git://dpdk.org/next/dpdk-next-net > F: app/test-pmd/ > F: doc/guides/testpmd_app_ug/ >
25/11/2021 14:40, Ferruh Yigit: > On 11/25/2021 10:01 AM, Thomas Monjalon wrote: > > -Driver testing tool > > +Networking features testing tool > > "Networking features" scope is a little wide. > Not sure if "Networking features" or "Networking drivers" suits better, > according previous title it is for driver testing. Yes it is for drivers features. I want to distinguish testpmd and other tools like test-flow-perf which is also testing networking drivers. Maybe "Networking drivers features testing tool" ?
On 11/25/2021 3:20 PM, Thomas Monjalon wrote: > 25/11/2021 14:40, Ferruh Yigit: >> On 11/25/2021 10:01 AM, Thomas Monjalon wrote: >>> -Driver testing tool >>> +Networking features testing tool >> >> "Networking features" scope is a little wide. >> Not sure if "Networking features" or "Networking drivers" suits better, >> according previous title it is for driver testing. > > Yes it is for drivers features. > I want to distinguish testpmd and other tools like test-flow-perf > which is also testing networking drivers. > > Maybe "Networking drivers features testing tool" ? > ack
On 11/25/2021 4:04 PM, Ferruh Yigit wrote: > On 11/25/2021 3:20 PM, Thomas Monjalon wrote: >> 25/11/2021 14:40, Ferruh Yigit: >>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote: >>>> -Driver testing tool >>>> +Networking features testing tool >>> >>> "Networking features" scope is a little wide. >>> Not sure if "Networking features" or "Networking drivers" suits better, >>> according previous title it is for driver testing. >> >> Yes it is for drivers features. >> I want to distinguish testpmd and other tools like test-flow-perf >> which is also testing networking drivers. >> >> Maybe "Networking drivers features testing tool" ? >> > > ack > thinking twice what additional meaning does 'features' adds here, "Networking drivers features testing" vs "Networking drivers testing" Isn't "Networking drivers testing" implies features of drivers?
25/11/2021 17:31, Ferruh Yigit: > On 11/25/2021 4:04 PM, Ferruh Yigit wrote: > > On 11/25/2021 3:20 PM, Thomas Monjalon wrote: > >> 25/11/2021 14:40, Ferruh Yigit: > >>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote: > >>>> -Driver testing tool > >>>> +Networking features testing tool > >>> > >>> "Networking features" scope is a little wide. > >>> Not sure if "Networking features" or "Networking drivers" suits better, > >>> according previous title it is for driver testing. > >> > >> Yes it is for drivers features. > >> I want to distinguish testpmd and other tools like test-flow-perf > >> which is also testing networking drivers. > >> > >> Maybe "Networking drivers features testing tool" ? > >> > > > > ack > > > > thinking twice what additional meaning does 'features' adds here, > "Networking drivers features testing" > vs > "Networking drivers testing" > > Isn't "Networking drivers testing" implies features of drivers? Yes I was trying to avoid being too generic, because the same title could apply to flow-perf. But not mentioning "performance" should be enough. OK for "Networking drivers testing tool"
diff --git a/MAINTAINERS b/MAINTAINERS index d785363c5c..1b259a3d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com> F: app/test/sample_packet_forward.c F: app/test/sample_packet_forward.h -Driver testing tool +Networking features testing tool M: Xiaoyun Li <xiaoyun.li@intel.com> +M: Aman Singh <aman.deep.singh@intel.com> T: git://dpdk.org/next/dpdk-next-net F: app/test-pmd/ F: doc/guides/testpmd_app_ug/