diff mbox series

[v2,5/8] crypto/dpaa2_sec: change digest size for AES_CMAC

Message ID 20211228091058.3620177-6-g.singh@nxp.com (mailing list archive)
State Changes Requested, archived
Delegated to: akhil goyal
Headers
Series NXP crypto drivers changes |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Gagandeep Singh Dec. 28, 2021, 9:10 a.m. UTC 
  From: Hemant Agrawal <hemant.agrawal@nxp.com>

Change the digest size to supported value by the HW engine.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Akhil Goyal Jan. 21, 2022, 11:23 a.m. UTC | #1 
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> Change the digest size to supported value by the HW engine.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> index 6aa1c01e95..ab652936bc 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> @@ -579,11 +579,11 @@ static const struct rte_cryptodev_capabilities
> dpaa2_sec_capabilities[] = {
>  					.increment = 1
>  				},
>  				.digest_size = {
> -					.min = 4,
> +					.min = 12,
>  					.max = 16,
>  					.increment = 4
>  				},
> -				.aad_size = { 0 }
> +				.iv_size = { 0 }
Digest size is changed but why is aad_size removed in this patch.
Gagandeep Singh Feb. 8, 2022, 2:11 p.m. UTC | #2 
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Friday, January 21, 2022 4:54 PM
> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: RE: [EXT] [PATCH v2 5/8] crypto/dpaa2_sec: change digest size for
> AES_CMAC
> 
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> >
> > Change the digest size to supported value by the HW engine.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >  drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> > b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> > index 6aa1c01e95..ab652936bc 100644
> > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> > @@ -579,11 +579,11 @@ static const struct rte_cryptodev_capabilities
> > dpaa2_sec_capabilities[] = {
> >  					.increment = 1
> >  				},
> >  				.digest_size = {
> > -					.min = 4,
> > +					.min = 12,
> >  					.max = 16,
> >  					.increment = 4
> >  				},
> > -				.aad_size = { 0 }
> > +				.iv_size = { 0 }
> Digest size is changed but why is aad_size removed in this patch.
Will be fixed in next version.
diff mbox series

Patch

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
index 6aa1c01e95..ab652936bc 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
@@ -579,11 +579,11 @@  static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 4,
+					.min = 12,
 					.max = 16,
 					.increment = 4
 				},
-				.aad_size = { 0 }
+				.iv_size = { 0 }
 			}, }
 		}, }
 	},