diff mbox series

[V2] examples/pipeline: print table entries to file

Message ID 20220112185910.78377-1-cristian.dumitrescu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [V2] examples/pipeline: print table entries to file |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing warning Testing issues
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Cristian Dumitrescu Jan. 12, 2022, 6:59 p.m. UTC 
  Add support for the show CLI command to print table entries to a file
instead of standard output.

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Signed-off-by: Harshad Narayane <harshad.suresh.narayane@intel.com>
---
 examples/pipeline/cli.c | 34 +++++++++++++++++++++++++++-------
 1 file changed, 27 insertions(+), 7 deletions(-)

Comments

Thomas Monjalon Feb. 13, 2022, 8:50 p.m. UTC | #1 
12/01/2022 19:59, Cristian Dumitrescu:
> Add support for the show CLI command to print table entries to a file
> instead of standard output.
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Signed-off-by: Harshad Narayane <harshad.suresh.narayane@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
index c32349e5f0..edae63dae6 100644
--- a/examples/pipeline/cli.c
+++ b/examples/pipeline/cli.c
@@ -1346,7 +1346,7 @@  cmd_pipeline_table_default(char **tokens,
 }
 
 static const char cmd_pipeline_table_show_help[] =
-"pipeline <pipeline_name> table <table_name> show\n";
+"pipeline <pipeline_name> table <table_name> show [filename]\n";
 
 static void
 cmd_pipeline_table_show(char **tokens,
@@ -1357,9 +1357,10 @@  cmd_pipeline_table_show(char **tokens,
 {
 	struct pipeline *p;
 	char *pipeline_name, *table_name;
+	FILE *file = NULL;
 	int status;
 
-	if (n_tokens != 5) {
+	if (n_tokens != 5 && n_tokens != 6) {
 		snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);
 		return;
 	}
@@ -1372,9 +1373,18 @@  cmd_pipeline_table_show(char **tokens,
 	}
 
 	table_name = tokens[3];
-	status = rte_swx_ctl_pipeline_table_fprintf(stdout, p->ctl, table_name);
+	file = (n_tokens == 6) ? fopen(tokens[5], "w") : stdout;
+	if (!file) {
+		snprintf(out, out_size, "Cannot open file %s.\n", tokens[5]);
+		return;
+	}
+
+	status = rte_swx_ctl_pipeline_table_fprintf(file, p->ctl, table_name);
 	if (status)
 		snprintf(out, out_size, MSG_ARG_INVALID, "table_name");
+
+	if (file)
+		fclose(file);
 }
 
 static const char cmd_pipeline_selector_group_add_help[] =
@@ -1806,7 +1816,7 @@  cmd_pipeline_selector_group_member_delete(char **tokens,
 }
 
 static const char cmd_pipeline_selector_show_help[] =
-"pipeline <pipeline_name> selector <selector_name> show\n";
+"pipeline <pipeline_name> selector <selector_name> show [filename]\n";
 
 static void
 cmd_pipeline_selector_show(char **tokens,
@@ -1817,9 +1827,10 @@  cmd_pipeline_selector_show(char **tokens,
 {
 	struct pipeline *p;
 	char *pipeline_name, *selector_name;
+	FILE *file = NULL;
 	int status;
 
-	if (n_tokens != 5) {
+	if (n_tokens != 5 && n_tokens != 6) {
 		snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);
 		return;
 	}
@@ -1832,10 +1843,19 @@  cmd_pipeline_selector_show(char **tokens,
 	}
 
 	selector_name = tokens[3];
-	status = rte_swx_ctl_pipeline_selector_fprintf(stdout,
-		p->ctl, selector_name);
+
+	file = (n_tokens == 6) ? fopen(tokens[5], "w") : stdout;
+	if (!file) {
+		snprintf(out, out_size, "Cannot open file %s.\n", tokens[5]);
+		return;
+	}
+
+	status = rte_swx_ctl_pipeline_selector_fprintf(file, p->ctl, selector_name);
 	if (status)
 		snprintf(out, out_size, MSG_ARG_INVALID, "selector_name");
+
+	if (file)
+		fclose(file);
 }
 
 static int