From patchwork Fri Jan 14 20:46:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 105870 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B65D3A00C5; Fri, 14 Jan 2022 21:46:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 386264277E; Fri, 14 Jan 2022 21:46:49 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id CFAF340042 for ; Fri, 14 Jan 2022 21:46:47 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id f144so3040662pfa.6 for ; Fri, 14 Jan 2022 12:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KlV0HqtwgSdWuTtmI+L8noWgdzuds2YyAbyvGovuEyc=; b=09m/7gxPZjR8S4CvGjPiTYfawH9LJXl4RMMadMEF/N9+AY8wVIqARJxbC3IH3QffOc usiK9xNlm5WTECbP6OLqv81mpCvaaIZvxnEBpkVF1TegzWjfct3n6UJtq8mySxK7uHtl eLVIW+iPwwsUEJTNR+qawy3SOObXw4KLy4FEajFrxM5O9WRLFHJy4BILU00TjVOI13Vu LwjYP/g8Da9ezsE2jku/Fx02c/JtdSnoqQmyYFjtVyyPK9tBTA6iEZG9P8jY5SR52yzs uEi6N3dV1iQKYraMIhJghJsZMtlkt6Wnx8GqpWCbxAs6IcAcovurLUiGCPIMhVxRp6ic GW4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KlV0HqtwgSdWuTtmI+L8noWgdzuds2YyAbyvGovuEyc=; b=aVIymm85nlHwn5S0PanNA3cHQ3fqVBCFvNAmPW4ZAQL0c1/T88d2Di7kINX2BBl+xO WJkgBY53C16J/HZMTsc5ig+SjXGqYjQH+OENirnfR02oyMNOatftgp5vhXlroUXRWdzD IeOH11PLgjohjCCMlYv/HMJi2x9tpK+mzGtxApXwlMKDZpRlA5XVCTcpjwXJr/TwdiTE 7FGnA1uQ/n/LeNCVQTQhXqzTt7S6CWKhG47qbsdAE6NC7lZNAAZehBXGRrV4DFPpjvt9 bzLOrcd3+OugCF709AJGB1oZKPFgBsFgpYKmQUEFsmkQYucrSo0guxH4EYNALJbSRKx+ Fptg== X-Gm-Message-State: AOAM533fc/Law5kjfkg7Ixe8tHekgZLTkdRkwZyF+BGTq3PjcCleS4B9 GizF8dWjBPamJ3JZlhg4TAvN8w== X-Google-Smtp-Source: ABdhPJzf79IoSRmB8bjHZMvGIgXgxN43aF5Hsd2HyhJKnO7BLlHO9ck2m6/sjlf+wErvWl/yOe8vyw== X-Received: by 2002:a63:b20d:: with SMTP id x13mr9380520pge.310.1642193206880; Fri, 14 Jan 2022 12:46:46 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id f7sm7107937pfe.210.2022.01.14.12.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jan 2022 12:46:46 -0800 (PST) From: Stephen Hemminger To: jgrajcia@cisco.com, anatoly.burakov@intel.com Cc: dev@dpdk.org, Stephen Hemminger Subject: [PATCH] net/memif: remove unnecessary rx_intr stub Date: Fri, 14 Jan 2022 12:46:44 -0800 Message-Id: <20220114204644.351712-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The code in memif driver to stub out rx_irq_enable is unnecessary and causes different error returns than other drivers. The core ethdev code will return -ENOTSUP if the driver has a null rx_queue_intr_enable callback. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: jgrajcia@cisco.com Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Reviewed-by: Ferruh Yigit --- drivers/net/memif/rte_eth_memif.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 59cb5a82a23f..d3459c5007c4 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -1500,23 +1500,6 @@ memif_stats_reset(struct rte_eth_dev *dev) return 0; } -static int -memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused, - uint16_t qid __rte_unused) -{ - MIF_LOG(WARNING, "Interrupt mode not supported."); - - return -1; -} - -static int -memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid __rte_unused) -{ - struct pmd_internals *pmd __rte_unused = dev->data->dev_private; - - return 0; -} - static const struct eth_dev_ops ops = { .dev_start = memif_dev_start, .dev_stop = memif_dev_stop, @@ -1527,8 +1510,6 @@ static const struct eth_dev_ops ops = { .rx_queue_setup = memif_rx_queue_setup, .rx_queue_release = memif_rx_queue_release, .tx_queue_release = memif_tx_queue_release, - .rx_queue_intr_enable = memif_rx_queue_intr_enable, - .rx_queue_intr_disable = memif_rx_queue_intr_disable, .link_update = memif_link_update, .stats_get = memif_stats_get, .stats_reset = memif_stats_reset,