From patchwork Tue Jan 25 10:21:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ajmera, Megha" X-Patchwork-Id: 106495 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E07F8A00C2; Tue, 25 Jan 2022 11:21:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB559428F6; Tue, 25 Jan 2022 11:21:13 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 5A766426D8 for ; Tue, 25 Jan 2022 11:21:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643106072; x=1674642072; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=RaTisxD363yMJAIGTnufhShv1hXHBO/4phRE8x692pg=; b=NwQFCF4jhSVYYdy7uDYJ/pRlCyo8JwidIUIfih3ldfM/6xDTTT0rGlQG NYgohgcUf5B93jysYc4lH9iXeFQhQ7VA0MNuIMpGTkowU/c5fiofQpoNK EaFYpj8bmuEyTJM8WwLnTnnMOJfVVLjxF/OBLcON28shaicDaOUTqCxcF 2c27zDikbhd3V/nVQ//CqjsrxQsnNyoixIxhBLGK+lR7bCx2id1c4Qpax V/w06s8Tz7bJtmI9Kc/JhhNJ3d2+FlS+LX8/JtU1QLw123Ew+qBQxY4vL FYaJxeg9qeKrHe31uE/GmPCxhAPdgzjZx6/PjdoqUf04YVBpOG9pw7XT1 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="332625788" X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="332625788" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 02:21:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="520331637" Received: from silpixa00397515.ir.intel.com (HELO silpixa00397515.ger.corp.intel.com) ([10.237.222.51]) by orsmga007.jf.intel.com with ESMTP; 25 Jan 2022 02:21:10 -0800 From: Megha Ajmera To: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, thomas@monjalon.net Subject: [PATCH v2] sched: Cleanup qos scheduler defines from rte_config Date: Tue, 25 Jan 2022 10:21:05 +0000 Message-Id: <20220125102105.1719667-1-megha.ajmera@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h | 7 ------- doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- lib/sched/rte_sched.c | 4 ++++ 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/config/rte_config.h b/config/rte_config.h index cab4390a97..917097630e 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -88,13 +88,6 @@ /* rte_power defines */ #define RTE_MAX_LCORE_FREQS 64 -/* rte_sched defines */ -#undef RTE_SCHED_CMAN -#undef RTE_SCHED_COLLECT_STATS -#undef RTE_SCHED_SUBPORT_TC_OV -#define RTE_SCHED_PORT_N_GRINDERS 8 -#undef RTE_SCHED_VECTOR - /* KNI defines */ #define RTE_KNI_PREEMPT_DEFAULT 1 diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst index 49c14a00da..7016ca4078 100644 --- a/doc/guides/sample_app_ug/qos_scheduler.rst +++ b/doc/guides/sample_app_ug/qos_scheduler.rst @@ -42,8 +42,7 @@ The application is located in the ``qos_sched`` sub-directory. .. note:: To get statistics on the sample app using the command line interface as described in the next section, - DPDK must be compiled defining *RTE_SCHED_COLLECT_STATS*, which can be done by changing the relevant - entry in the ``config/rte_config.h`` file. + DPDK must be compiled after defining *RTE_SCHED_COLLECT_STATS* in the ``config/rte_config.h`` file. Running the Application ----------------------- diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 62b3d2e315..6c3e3bb0bf 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -35,6 +35,10 @@ #endif +#ifndef RTE_SCHED_PORT_N_GRINDERS +#define RTE_SCHED_PORT_N_GRINDERS 8 +#endif + #define RTE_SCHED_TB_RATE_CONFIG_ERR (1e-7) #define RTE_SCHED_WRR_SHIFT 3 #define RTE_SCHED_MAX_QUEUES_PER_TC RTE_SCHED_BE_QUEUES_PER_PIPE