From patchwork Thu Jan 27 15:39:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 106624 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57A01A0032; Thu, 27 Jan 2022 16:40:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 169F842802; Thu, 27 Jan 2022 16:40:11 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2056.outbound.protection.outlook.com [40.107.244.56]) by mails.dpdk.org (Postfix) with ESMTP id 7DAF94286C for ; Thu, 27 Jan 2022 16:40:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W9YpSB+fL5bh7ihiUIGKtzm5OMt7e7b3Smxf1QEOss8tm16jUvrQKJ5FSc8ZDKDNGnyxXgT1nSullp+6olQeKsWdfVNh0jx90b6xXTCFFdKFMFWU/4bc29RURE1pa0I7prLO1Xxgq4EoEiwQsY4NpobG4HQo6W7Hu7g5EBnqeB0WAAkGvuUY7D47tqX9sBUzllZ0gX5+E1e4BQ2oVkkOoDUOZ/+1lLE0NY3NbP4HvlYou6uoDJ9x+ZRhzcQsQTd9ns1OZyfega+hFGMakbcp1n+EcNaJS/8UEYCGoiHdmaLJFPnovVvaWIH8bBWK2xk8PldaA5IneCpunB9t0zUuXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tdqNLlq1FNV4G16/pD4sjtiwZvFIZ+iZ6euAfhWgcdw=; b=lpVtaHCFv9GAG5BCfq3QbZQA4poht++sClzNrJoRXtxO+MS1wQHUsJK0N/oIy5AOLL5SAM6UcaqO9c09Ec9cPyOkXF1WD5ifa5Bs26k46EM9+KcBU9cFYEpwtmXCVIY9FPpH7Oi2m/yic5Y2t9Crv5YYN6m2McyzJM7R81AAsb1gWCNAcZHXZoVBAT8YXkuY2li1hxSvEpdZWMzf852WM3qd45YahVn+5hiYVqnmrOGDwCgFiPhK/vCimqUgSvZLICp8w+v41Se/wnHWG1o5ZT5HaCp4kK5OI+hwQfZ/7v3zExoMxSyELyY4OJjHb4AQXqoFSuxp5szIRsPKPAgQ3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdqNLlq1FNV4G16/pD4sjtiwZvFIZ+iZ6euAfhWgcdw=; b=k0r0Hu3oXkMqdxn0usV20VxAofODCGyHUo3oQUP0GrKK2lSfKPXKNFwv3c55c2a9yfaB7IWs6LxE6pt/LQiJvqMFRAiyuU432LXFjOC/gtAsrRUaVtOcuUAKySA5s/HbXVYKS+gLQdw4REUAHiO7WDNHzd/5FJlEhkLr/WFIy+KwS5M/KiUXmaqJdzSU1Zu1brLeZnqfbGWTQiKPlWsMfr8M5LZfLGhA7SMUENjZWzexxaW83m5Mh837GTn5Wsn8Mq9hQjFaUpe/aJCQJ6NJ3DUrGVBq1vtlFQypTM9SNUew7xHGpFgJJUgdEwK2De+E8P8a4hvQStM2lR+tKK1hQA== Received: from DM5PR16CA0023.namprd16.prod.outlook.com (2603:10b6:3:c0::33) by MW2PR12MB2442.namprd12.prod.outlook.com (2603:10b6:907:4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Thu, 27 Jan 2022 15:40:07 +0000 Received: from DM6NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:3:c0:cafe::c2) by DM5PR16CA0023.outlook.office365.com (2603:10b6:3:c0::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17 via Frontend Transport; Thu, 27 Jan 2022 15:40:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.235) by DM6NAM11FT048.mail.protection.outlook.com (10.13.173.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4930.15 via Frontend Transport; Thu, 27 Jan 2022 15:40:06 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 27 Jan 2022 15:40:05 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Thu, 27 Jan 2022 07:40:05 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9 via Frontend Transport; Thu, 27 Jan 2022 07:40:04 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Subject: [PATCH 05/20] net/mlx5: remove declaration duplications Date: Thu, 27 Jan 2022 17:39:35 +0200 Message-ID: <20220127153950.812953-6-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220127153950.812953-1-michaelba@nvidia.com> References: <20220127153950.812953-1-michaelba@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f6faeff-334c-42cc-d6e1-08d9e1ab4b1b X-MS-TrafficTypeDiagnostic: MW2PR12MB2442:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:400; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0vHeKmAOSITy0VetzSnn4eqMqFqaD+fV76GjarAw0H+T4ERa0zxvofjOdVvHqVqNWhfvG0hkA09vmuUwLBtyeW9tjKrPbLSLsVGE04dj7gy5D5DMksbvE1fc2dS/h7JOcZLS4p7XUoAJ9JCFjCyaSYan6G97ROm300KZnRqjpjI5UzWNYVoQhV0jzIoI5JYLsswIzGJIaFxxNuoeSJb/kPHYmwdAdW1pPRRcSVPcHvhDDER+3pBufx9ER83l7m2HO5qmwB10Q2oO7YvaMY9OtaiKLLk0XkdYnJdgfiLA3T+aMerv0ukBjQ/lCDdotNcouPA0NnrqW4X9bqD4a9VJeY6LpR3U5t7pL7MrwzxGj8l02j82UY//EkFRLV3mCRh8DQ07FOToyeOdhb3vNe0UwBX3mzYk510N7/MBwkikheYA/CQ3yNYnqMqZ4Qg1MwmziNUDy4dUcscR9ByN7h/kZjpY4YBNR4txkM4zLSMPnqVcx7vyv1xdwxe3LTqRZUo0ObIrTRgMCLuJsZtFVAQ45c83d6+J0pR0Eq7U7Um7LLddZzf3csz+n82AGW4p8vP/5nOtd0Ti9+BOWW9hUMY6PcbccMEJ9PWNQ3dT1/gb/WM8r1M8R+uV1SqvsoNmuNxksAabTfTEBa1gGgk1Lemo/yZKOQgJZwvoqHmklC19757MSJb0xeq4ZArkMda3fAGM5x31aMld652r7mf/J1dKENgJxUXnNnOhvoRO0m0IZVOdFudzO6zyOH5fhS93azueNBumt86CQvfQwwMVsp8UQOFN1QehSJj/7mRN1hiKlUE= X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(40470700004)(336012)(82310400004)(8676002)(6666004)(47076005)(7696005)(36860700001)(55016003)(2906002)(5660300002)(107886003)(426003)(4326008)(508600001)(316002)(54906003)(1076003)(6916009)(26005)(8936002)(356005)(81166007)(36756003)(6286002)(70586007)(2616005)(86362001)(83380400001)(40460700003)(186003)(70206006)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 15:40:06.4158 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f6faeff-334c-42cc-d6e1-08d9e1ab4b1b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2442 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In mlx5_ethdev.c file are implemented those 4 functions: - mlx5_dev_infos_get - mlx5_fw_version_get - mlx5_dev_set_mtu - mlx5_hairpin_cap_get In mlx5.h file they are declared twice. First time under mlx5.c file and second time under mlx5_ethdev.c file. This patch removes the redundant declaration. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 737ad6895c..823a943978 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1532,11 +1532,6 @@ void mlx5_set_metadata_mask(struct rte_eth_dev *dev); int mlx5_dev_check_sibling_config(struct mlx5_priv *priv, struct mlx5_dev_config *config, struct rte_device *dpdk_dev); -int mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info); -int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size); -int mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu); -int mlx5_hairpin_cap_get(struct rte_eth_dev *dev, - struct rte_eth_hairpin_cap *cap); bool mlx5_flex_parser_ecpri_exist(struct rte_eth_dev *dev); int mlx5_flex_parser_ecpri_alloc(struct rte_eth_dev *dev); int mlx5_flow_aso_age_mng_init(struct mlx5_dev_ctx_shared *sh); @@ -1556,10 +1551,8 @@ int mlx5_representor_info_get(struct rte_eth_dev *dev, (((repr_id) >> 12) & 3) uint16_t mlx5_representor_id_encode(const struct mlx5_switch_info *info, enum rte_eth_representor_type hpf_type); -int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, - size_t fw_size); -int mlx5_dev_infos_get(struct rte_eth_dev *dev, - struct rte_eth_dev_info *info); +int mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info); +int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size); const uint32_t *mlx5_dev_supported_ptypes_get(struct rte_eth_dev *dev); int mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu); int mlx5_hairpin_cap_get(struct rte_eth_dev *dev,