diff mbox series

devtools: add E-Switch keyword for commit checks

Message ID 20220224092623.26180-1-rasland@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series devtools: add E-Switch keyword for commit checks |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Raslan Darawsheh Feb. 24, 2022, 9:26 a.m. UTC 
  This adds the syntax for E-Switch to have check on how
it suppose to be for commits

Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
 devtools/words-case.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon Feb. 24, 2022, 9:35 a.m. UTC | #1 
24/02/2022 10:26, Raslan Darawsheh:
> This adds the syntax for E-Switch to have check on how
> it suppose to be for commits
[...]
> +E-Switch

It looks Mellanox people use this syntax in Linux kernel as well.
Where does it come from? Is it a Mellanox-only wording?

Intuitively, I would have written it eSwitch generally.
It means "embedded switch", right?
Raslan Darawsheh Feb. 24, 2022, 11:07 a.m. UTC | #2 
++ adding more people here,

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, February 24, 2022 11:36 AM
> To: Raslan Darawsheh <rasland@nvidia.com>
> Cc: dev@dpdk.org; ferruh.yigit@intel.com; Gal Cohen (ProdM)
> <galco@nvidia.com>
> Subject: Re: [PATCH] devtools: add E-Switch keyword for commit checks
> 
> 24/02/2022 10:26, Raslan Darawsheh:
> > This adds the syntax for E-Switch to have check on how it suppose to
> > be for commits
> [...]
> > +E-Switch
> 
> It looks Mellanox people use this syntax in Linux kernel as well.
> Where does it come from? Is it a Mellanox-only wording?
> 
I don't think it's a Mellanox only wording see the following:
https://www.kernel.org/doc/html/latest/networking/devlink/devlink-port.html?#devlink-port
https://www.kernel.org/doc/html/latest/networking/switchdev.html

> Intuitively, I would have written it eSwitch generally.
I would go with E-Switch 
> It means "embedded switch", right?
In kernel,  it's Ethernet Switch device.
https://www.kernel.org/doc/html/latest/networking/switchdev.html
> 
> 

Kindest regards,
Raslan Darawsheh
Ajit Khaparde Feb. 24, 2022, 7:20 p.m. UTC | #3 
On Thu, Feb 24, 2022 at 3:07 AM Raslan Darawsheh <rasland@nvidia.com> wrote:
>
> ++ adding more people here,
>
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Thursday, February 24, 2022 11:36 AM
> > To: Raslan Darawsheh <rasland@nvidia.com>
> > Cc: dev@dpdk.org; ferruh.yigit@intel.com; Gal Cohen (ProdM)
> > <galco@nvidia.com>
> > Subject: Re: [PATCH] devtools: add E-Switch keyword for commit checks
> >
> > 24/02/2022 10:26, Raslan Darawsheh:
> > > This adds the syntax for E-Switch to have check on how it suppose to
> > > be for commits
> > [...]
> > > +E-Switch
> >
> > It looks Mellanox people use this syntax in Linux kernel as well.
> > Where does it come from? Is it a Mellanox-only wording?

I think it was coined around the time when Mellanox submitted the
kernel driver patchset in 2015.
https://lwn.net/Articles/666180/

I think it has become a fairly used term since that time.

> >
> I don't think it's a Mellanox only wording see the following:
> https://www.kernel.org/doc/html/latest/networking/devlink/devlink-port.html?#devlink-port
> https://www.kernel.org/doc/html/latest/networking/switchdev.html
>
> > Intuitively, I would have written it eSwitch generally.
> I would go with E-Switch
> > It means "embedded switch", right?
> In kernel,  it's Ethernet Switch device.
> https://www.kernel.org/doc/html/latest/networking/switchdev.html
> >
> >
>
> Kindest regards,
> Raslan Darawsheh
Thomas Monjalon March 28, 2023, 6:43 p.m. UTC | #4 
24/02/2022 20:20, Ajit Khaparde:
> On Thu, Feb 24, 2022 at 3:07 AM Raslan Darawsheh <rasland@nvidia.com> wrote:
> >
> > ++ adding more people here,
> >
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 24/02/2022 10:26, Raslan Darawsheh:
> > > > This adds the syntax for E-Switch to have check on how it suppose to
> > > > be for commits
> > > [...]
> > > > +E-Switch
> > >
> > > It looks Mellanox people use this syntax in Linux kernel as well.
> > > Where does it come from? Is it a Mellanox-only wording?
> 
> I think it was coined around the time when Mellanox submitted the
> kernel driver patchset in 2015.
> https://lwn.net/Articles/666180/
> 
> I think it has become a fairly used term since that time.
> 
> > >
> > I don't think it's a Mellanox only wording see the following:
> > https://www.kernel.org/doc/html/latest/networking/devlink/devlink-port.html?#devlink-port
> > https://www.kernel.org/doc/html/latest/networking/switchdev.html
> >
> > > Intuitively, I would have written it eSwitch generally.
> > I would go with E-Switch
> > > It means "embedded switch", right?
> > In kernel,  it's Ethernet Switch device.
> > https://www.kernel.org/doc/html/latest/networking/switchdev.html

Forgotten and Applied (very late), thanks.
diff mbox series

Patch

diff --git a/devtools/words-case.txt b/devtools/words-case.txt
index bc33470532..1146706e54 100644
--- a/devtools/words-case.txt
+++ b/devtools/words-case.txt
@@ -15,6 +15,7 @@  DevX
 DMA
 eCPRI
 EEPROM
+E-Switch
 FD
 FDIR
 FEC