diff mbox series

crypto/qat: fix structurally dead code

Message ID 20220228160555.24926-1-arkadiuszx.kusztal@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series crypto/qat: fix structurally dead code |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Arkadiusz Kusztal Feb. 28, 2022, 4:05 p.m. UTC 
  This patch fixes structurally dead code in QAT
asym pmd.

Coverity issue: 376563
Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session")

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/qat/qat_asym.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Akhil Goyal March 4, 2022, 10:07 a.m. UTC | #1 
> This patch fixes structurally dead code in QAT
> asym pmd.
> 
> Coverity issue: 376563
> Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Applied to dpdk-next-crypto
Fan Zhang March 8, 2022, 11:09 a.m. UTC | #2 
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Monday, February 28, 2022 4:06 PM
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: fix structurally dead code
> 
> This patch fixes structurally dead code in QAT
> asym pmd.
> 
> Coverity issue: 376563
> Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  drivers/crypto/qat/qat_asym.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
> index badf018f13..1e4304a3c0 100644
> --- a/drivers/crypto/qat/qat_asym.c
> +++ b/drivers/crypto/qat/qat_asym.c
> @@ -1183,7 +1183,6 @@ session_clear_modinv(struct
> rte_crypto_modinv_xform *modinv)
>  static void
>  session_clear_rsa(struct rte_crypto_rsa_xform *rsa)
>  {
> -	return;
>  	memset(rsa->n.data, 0, rsa->n.length);
>  	rte_free(rsa->n.data);
>  	memset(rsa->e.data, 0, rsa->e.length);
> --
> 2.13.6
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
diff mbox series

Patch

diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
index badf018f13..1e4304a3c0 100644
--- a/drivers/crypto/qat/qat_asym.c
+++ b/drivers/crypto/qat/qat_asym.c
@@ -1183,7 +1183,6 @@  session_clear_modinv(struct rte_crypto_modinv_xform *modinv)
 static void
 session_clear_rsa(struct rte_crypto_rsa_xform *rsa)
 {
-	return;
 	memset(rsa->n.data, 0, rsa->n.length);
 	rte_free(rsa->n.data);
 	memset(rsa->e.data, 0, rsa->e.length);