From patchwork Thu Mar 3 07:00:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 108515 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3F0CA04A2; Thu, 3 Mar 2022 08:00:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 814F240687; Thu, 3 Mar 2022 08:00:52 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6ED4F40141 for ; Thu, 3 Mar 2022 08:00:50 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2233tksj003805 for ; Wed, 2 Mar 2022 23:00:49 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0220; bh=a+sfrcj1Nk36RZQJmxIArYwgIKmYDKvs9ewdBK1sqXo=; b=jxdOwX3ieNze/v6W3OJ28IEg3ANPiAcx2Hg0oi3FPFYpI/PuAjad8e6CbPFb/QnAk/sw 6TtcpRsMk8O0jPxk/LGq1KQCNMPiY50NJrcfEKiom9RzPwH8y1A33AjAfGzjnErpNJJc rCsFNiKADBDWx0LJHrO8NtcK6riOfXRG7US2dAXa3uFW8ausHHdWibzwys4ZO4aDlmB4 Qd8lWziu/f7leHzOk4DBfCtkFpuajNXUKVf8CmbX2gU7rDW6722hsKhbh4tHi+2sJjY5 w24KhvmyE3jA3YpJ0xYhNMr6tkUqR7P5t5QrF+Ca9jpuwwPwirdYq/gk65VquFjPBoy6 dQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ej4vfdka8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 02 Mar 2022 23:00:49 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 2 Mar 2022 23:00:47 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 2 Mar 2022 23:00:47 -0800 Received: from hyd1588t430.marvell.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id 5C5493F7142; Wed, 2 Mar 2022 23:00:45 -0800 (PST) From: Nithin Dabilpuram To: , Nithin Dabilpuram , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao CC: , Subject: [PATCH 1/2] common/cnxk: revert check on bitmap for tm Date: Thu, 3 Mar 2022 12:30:41 +0530 Message-ID: <20220303070042.29075-1-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.8.4 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: 70J7QlzZhrXJ4zP-4l_9-TI18N7d1_Zk X-Proofpoint-GUID: 70J7QlzZhrXJ4zP-4l_9-TI18N7d1_Zk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-03_02,2022-02-26_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Revert change to return error on case where no slab of free resources is found. That error check break's a case where there is a spare schq to be reused that was just allocated for sake of contiguous static TM nodes. Fixes: 14f7e5d4bf2d ("common/cnxk: add missing checks of return values") Cc: gmuthukrishn@marvell.com Signed-off-by: Nithin Dabilpuram Acked-by: Jerin Jacob --- drivers/common/cnxk/roc_nix_tm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c index 7a17780..5b70c7b 100644 --- a/drivers/common/cnxk/roc_nix_tm.c +++ b/drivers/common/cnxk/roc_nix_tm.c @@ -1042,10 +1042,8 @@ nix_tm_assign_hw_id(struct nix *nix, struct nix_tm_node *parent, return -EFAULT; } - if (!slab) { - if (!plt_bitmap_scan(bmp, &pos, &slab)) - return -ENOENT; - } + if (!slab) + plt_bitmap_scan(bmp, &pos, &slab); if (child->priority == parent->rr_prio && spare_schq != -1) { /* Use spare schq first if present */