diff mbox series

[v2] graph: remove the useless duplicate name check

Message ID 20220307074125.1005637-1-haiyue.wang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] graph: remove the useless duplicate name check |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed

Commit Message

Wang, Haiyue March 7, 2022, 7:41 a.m. UTC 
  The node clone API parameter 'name' is the new node's postfix name, not
the final node name, so it makes no sense to check it. And the new name
will be checked duplicate when calling API '__rte_node_register'.

And update the test case to call clone API twice to check the real name
duplicate.

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
v2: update the test case.
---
 app/test/test_graph.c | 10 +++++++++-
 lib/graph/node.c      |  4 ----
 2 files changed, 9 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/app/test/test_graph.c b/app/test/test_graph.c
index 35e1a95b89..692360eccd 100644
--- a/app/test/test_graph.c
+++ b/app/test/test_graph.c
@@ -545,13 +545,21 @@  test_node_clone(void)
 {
 	test_main_t *tm = &test_main;
 	uint32_t node_id, dummy_id;
+	uint32_t dummy_id_clone;
 	int i;
 
 	node_id = rte_node_from_name("test_node00");
 	tm->test_node[0].idx = node_id;
 
+#define TEST_NODE_CLONE_NAME "test_node00"
+	dummy_id_clone = rte_node_clone(node_id, TEST_NODE_CLONE_NAME);
+	if (rte_node_is_invalid(dummy_id_clone)) {
+		printf("Got invalid id when clone, Expecting fail\n");
+		return -1;
+	}
+
 	/* Clone with same name, should fail */
-	dummy_id = rte_node_clone(node_id, "test_node00");
+	dummy_id = rte_node_clone(node_id, TEST_NODE_CLONE_NAME);
 	if (!rte_node_is_invalid(dummy_id)) {
 		printf("Got valid id when clone with same name, Expecting fail\n");
 		return -1;
diff --git a/lib/graph/node.c b/lib/graph/node.c
index 79230035a2..ae6eadb260 100644
--- a/lib/graph/node.c
+++ b/lib/graph/node.c
@@ -150,10 +150,6 @@  node_clone(struct node *node, const char *name)
 		goto fail;
 	}
 
-	/* Check for duplicate name */
-	if (node_has_duplicate_entry(name))
-		goto fail;
-
 	reg = calloc(1, sizeof(*reg) + (sizeof(char *) * node->nb_edges));
 	if (reg == NULL) {
 		rte_errno = ENOMEM;