From patchwork Tue Mar 8 21:18:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 108610 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B15DBA0093; Tue, 8 Mar 2022 22:19:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CE7C40395; Tue, 8 Mar 2022 22:19:08 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id AAE8F40141 for ; Tue, 8 Mar 2022 22:19:07 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3C9C45C0189; Tue, 8 Mar 2022 16:19:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 08 Mar 2022 16:19:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm1; bh=5XHk6LtG8VHAQiscNyVuZ9HCbrCOLvrR4lOZqdqx4ME=; b=O7Ipj tFQsoWq+ZwYmBv/hYayCC3MLf7P1dcT1bLBma4JtMqV8XAOr+bWASgSKtO+jnTa2 eGUsTWkVSnQ79X46/Qwag97USA46Slf0rfUCZb37NcD5GRDcOlcI2PX7wRbJve6k 5cMrbIUUkh1zbozvRhktPnrTdIVlj6QXsUrD3kyVZqTFYX3BPIaUalnG2i1TQSJb gCk7UBaPR470y+MZbxGvCC5iFzrPOzvDMkTOYFp5xU30moCi1lDPR0nUDJPJSZi3 VdINJqpU2Yi3kW8ryTFzbF4ttljEBL3qvxETJzItUPRC2ikBbhEn80+89nCKjyfj nPe+Z+oon/NB8uwkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=5XHk6LtG8VHAQiscNyVuZ9HCbrCOL vrR4lOZqdqx4ME=; b=RSbUnehBBDQsqIoMcQe5c/gMQABhd8JdlGhbk4PT3jxhw +wiV597HPeWwD44cvVTuKE0Zna+NQ5hXTWuQ50n6Kq6g1/mO3Zw8Z6xtkStXNQqO fmBNSNBfnuaJ4mrlMkXWQ4veWHrq5KQP843lmW/kEEDe8lNG07c5vfMT82vVZMet Zw3GQJw4H6Kk/i2t09Fl41FR8O7E8Fqd4nOzbezF6oC+pJLgXUyHTVmbTML5mswy XDDqoBlJMVBtWhREK9PCtLI45MyYdyCFgVkM4750XHiiupgykpf4D54k2/kKi6Af XMzGZ00H6X9/MkHCVO8BrmoFtR8btybvk5qoh0R8g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduiedgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedvledvudehvdduudevuedvveehgeduleegiefgjeehudehtddtgedu ffejiefhgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Mar 2022 16:19:06 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: Usama Arif Subject: [PATCH] devtools: fix symbols check Date: Tue, 8 Mar 2022 22:18:59 +0100 Message-Id: <20220308211859.3677476-1-thomas@monjalon.net> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In some environments, the check of local symbols catch-all was failing. Note: this script is called during the build. The reason is that grep returns an error if nothing is found. The option -e of the shell script makes this error fatal. It is not always fatal because the grep is in a command substitution. Fixes: b403498e1422 ("build: hide local symbols in shared libraries") Reported-by: Usama Arif Signed-off-by: Thomas Monjalon --- devtools/check-symbol-maps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index 8266fdf9ea..32e1fa5c8f 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then ret=1 fi -local_miss_maps=$(grep -L 'local: \*;' $@) +local_miss_maps=$(grep -L 'local: \*;' $@ || true) if [ -n "$local_miss_maps" ] ; then echo "Found maps without local catch-all:" echo "$local_miss_maps"