diff mbox series

net/bnxt: fix ulp parser to ignore segment offset

Message ID 20220314212334.93753-1-ajit.khaparde@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ajit Khaparde
Headers
Series net/bnxt: fix ulp parser to ignore segment offset |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-broadcom-Functional fail Functional Testing issues

Commit Message

Ajit Khaparde March 14, 2022, 9:23 p.m. UTC 
  From: Shuanglin Wang <shuanglin.wang@broadcom.com>

Fix ulp parser to ignore segment_offset of IPV4 header.
Currently the IPV4 handler is assuming default setting,
which causes the flow table to be updated incorrectly.

Fixes: 741172be52de ("net/bnxt: refactor flow parser in ULP")
Cc: stable@dpdk.org

Signed-off-by: Shuanglin Wang <shuanglin.wang@broadcom.com>
Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ajit Khaparde March 29, 2022, 11:22 p.m. UTC | #1 
On Mon, Mar 14, 2022 at 2:23 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> From: Shuanglin Wang <shuanglin.wang@broadcom.com>
>
> Fix ulp parser to ignore segment_offset of IPV4 header.
> Currently the IPV4 handler is assuming default setting,
> which causes the flow table to be updated incorrectly.
>
> Fixes: 741172be52de ("net/bnxt: refactor flow parser in ULP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shuanglin Wang <shuanglin.wang@broadcom.com>
> Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Patch applied dpdk-next-net-brcm.

> ---
>  drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
> index f4274dd634..9edf3e8799 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
> @@ -1096,7 +1096,7 @@ ulp_rte_ipv4_hdr_handler(const struct rte_flow_item *item,
>                                                    hdr.fragment_offset),
>                               ulp_deference_struct(ipv4_mask,
>                                                    hdr.fragment_offset),
> -                             ULP_PRSR_ACT_DEFAULT);
> +                             ULP_PRSR_ACT_MASK_IGNORE);
>
>         size = sizeof(((struct rte_flow_item_ipv4 *)NULL)->hdr.time_to_live);
>         ulp_rte_prsr_fld_mask(params, &idx, size,
> --
> 2.32.0 (Apple Git-132)
>
diff mbox series

Patch

diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
index f4274dd634..9edf3e8799 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
@@ -1096,7 +1096,7 @@  ulp_rte_ipv4_hdr_handler(const struct rte_flow_item *item,
 						   hdr.fragment_offset),
 			      ulp_deference_struct(ipv4_mask,
 						   hdr.fragment_offset),
-			      ULP_PRSR_ACT_DEFAULT);
+			      ULP_PRSR_ACT_MASK_IGNORE);
 
 	size = sizeof(((struct rte_flow_item_ipv4 *)NULL)->hdr.time_to_live);
 	ulp_rte_prsr_fld_mask(params, &idx, size,