[1/1] ethdev: add packet expiry event subtype

Message ID 20220317075734.3169650-1-vattunuru@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [1/1] ethdev: add packet expiry event subtype |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-broadcom-Functional fail Functional Testing issues

Commit Message

Vamsi Krishna Attunuru March 17, 2022, 7:57 a.m. UTC
  Patch adds a new event subtype for notifying expiry
event upon soft packet limit expiry.

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
 lib/ethdev/rte_ethdev.h | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Vamsi Krishna Attunuru March 23, 2022, 3:04 a.m. UTC | #1
Ping..

> -----Original Message-----
> From: Vamsi Attunuru <vattunuru@marvell.com>
> Sent: Thursday, March 17, 2022 1:28 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
> Dabilpuram <ndabilpuram@marvell.com>; Akhil Goyal
> <gakhil@marvell.com>; Vamsi Krishna Attunuru <vattunuru@marvell.com>
> Subject: [PATCH 1/1] ethdev: add packet expiry event subtype
> 
> Patch adds a new event subtype for notifying expiry event upon soft packet
> limit expiry.
> 
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> ---
>  lib/ethdev/rte_ethdev.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index
> 04cff8ee10..07d1f02bae 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -3828,6 +3828,8 @@ enum rte_eth_event_ipsec_subtype {
>  	RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
>  	/** Soft byte expiry of SA */
>  	RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
> +	/** Soft packet expiry of SA */
> +	RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY,
>  	/** Max value of this enum */
>  	RTE_ETH_EVENT_IPSEC_MAX
>  };
> @@ -3849,6 +3851,7 @@ struct rte_eth_event_ipsec_desc {
>  	 * - @ref RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW
>  	 * - @ref RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY
>  	 * - @ref RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY
> +	 * - @ref RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY
>  	 *
>  	 * @see struct rte_security_session_conf
>  	 *
> --
> 2.25.1
  
Ferruh Yigit April 20, 2022, 6:16 p.m. UTC | #2
On 3/23/2022 3:04 AM, Vamsi Krishna Attunuru wrote:
> Ping..
> 
>> -----Original Message-----
>> From: Vamsi Attunuru <vattunuru@marvell.com>
>> Sent: Thursday, March 17, 2022 1:28 PM
>> To: dev@dpdk.org
>> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
>> Dabilpuram <ndabilpuram@marvell.com>; Akhil Goyal
>> <gakhil@marvell.com>; Vamsi Krishna Attunuru <vattunuru@marvell.com>
>> Subject: [PATCH 1/1] ethdev: add packet expiry event subtype
>>
>> Patch adds a new event subtype for notifying expiry event upon soft packet
>> limit expiry.
>>

cc'ed more people

Is there any user of this event to provide more context? Or to justify 
why it is needed?

>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
>> ---
>>   lib/ethdev/rte_ethdev.h | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index
>> 04cff8ee10..07d1f02bae 100644
>> --- a/lib/ethdev/rte_ethdev.h
>> +++ b/lib/ethdev/rte_ethdev.h
>> @@ -3828,6 +3828,8 @@ enum rte_eth_event_ipsec_subtype {
>>   	RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
>>   	/** Soft byte expiry of SA */
>>   	RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
>> +	/** Soft packet expiry of SA */
>> +	RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY,
>>   	/** Max value of this enum */
>>   	RTE_ETH_EVENT_IPSEC_MAX
>>   };
>> @@ -3849,6 +3851,7 @@ struct rte_eth_event_ipsec_desc {
>>   	 * - @ref RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW
>>   	 * - @ref RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY
>>   	 * - @ref RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY
>> +	 * - @ref RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY
>>   	 *
>>   	 * @see struct rte_security_session_conf
>>   	 *
>> --
>> 2.25.1
>
  
Vamsi Krishna Attunuru April 21, 2022, 6:45 a.m. UTC | #3
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@xilinx.com>
> Sent: Wednesday, April 20, 2022 11:46 PM
> To: Vamsi Krishna Attunuru <vattunuru@marvell.com>; dev@dpdk.org;
> Anoob Joseph <anoobj@marvell.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
> Dabilpuram <ndabilpuram@marvell.com>; Akhil Goyal
> <gakhil@marvell.com>
> Subject: [EXT] Re: [PATCH 1/1] ethdev: add packet expiry event subtype
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 3/23/2022 3:04 AM, Vamsi Krishna Attunuru wrote:
> > Ping..
> >
> >> -----Original Message-----
> >> From: Vamsi Attunuru <vattunuru@marvell.com>
> >> Sent: Thursday, March 17, 2022 1:28 PM
> >> To: dev@dpdk.org
> >> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
> >> Dabilpuram <ndabilpuram@marvell.com>; Akhil Goyal
> >> <gakhil@marvell.com>; Vamsi Krishna Attunuru
> <vattunuru@marvell.com>
> >> Subject: [PATCH 1/1] ethdev: add packet expiry event subtype
> >>
> >> Patch adds a new event subtype for notifying expiry event upon soft
> >> packet limit expiry.
> >>
> 
> cc'ed more people
> 
> Is there any user of this event to provide more context? Or to justify why it is
> needed?

Hi Ferruh,
This patch is superseded by
http://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/
Please check the comment section for the context and requirement details.

> 
> >> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> >> ---
> >>   lib/ethdev/rte_ethdev.h | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index
> >> 04cff8ee10..07d1f02bae 100644
> >> --- a/lib/ethdev/rte_ethdev.h
> >> +++ b/lib/ethdev/rte_ethdev.h
> >> @@ -3828,6 +3828,8 @@ enum rte_eth_event_ipsec_subtype {
> >>   	RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
> >>   	/** Soft byte expiry of SA */
> >>   	RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
> >> +	/** Soft packet expiry of SA */
> >> +	RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY,
> >>   	/** Max value of this enum */
> >>   	RTE_ETH_EVENT_IPSEC_MAX
> >>   };
> >> @@ -3849,6 +3851,7 @@ struct rte_eth_event_ipsec_desc {
> >>   	 * - @ref RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW
> >>   	 * - @ref RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY
> >>   	 * - @ref RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY
> >> +	 * - @ref RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY
> >>   	 *
> >>   	 * @see struct rte_security_session_conf
> >>   	 *
> >> --
> >> 2.25.1
> >
  

Patch

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 04cff8ee10..07d1f02bae 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3828,6 +3828,8 @@  enum rte_eth_event_ipsec_subtype {
 	RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
 	/** Soft byte expiry of SA */
 	RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
+	/** Soft packet expiry of SA */
+	RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY,
 	/** Max value of this enum */
 	RTE_ETH_EVENT_IPSEC_MAX
 };
@@ -3849,6 +3851,7 @@  struct rte_eth_event_ipsec_desc {
 	 * - @ref RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW
 	 * - @ref RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY
 	 * - @ref RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY
+	 * - @ref RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY
 	 *
 	 * @see struct rte_security_session_conf
 	 *