From patchwork Tue Mar 29 03:06:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenjun Wu X-Patchwork-Id: 108974 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16869A0505; Tue, 29 Mar 2022 05:30:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01DC6428DE; Tue, 29 Mar 2022 05:29:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id BF6ED428CF for ; Tue, 29 Mar 2022 05:29:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648524573; x=1680060573; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=JPsIHv7ygxpt8JTSswp+B1mjSfoLbNDdXw6UBOp//ww=; b=Ie6A1++Jix+f+bPNKc6wT0EV+ji9mnJ5kGEXzZKkILHqPx5Il2ciOQaD Ig/6v4+XvfuiSuec6F43Ejby61tfNpMl1JW0y4asiaE3uXFjhZu0piw95 8xiHQ/WSDY9XMYzXGr4xB3WtuHzZf+8QFTx/oDtS+mvpQEPxNA3cqOUKj cuoUe7UgFqDdvRP9ZVZlSMZR6GoMCLfKcZTW+k4vf5a2kMpLYqoXpGO2o 4AHGoJBUGa9+88CtLx2mZqaKfTVcQzpneX3gW7A+Jknd7Z3EcvmH4Hdqv QIj5iRjMdE+LFEdbsK6oUxixmbrgT/x/k2f0akS25TbVjcxLVBV3y/hd4 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="259122372" X-IronPort-AV: E=Sophos;i="5.90,219,1643702400"; d="scan'208";a="259122372" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 20:29:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,219,1643702400"; d="scan'208";a="521266553" Received: from npg-wuwenjun-dpdk-01.sh.intel.com ([10.67.110.181]) by orsmga006.jf.intel.com with ESMTP; 28 Mar 2022 20:29:32 -0700 From: Wenjun Wu To: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com Subject: [PATCH v3 9/9] net/ice: add warning log for unsupported configuration Date: Tue, 29 Mar 2022 11:06:57 +0800 Message-Id: <20220329030657.1121305-10-wenjun1.wu@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220329030657.1121305-1-wenjun1.wu@intel.com> References: <20220329020308.1099471-1-wenjun1.wu@intel.com> <20220329030657.1121305-1-wenjun1.wu@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Priority configuration is enabled in level 3 and level 4. Weight configuration is enabled in level 4. This patch adds warning log for unsupported priority and weight configuration. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 8a71bfa599..8ae0b3930c 100644 --- a/drivers/net/ice/ice_tm.c +++ b/drivers/net/ice/ice_tm.c @@ -531,6 +531,15 @@ ice_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, rte_calloc(NULL, 256, (sizeof(struct ice_tm_node *)), 0); tm_node->parent->children[tm_node->parent->reference_count] = tm_node; + if (tm_node->priority != 0 && (level_id != ICE_TM_NODE_TYPE_QUEUE || + level_id != ICE_TM_NODE_TYPE_QGROUP)) + PMD_DRV_LOG(WARNING, "priority != 0 not supported in level %d", + level_id); + + if (tm_node->weight != 1 && level_id != ICE_TM_NODE_TYPE_QUEUE) + PMD_DRV_LOG(WARNING, "weight != 1 not supported in level %d", + level_id); + rte_memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == ICE_TM_NODE_TYPE_PORT) {