From patchwork Wed Apr 27 14:58:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalesh A P X-Patchwork-Id: 110356 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C03C9A034C; Wed, 27 Apr 2022 16:59:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7C5B4280F; Wed, 27 Apr 2022 16:58:37 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (lpdvsmtp11.broadcom.com [192.19.166.231]) by mails.dpdk.org (Postfix) with ESMTP id 9BA6A427FB for ; Wed, 27 Apr 2022 16:58:35 +0200 (CEST) Received: from dhcp-10-123-153-22.dhcp.broadcom.net (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 2E448C0000E8; Wed, 27 Apr 2022 07:58:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 2E448C0000E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1651071515; bh=bSjH4SqaGuaPt6wn6CrnzIF8hzj2c9WGUVqGtjNtnCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LuaGXbfJd8JXyU49V4T6N6iOoLDYwNhrEd9HT9PFWEJ8WzyBG5RTR9rN0KvfCElCm w3q0ysnK0BIIIB8k0JlMzGg8ZEJiu3VLhWRNGyAZt4pth76cNFDWxZJCtGpsiWr3nR LJ+HA2lLtcW6qkPP52MYpRg+KdJxna6KwrOjf52A= From: Kalesh A P To: dev@dpdk.org Cc: ajit.khaparde@broadcom.com Subject: [PATCH 04/17] net/bnxt: fix Rxq configure Date: Wed, 27 Apr 2022 20:28:08 +0530 Message-Id: <20220427145821.5987-5-kalesh-anakkur.purayil@broadcom.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20220427145821.5987-1-kalesh-anakkur.purayil@broadcom.com> References: <20220427145821.5987-1-kalesh-anakkur.purayil@broadcom.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP We are currently not handling RX/RSS modes correctly. After launching testpmd with multiple RXQs, if the user tries to set the number of RXQs to 1, driver is not updating the "hash_type" and "hash_mode" values of the VNICs. As a result, driver issues bnxt_vnic_rss_configure() unnecessarily and the FW command fails. Fixed bnxt_mq_rx_configure() to update VNIC RSS fields unconditionally. Fixes: 4191bc8f79a8 ("net/bnxt: handle multi queue mode properly") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxq.c | 37 ++++++++++++++----------------------- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 3c2283b..8977138 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -65,6 +65,7 @@ void bnxt_free_rxq_stats(struct bnxt_rx_queue *rxq) int bnxt_mq_rx_configure(struct bnxt *bp) { struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf; + struct rte_eth_rss_conf *rss = &bp->rss_conf; const struct rte_eth_vmdq_rx_conf *conf = &dev_conf->rx_adv_conf.vmdq_rx_conf; unsigned int i, j, nb_q_per_grp = 1, ring_idx = 0; @@ -172,29 +173,19 @@ int bnxt_mq_rx_configure(struct bnxt *bp) bp->rx_num_qs_per_vnic = nb_q_per_grp; - if (dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) { - struct rte_eth_rss_conf *rss = &bp->rss_conf; - - for (i = 0; i < bp->nr_vnics; i++) { - uint32_t lvl = RTE_ETH_RSS_LEVEL(rss->rss_hf); - - vnic = &bp->vnic_info[i]; - vnic->hash_type = - bnxt_rte_to_hwrm_hash_types(rss->rss_hf); - vnic->hash_mode = - bnxt_rte_to_hwrm_hash_level(bp, - rss->rss_hf, - lvl); - - /* - * Use the supplied key if the key length is - * acceptable and the rss_key is not NULL - */ - if (rss->rss_key && - rss->rss_key_len <= HW_HASH_KEY_SIZE) - memcpy(vnic->rss_hash_key, - rss->rss_key, rss->rss_key_len); - } + for (i = 0; i < bp->nr_vnics; i++) { + uint32_t lvl = RTE_ETH_RSS_LEVEL(rss->rss_hf); + + vnic = &bp->vnic_info[i]; + vnic->hash_type = bnxt_rte_to_hwrm_hash_types(rss->rss_hf); + vnic->hash_mode = bnxt_rte_to_hwrm_hash_level(bp, rss->rss_hf, lvl); + + /* + * Use the supplied key if the key length is + * acceptable and the rss_key is not NULL + */ + if (rss->rss_key && rss->rss_key_len <= HW_HASH_KEY_SIZE) + memcpy(vnic->rss_hash_key, rss->rss_key, rss->rss_key_len); } return rc;