Message ID | 20220503042257.15626-7-pagupta@vmware.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Andrew Rybchenko |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DABC1A0093; Tue, 3 May 2022 06:23:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4365E42846; Tue, 3 May 2022 06:23:19 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2087.outbound.protection.outlook.com [40.107.244.87]) by mails.dpdk.org (Postfix) with ESMTP id 67A0142839 for <dev@dpdk.org>; Tue, 3 May 2022 06:23:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mjHYf6IU0/2nVPY0l1+5aZKjsOXph6FLbVBBC3t5qjo55BRi4FFeTZlnnEBzl55QUZiO+NmkxKYIfOggZQtzfsTuy+Pq+ZtXO/djmV6SZ6ABYSTywNsIfYbYD6yNFgzSdWkq2rgzwQBltCoiQEJC4Zyn8z2uXM1T/zRZmqB1DqVqT6t5y81EVcsDYqSSLLvtwBgiCbNnG6sAmW78SX6o2uyjfN/XeaCbimzHb4+/BQ3OPZnqBXujcfqqHDiZV74KrWZtjvqqXhD+dEp76SqWYJOybGwEv5Y2IIm/e+cED6gO5MNCNh6sWgUNh9tULuEhXAhwNGWpjC7lNCtJhebMcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=peqkZvFDRUf6IhQwSN6AmOVE3FvlYcTHJsgf8klSyLg=; b=j8jIZbeGUd+1YC7KiG8z0i3cIt0JsPf/9I4k8rJTfHF0UAYmXRhjo5c5dZbp6fG8RDmJFwaZibeCQ8S2NfXgakw7CBq5uwQELN6pdSZ766Rm/xuKNRjpNlZAvuNjsEMRx/9v01FZUpn6tkIv4MQjN0vTl52JxHulbygRW7z3JXT2ExytrdZHVTuAuNMqWHUP6us6d9VwMr+gN4Tk9ZLqqPQ7kSOKJSfxg4DJ7WZYoPaqKmcLYYph6aVT9Bgq129X7Q5jXmBcSp8NdqNz1d/UMtXmqyDs73LzKzqJphlL2Q9U1Lk70x6/+Ftu927stkWv9C461Tnzr99MnOs4jt7PBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=peqkZvFDRUf6IhQwSN6AmOVE3FvlYcTHJsgf8klSyLg=; b=fWkrJW5jrAxoK6yrnAXJq3EzHQRbxn1uBn3GTDcyMekx3U7IjJoxNyJ1WsntnNf4APa5vpzPvjXO6okMkwaEsS1oZ6F0aeqiNZvF4Q4w+NBiO5dZpYkmujqdpz+1RMDe3hl/QUD0dkr6TMfhhTaG3Wz1ruR5GYrm3koNqL4qSUY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; Received: from BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13) by BL0PR05MB5523.namprd05.prod.outlook.com (2603:10b6:208:68::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 04:23:14 +0000 Received: from BYAPR05MB5624.namprd05.prod.outlook.com ([fe80::5161:a7c5:8c7d:f3b2]) by BYAPR05MB5624.namprd05.prod.outlook.com ([fe80::5161:a7c5:8c7d:f3b2%7]) with mapi id 15.20.5206.024; Tue, 3 May 2022 04:23:14 +0000 From: Pankaj Gupta <pagupta@vmware.com> To: jbehrens@vmware.com, yongwang@vmware.com Cc: dev@dpdk.org, pagupta@vmware.com Subject: [PATCH 6/8] vmxnet3: set reta size Date: Tue, 3 May 2022 00:22:55 -0400 Message-Id: <20220503042257.15626-7-pagupta@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220503042257.15626-1-pagupta@vmware.com> References: <20220503042257.15626-1-pagupta@vmware.com> Content-Type: text/plain X-ClientProxiedBy: SJ0PR03CA0059.namprd03.prod.outlook.com (2603:10b6:a03:33e::34) To BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b8ea3c08-1a9d-4044-d5d0-08da2cbca2c6 X-MS-TrafficTypeDiagnostic: BL0PR05MB5523:EE_ X-Microsoft-Antispam-PRVS: <BL0PR05MB5523050274BFBFE1565B1238C9C09@BL0PR05MB5523.namprd05.prod.outlook.com> X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pxEcD9B6/h9HsM3rXdWFhoSKJvwAOxX8Jo9g5naivtXx4OHJ3sJdgBSSPdsazQc+Ztf9IbPwjx50G5YnzZMmZaZfeLNB3Q4lzR3Eska9/lMkqFUYfs1wC4WaS3TgZMaIe7yBf9Xe8Gy+hNjxtHvRORnpFdBshHI2P7NenETGkEv8kp7+6fUrFtEIxjM+2yKRZ7f/tBi7QsaF1V19OaS5TJYWSKnA++IXU/PmvSYFeRScS/w25+N7xf1zsr9AYvXdBYRT7fir5qvK4kelZihbAC1G4Accq3Ihh/gCAFsWAevAgw1PAvxC8ihRaiIgTlEIu5gOpC9vSdojty9BErwGEyfezrMlR+XRG6Xu53J1JmUrGJo0mfXVPG4Qcdaec+bKi4OF9xllk0Th82R0tZdTHg69KgN5t/dVqRFBYF1F2gPGFfFUDOjCA6GkWkFdLitFIxDiTVGLFnLRIYbSZcJylmDwW34++x6G1/II19XaPaFaY6vvhKCCS3Yko45QM9Buac00VRkvvhVkdU3d3h5sZImkEtSDlG2dOILeo8g21vWQaj9Xo3dwHir2882E1jDakTPpxqRbqbE5fDawJVPjZ3KGLfoiaI/R3X4KiToIZdRHLY8cemyrpmui21hI0fnpxQYtlMXaaBedyINab6J5O6j4cGbf0rqouKG+OA73IGUUEayvx07tiZ9lpz0Vn8MW5fXkULTOPo/dQWH7zD/00Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR05MB5624.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6636002)(38350700002)(26005)(107886003)(83380400001)(36756003)(1076003)(8676002)(6506007)(86362001)(2616005)(66476007)(66946007)(66556008)(38100700002)(4326008)(6486002)(508600001)(186003)(316002)(2906002)(8936002)(6666004)(6512007)(52116002)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dXtXr0EQp0l9SPojmIPI6bcxJ4z9C4kAeE1es57aYLI4Eed8Ca4bOtFgkSgJsMlEkr8wLPMsjvd2PtEQhowUKdr0YG8PVe0K0vIpqvInnlHf+wMvf1jcycq1KEYE6MvN/r12SEZE/i3IwGzkVhKgfkBxHJ/x92eNEotRdOjdqKGNUuYzy7fce3wm+otnZPS7icKK60P2JDANe52rpzy9Yk0axljBi83SBVaAVcsQdsFyolOcsjFTh6aJ4NXuC+ckIGb9AQTceSL690tuRWs43DynzhvsWcxCFdIuGgfB1fIvarEzTS3YnOiu3TznFHi8sorC9kTCscqbS51x5MrXCCRaO00CalSTJzW3KQrYVaKX6WqXQS7SJM4KQ0Pne2SAC4lvROhKL24LHAQ2+U3eo/r4g5QcJDCr1zHuIniHC1IGQuN4Y8Gyg05eJZAVQ+dg1OR2+Uf/Upa4VCqlXQauh2cSdpERJg55bk3RaOI5O1+iBt7jYN0p25cbzGeub1pzXT4Kvjd2IvDg8Y2Oq/TgT/ZOcRrMe93wBrIjz1+beGlSzKhUQTE4Y8tNhdCjAY5KsM9wq2uQ44tioIf4fI36CioeLvWPC2shCLsZviareBg3fFqksYGzJX67iqI1V7toiSflkennjMJ63Cmoqfi9mKtguFZYZsu4UIIbY+LDGcgjrRbUOoo9QKJWgtg/U4NSsqyv/99M6QA6QKyKVHLvMp+9XeaN1Ml87KAkGrfuH32qe62SFPGeEKuXNJhuC+jYvcURSnDMyGC8rBk0mP2+5tjbQHIwuUNse0Fqrh0m1voUoG+5MfCW73mE9F64bjFvT0fNcD2DKmT+Xmiv33zVflEgAKCQaFeLGJAdxk1bQR2+iYM7uwJ/+3ZO4eKeJsvXTWuw6NcC2ahzX5ZV9/TpCiXRA/gStF8Z6XpgXMgA5bv4n3tobBO+rBMPPbemb/20AnZJ8XUBZJ4V3IgrVN8hJV68oj9OCuBXyCjrswFKTrPsUH+fpRRVGfHF059AesUWyQwDqO65+nqfi/Dq4dzb7LHF5W6sLrMgcgjSEZC+AX9K6QGnLsv2aesiwc4+Pmd2Gx2ZjFEGjfW6DPDRbyE7A9c/6elyrxzCdrmNWHNf3iTLCjHQkuPKp5nWi6Vl+QeS46H2TQTQijflt5bYJ28rhMDqQ+oFZjiiWHO90w6HOdrr/MyaRKMIkbNi0sdbXKZWd/CRwd0G3NsRhEkoJvw2jP53GyckRSJApY9KolguD5Hhl90ISDQrNVYgiDOMBbGUYmyms5a4aw1QNeZq5J27wbE1USz0yUsTb2vwHH46XmV4sjeYnO2WuXY8QPOwhKclzSKnbCZR6oPw662Fn+kAn/FMX2UNkh3P4ClR6oVGXAomg95/d/X9YwaQrYZNGlbiu6gx2rWa4KfUP0sY501+XT11SPTY5Jco6YBwJ9we6V8xuySQpbnOybgFX/D1nzVGWpwLvvRaf8/889JNZwABGyeI/2pO7oDgMJBKrFoEF0JY1nChsZtXLoTFMKp19aILSHf67PyGomWspQHn6rSAzWNy2xnHIe1ZRZT+koQ+9ikl8A388FEKoyksKY9lrXGjumVIiWbIxkQPQ6rqdFkV5ifJU6O3pJgcNW7iUpS7Hg2gsqesQxGr/XqFPlhxJlKB+G3s6XuwTS8okOySWDZmUF25vZvPJUBvHErrV22XciFpH7bDCJsBRBswlxP1nsCpDUWd2YNXXdgBR2MQbjgFSA== X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8ea3c08-1a9d-4044-d5d0-08da2cbca2c6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB5624.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 04:23:12.4478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HfiH7CSMeKx1nDBTut+a7ceMLVhS4DjRXumzbZL2/J3Gu8yqQKQoVEnmhIZPAvTjOZWHae910VzivRPNIW1GeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB5523 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
vmxnet3 version V5 and V6
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | warning | coding style issues |
Commit Message
Pankaj Gupta
May 3, 2022, 4:22 a.m. UTC
Currently the driver assumes that the size of the reta table is
four times the number of rx queues at multiple places. However,
it sets it to four times the maximum number of queues (4 * 32 = 128)
when it first initializes the device. Change the other uses to use
the stored value, not the assumed default.
Signed-off-by: Pankaj Gupta <pagupta@vmware.com>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Comments
Consider: net/vmxnet3: advertise RETA size in device info On 5/3/22 07:22, Pankaj Gupta wrote: > Currently the driver assumes that the size of the reta table is reta -> RETA (see devtools/words-case.txt) > four times the number of rx queues at multiple places. However, rx -> Rx > it sets it to four times the maximum number of queues (4 * 32 = 128) > when it first initializes the device. Change the other uses to use > the stored value, not the assumed default. > > Signed-off-by: Pankaj Gupta <pagupta@vmware.com> > --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index f65b3d3113..9955f121f6 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -1483,7 +1483,12 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev, > dev_info->rx_queue_offload_capa = 0; > dev_info->tx_offload_capa = VMXNET3_TX_OFFLOAD_CAP; > dev_info->tx_queue_offload_capa = 0; > - > + if (hw->rss_conf) { Compare with NULL explicitly as DPDK coding style says. > + dev_info->reta_size = hw->rss_conf->indTableSize; > + } else { > + /* RSS not configured */ > + dev_info->reta_size = 0; > + } > return 0; > } >
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index f65b3d3113..9955f121f6 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1483,7 +1483,12 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev, dev_info->rx_queue_offload_capa = 0; dev_info->tx_offload_capa = VMXNET3_TX_OFFLOAD_CAP; dev_info->tx_queue_offload_capa = 0; - + if (hw->rss_conf) { + dev_info->reta_size = hw->rss_conf->indTableSize; + } else { + /* RSS not configured */ + dev_info->reta_size = 0; + } return 0; }