From patchwork Thu May 5 17:29:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Kardach X-Patchwork-Id: 110741 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BB88A00C2; Thu, 5 May 2022 19:30:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BA4942836; Thu, 5 May 2022 19:30:30 +0200 (CEST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id 15D0542824 for ; Thu, 5 May 2022 19:30:28 +0200 (CEST) Received: by mail-lf1-f44.google.com with SMTP id h29so8639066lfj.2 for ; Thu, 05 May 2022 10:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nYL6pNCthM4VSQpF6G0XvpFSHAYdyD8kms9UXfuP2kw=; b=lCH/UOx16E2eTQlC3CkGrqtu3vOJthIG5C8G8qPqAo+KwR31SaxBBsqKCATSkomLax BMNXL79zrpDAEBygy5gYWadF6RLqpsQA2GBXHMRmc1xJ+qH4q1wEXXhlTS6BBMwdknS0 Xz1FeQZ0Y5NfC8a7+UEgwb0Z9KjTeHT9qP035l9FdzjLC/dPGMeaK1SkVzfRamZ1xFBx xjqL4t7EGQDz8OtbD+Z9k8pMOsNYKXFMIuTw3GBSu2nHPLhiVBrcujJIELQfZ31wTmHI bR1z2okO7jG/zgnFLtACNEyBX//+MCJifnHWmjtYAlo6EGLQqDvcgYi3SE5TJJtVY/Jp sA6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nYL6pNCthM4VSQpF6G0XvpFSHAYdyD8kms9UXfuP2kw=; b=6rHWQIrWmcTxBa7jAx5XMmZllnfAdBzuQFOyCV985TuYRru7TjLDYOJM6Rkeefeokv UOVOSUKXS+BwWWMjar65iJLD6WxUn/UCQJ5fPRKCi67pUfXiy/07yQosdboqcReeQXJN 812sFc+V6O241QumFUV5td2xXeGKYgELWh8CJ69eihB3M4G+1cLLH/mxbOBVXI+rjguT 5Zfly0GAbe2POwxOrOxHQPWqODZ3S2kvOiXbPx2iaQs7Wo3IEXmg0epFnLJXkS/272Ym gh5VvlLErxbvbs4DjNQrs+MLX/CaJ8pQ8p0Ft+sT4HlEQu5UYPF3R4LYofMpLICYq8Tr SKeg== X-Gm-Message-State: AOAM530UpqYbTh8ANzO0l6LcyuD73bBpBOT/y4HTX+FkB/klQg5CBNAx 9mU9yhw1EZhOhxs7CNsmSHt2I6r0JxQYSw== X-Google-Smtp-Source: ABdhPJyza+Anz0ZfIOdnQpzp53CU1aihVFGYzQs26Wv2GIdVsNW5VJ+joU+xoiVNsdmlg+6oXvoPzA== X-Received: by 2002:a05:6512:448:b0:472:3c0e:cf7f with SMTP id y8-20020a056512044800b004723c0ecf7fmr19043976lfk.279.1651771827716; Thu, 05 May 2022 10:30:27 -0700 (PDT) Received: from localhost.localdomain (89-73-146-138.dynamic.chello.pl. [89.73.146.138]) by smtp.gmail.com with ESMTPSA id z26-20020ac25dfa000000b0047255d21203sm289640lfq.306.2022.05.05.10.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 10:30:27 -0700 (PDT) From: Stanislaw Kardach To: dev@dpdk.org Cc: Stanislaw Kardach , Frank Zhao , Sam Grove , mw@semihalf.com, upstream@semihalf.com, pbhagavatula@marvell.com Subject: [PATCH 02/11] examples/l3fwd: fix scalar LPM compilation Date: Thu, 5 May 2022 19:29:54 +0200 Message-Id: <20220505173003.3242618-3-kda@semihalf.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220505173003.3242618-1-kda@semihalf.com> References: <20220505173003.3242618-1-kda@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The lpm_process_event_pkt() can either process a packet using an architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) path or a scalar one. The choice is however done using an ifdef pre-processor macro. Because of that the scalar version was apparently not widely excersized/compiled. Due to some copy/paste errors, the scalar logic in lpm_process_event_pkt() retained a "continue" statement where a BAD_PORT should be returned after refactoring of the LPM logic in the l3fwd example. Fixes: 99fc91d18082 ("examples/l3fwd: add event lpm main loop") Cc: pbhagavatula@marvell.com Signed-off-by: Stanislaw Kardach Sponsored-by: Frank Zhao Sponsored-by: Sam Grove --- examples/l3fwd/l3fwd_lpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c index bec22c44cd..6e1defbf7f 100644 --- a/examples/l3fwd/l3fwd_lpm.c +++ b/examples/l3fwd/l3fwd_lpm.c @@ -248,7 +248,7 @@ lpm_process_event_pkt(const struct lcore_conf *lconf, struct rte_mbuf *mbuf) if (is_valid_ipv4_pkt(ipv4_hdr, mbuf->pkt_len) < 0) { mbuf->port = BAD_PORT; - continue; + return mbuf->port; } /* Update time to live and header checksum */ --(ipv4_hdr->time_to_live);