diff mbox series

[v1,5/5] baseband/fpga_5gnr_fec: remove filler from HARQ

Message ID 20220509201734.946900-6-hernan.vargas@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Vargas, Hernan May 9, 2022, 8:17 p.m. UTC 
  Removed dec->n_filler from harq_out_length calculation.

Signed-off-by: Hernan <hernan.vargas@intel.com>
---
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Akhil Goyal May 16, 2022, 6:07 p.m. UTC | #1 
> Removed dec->n_filler from harq_out_length calculation.
> 
Please provide a better description describing the reason to remove it.
Chautru, Nicolas May 20, 2022, 1:25 a.m. UTC | #2 
Hernan, 

Please be more explicit on the commit description in the next patch version, suggesting below:

The computation of the HARQ output length should not include the filler bits on the N3000 HW implementation as these are already taken out by the deratematching step.
The change is only an optimization (no functional impact), no change required on stable branches.

Thanks
Nic

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Monday, May 16, 2022 11:07 AM
> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org;
> trix@redhat.com
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: RE: [EXT] [PATCH v1 5/5] baseband/fpga_5gnr_fec: remove filler
> from HARQ
> 
> > Removed dec->n_filler from harq_out_length calculation.
> >
> Please provide a better description describing the reason to remove it.
diff mbox series

Patch

diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 8fdb44c94a..22a548a336 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -1844,7 +1844,7 @@  enqueue_ldpc_dec_one_op_cb(struct fpga_queue *q, struct rte_bbdev_dec_op *op,
 		else
 			l = k0 + e + dec->n_filler;
 		harq_out_length = RTE_MIN(RTE_MAX(harq_in_length, l),
-				dec->n_cb - dec->n_filler);
+				dec->n_cb);
 		dec->harq_combined_output.length = harq_out_length;
 	}