[1/1] test/hash: report non HTM numbers for single r/w

Message ID 20220510115734.457718-1-kda@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series [1/1] test/hash: report non HTM numbers for single r/w |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Stanislaw Kardach May 10, 2022, 11:57 a.m. UTC
  In hash_readwrite_perf_autotest a single read and write operation is
benchmarked for both HTM and non HTM cases. However the result summary
only shows the HTM value. Therefore add the non HTM value for
completeness.

Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency")

Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
---
 app/test/test_hash_readwrite.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
  

Comments

Wang, Yipeng1 May 10, 2022, 10:09 p.m. UTC | #1
> -----Original Message-----
> From: Stanislaw Kardach <kda@semihalf.com>
> Sent: Tuesday, May 10, 2022 4:58 AM
> To: Wang, Yipeng1 <yipeng1.wang@intel.com>
> Cc: Stanislaw Kardach <kda@semihalf.com>; dev@dpdk.org; Frank Zhao
> <Frank.Zhao@starfivetech.com>; Sam Grove <sam.grove@sifive.com>;
> mw@semihalf.com; upstream@semihalf.com
> Subject: [PATCH 1/1] test/hash: report non HTM numbers for single r/w
> 
> In hash_readwrite_perf_autotest a single read and write operation is
> benchmarked for both HTM and non HTM cases. However the result
> summary only shows the HTM value. Therefore add the non HTM value for
> completeness.
> 
> Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency")
> 
> Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> ---
[Wang, Yipeng] Thanks for the patch!
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
  
David Marchand May 11, 2022, 11:56 a.m. UTC | #2
On Wed, May 11, 2022 at 12:10 AM Wang, Yipeng1 <yipeng1.wang@intel.com> wrote:
> > From: Stanislaw Kardach <kda@semihalf.com>
> >
> > In hash_readwrite_perf_autotest a single read and write operation is
> > benchmarked for both HTM and non HTM cases. However the result
> > summary only shows the HTM value. Therefore add the non HTM value for
> > completeness.
> >
> > Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency")
> >
> > Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>

Applied, thanks.
  

Patch

diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c
index 9b192f2b5e..6373e62d33 100644
--- a/app/test/test_hash_readwrite.c
+++ b/app/test/test_hash_readwrite.c
@@ -664,8 +664,12 @@  test_hash_rw_perf_main(void)
 	printf("Results summary:\n");
 	printf("================\n");
 
-	printf("single read: %u\n", htm_results.single_read);
-	printf("single write: %u\n", htm_results.single_write);
+	printf("HTM:\n");
+	printf("  single read: %u\n", htm_results.single_read);
+	printf("  single write: %u\n", htm_results.single_write);
+	printf("non HTM:\n");
+	printf("  single read: %u\n", non_htm_results.single_read);
+	printf("  single write: %u\n", non_htm_results.single_write);
 	for (i = 0; i < NUM_TEST; i++) {
 		printf("+++ core_cnt: %u +++\n", core_cnt[i]);
 		printf("HTM:\n");