From patchwork Tue May 10 11:58:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Kardach X-Patchwork-Id: 110977 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E7B2A0093; Tue, 10 May 2022 13:58:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7036C42822; Tue, 10 May 2022 13:58:54 +0200 (CEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id 025B54069D for ; Tue, 10 May 2022 13:58:53 +0200 (CEST) Received: by mail-lj1-f174.google.com with SMTP id m23so20550229ljb.8 for ; Tue, 10 May 2022 04:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sYVtZ3FCCHmCTUIeXaes6QkUDCCYj46uR55BjXZAfPk=; b=lDJ2gQUpMqYNKuYI2sTuSkgzSRzYuo7I73oNN7UAHekB+FooRWkNWqR+e2dOaBMbll A1/Tpq9+C6ARj6NUBNkgtRWwNrM/vz135rqlg1wwqUyZhi+RMZ2ChYxDwm4BwvrPP4lC ilfSFNgqHJkL3H+uMmIIVSk5itCOAsglss13YlAs3bpI/RKQ/36s8YfqgNQYIATq+fxa RSd182WF+9rXIXaXUkrergKAGyXDbY3dFw/47V/1jkRVLgHrHq3aS/H2jRIzLhHka1my NAU+jPK0J8BR9Rv9RDiyuzv+RV9j6mWuKxuc9nFw3XN5kA0v0rOVsJUk/2sR4fnbA++7 /E/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sYVtZ3FCCHmCTUIeXaes6QkUDCCYj46uR55BjXZAfPk=; b=fA65ZDIZa9dlJ6Okw2A1kSQ2ukgAg0Z9G0CLiYoahH6s7OXOQ9++Lj7BSVJxTGUGnl XSz1oQnpjjVWfhv6A+7rInXKGpZ5s5mYarM1gnq/HPs8C8v2S50JYsrhUE18wN5glqDs Iv6m9mXMJfIKaASY8+gqtHmva3fLTZXZQGeIallzKOmgSSamWwAySHovCxxZRl5g9lln x5Hlv6sU/mlA6OVPsvEota9x4Wz0zEdC03oMYKPs4HlKNiIhaM+YAjhtWUZLytJhRlsj JWeq+J4BnihCMjx6R1X79pkXak6tGiscrA3kbd5c+usHho630lV/PwX8sK8yk5tAHqzw 0wCg== X-Gm-Message-State: AOAM532z6PAEqXafrJnRsgoQyV8EicH7Tk/soDmPsW3GHd2+/DN4J0RZ Ct0gGoWxaLUl2LEXpelIxx9JiBF6aHk5fQ== X-Google-Smtp-Source: ABdhPJydMdtSwmPYP9sCm+fZR/9xOiS8UsIr0Ypcwx6dXYTmKnuHay887MdNNcWfNSL9czcSSslAqg== X-Received: by 2002:a05:651c:890:b0:248:5819:b949 with SMTP id d16-20020a05651c089000b002485819b949mr13638310ljq.476.1652183931581; Tue, 10 May 2022 04:58:51 -0700 (PDT) Received: from toster.office.semihalf.net ([83.142.187.84]) by smtp.gmail.com with ESMTPSA id i11-20020a0565123e0b00b0047255d211e0sm2261564lfv.271.2022.05.10.04.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 04:58:51 -0700 (PDT) From: Stanislaw Kardach To: dev@dpdk.org Cc: Stanislaw Kardach , Frank Zhao , Sam Grove , mw@semihalf.com, upstream@semihalf.com, pbhagavatula@marvell.com Subject: [PATCH 1/1] examples/l3fwd: fix scalar LPM compilation Date: Tue, 10 May 2022 13:58:44 +0200 Message-Id: <20220510115844.458009-1-kda@semihalf.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The lpm_process_event_pkt() can either process a packet using an architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) path or a scalar one. The choice is however done using an ifdef pre-processor macro. Because of that the scalar version was apparently not widely excersized/compiled. Due to some copy/paste errors, the scalar logic in lpm_process_event_pkt() retained a "continue" statement where a BAD_PORT should be returned after refactoring of the LPM logic in the l3fwd example. Fixes: 99fc91d18082 ("examples/l3fwd: add event lpm main loop") Cc: pbhagavatula@marvell.com Signed-off-by: Stanislaw Kardach --- examples/l3fwd/l3fwd_lpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c index bec22c44cd..6e1defbf7f 100644 --- a/examples/l3fwd/l3fwd_lpm.c +++ b/examples/l3fwd/l3fwd_lpm.c @@ -248,7 +248,7 @@ lpm_process_event_pkt(const struct lcore_conf *lconf, struct rte_mbuf *mbuf) if (is_valid_ipv4_pkt(ipv4_hdr, mbuf->pkt_len) < 0) { mbuf->port = BAD_PORT; - continue; + return mbuf->port; } /* Update time to live and header checksum */ --(ipv4_hdr->time_to_live);