| Message ID | 20220520055445.40063-10-arkadiuszx.kusztal@intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | akhil goyal |
| Headers | show |
| Series | cryptodev: rsa, dh, ecdh changes | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
> - removed unnecessary zero assignement in rsa padding enum. > Even it is set correctly it should be made consistent with > other enums in cryptodev. Therefore assignement to zero was > removed. > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com> > --- > lib/cryptodev/rte_crypto_asym.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h > index 0fc9f49b87..270619acf2 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -116,11 +116,12 @@ enum rte_crypto_asym_ke_type { > * Padding types for RSA signature. > */ > enum rte_crypto_rsa_padding_type { > - RTE_CRYPTO_RSA_PADDING_NONE = 0, > + RTE_CRYPTO_RSA_PADDING_NONE, > /**< RSA no padding scheme */ > RTE_CRYPTO_RSA_PADDING_PKCS1_5, > - /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. For signatures block type > 01, > - * for encryption block type 02 are used. > + /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. > + * For signatures block type 01, for encryption > + * block type 02 are used. This change is not required or make it a separate patch. > */ > RTE_CRYPTO_RSA_PADDING_OAEP, > /**< RSA PKCS#1 OAEP padding scheme */ > -- > 2.13.6
diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index 0fc9f49b87..270619acf2 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -116,11 +116,12 @@ enum rte_crypto_asym_ke_type { * Padding types for RSA signature. */ enum rte_crypto_rsa_padding_type { - RTE_CRYPTO_RSA_PADDING_NONE = 0, + RTE_CRYPTO_RSA_PADDING_NONE, /**< RSA no padding scheme */ RTE_CRYPTO_RSA_PADDING_PKCS1_5, - /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. For signatures block type 01, - * for encryption block type 02 are used. + /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. + * For signatures block type 01, for encryption + * block type 02 are used. */ RTE_CRYPTO_RSA_PADDING_OAEP, /**< RSA PKCS#1 OAEP padding scheme */
- removed unnecessary zero assignement in rsa padding enum. Even it is set correctly it should be made consistent with other enums in cryptodev. Therefore assignement to zero was removed. Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com> --- lib/cryptodev/rte_crypto_asym.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)