From patchwork Fri May 20 05:54:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 111494 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C302AA0503; Fri, 20 May 2022 09:03:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37B0042BA8; Fri, 20 May 2022 09:02:59 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 3AC3542BA6 for ; Fri, 20 May 2022 09:02:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653030178; x=1684566178; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=3OG6Ai7s75itRFAykoDFY457u4E1l8ywVrH8fLstJwM=; b=jhIGQvKvUugEsaTY9psy4eJNy6zWrtfR6bpanmPG5KAH254Bn6cSLlWz aYMh9yYPE2ekYueZ5oXZgJXawwjXBcQ1kru9B8x5pRZW7VSTadZhX4Lfj ni5fqDRcLRamr2C+n+ZlMifyFqvd/sofnMjVJQ2vPiER4FjBe8vsQ6GU3 QitgULVr3NTzTaa3MAY3u+G/bMApHOcgIORsmxAnGUU0XWmtjHHgsibSM 5YMyJN4qzaHReWJllAs1BtGC3yQHgJqcNGyPFGcqynShYWYwNwsyxLvm9 yu/ee0k7ItoJVpbIJyG6iER2s+To11gh4f7ZI8eFnQQW26a/xKoYlbpsX w==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="333140289" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="333140289" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 00:02:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="599058176" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by orsmga008.jf.intel.com with ESMTP; 20 May 2022 00:02:56 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, anoobj@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal Subject: [PATCH 10/40] cryptodev: remove comment about using ephemeral key in dsa Date: Fri, 20 May 2022 06:54:15 +0100 Message-Id: <20220520055445.40063-11-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org - removed comment that stated dsa can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer but not for private keys. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index 270619acf2..1652a434a5 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -272,13 +272,7 @@ struct rte_crypto_dsa_xform { rte_crypto_uint g; /**< Generator of the subgroup */ rte_crypto_uint x; - /**< x: Private key of the signer in octet-string network - * byte order format. - * Used when app has pre-defined private key. - * Valid only when xform chain is DSA ONLY. - * if xform chain is DH private key generate + DSA, then DSA sign - * compute will use internally generated key. - */ + /**< x: Private key of the signer */ }; /**