diff mbox series

[v2,5/7] net/ark: report additional errors from firmware

Message ID 20220520141512.2713384-5-ed.czeck@atomicrules.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series [v2,1/7] devtools: add Atomic Rules acronyms for commit checks |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Ed Czeck May 20, 2022, 2:15 p.m. UTC 
  detect and report completion errors from firmware

Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
 drivers/net/ark/ark_rqp.c | 6 ++++--
 drivers/net/ark/ark_rqp.h | 3 ++-
 2 files changed, 6 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c
index ef9ccd0706..efb9730fe6 100644
--- a/drivers/net/ark/ark_rqp.c
+++ b/drivers/net/ark/ark_rqp.c
@@ -22,14 +22,16 @@  ark_rqp_stats_reset(struct ark_rqpace_t *rqp)
 void
 ark_rqp_dump(struct ark_rqpace_t *rqp)
 {
-	if (rqp->err_count_other != 0)
+	if (rqp->err_count_other || rqp->cmpl_errors)
 		ARK_PMD_LOG(ERR,
 			    "RQP Errors noted: ctrl: %d cplh_hmax %d cpld_max %d"
 			    ARK_SU32
+			    ARK_SU32
 			    ARK_SU32 "\n",
 			    rqp->ctrl, rqp->cplh_max, rqp->cpld_max,
 			    "Error Count", rqp->err_cnt,
-			    "Error General", rqp->err_count_other);
+			    "Error General", rqp->err_count_other,
+			    "Cmpl Errors", rqp->cmpl_errors);
 
 	ARK_PMD_LOG(INFO, "RQP Dump: ctrl: %d cplh_hmax %d cpld_max %d"
 		      ARK_SU32
diff --git a/drivers/net/ark/ark_rqp.h b/drivers/net/ark/ark_rqp.h
index 6c8046062b..d09f242e1e 100644
--- a/drivers/net/ark/ark_rqp.h
+++ b/drivers/net/ark/ark_rqp.h
@@ -48,7 +48,8 @@  struct ark_rqpace_t {
 	volatile uint32_t cpld_pending_max;
 	volatile uint32_t err_count_other;
 	char eval[4];
-	volatile int lasped;
+	volatile int32_t lasped;
+	volatile uint32_t cmpl_errors;
 };
 
 void ark_rqp_dump(struct ark_rqpace_t *rqp);