From patchwork Wed May 25 15:53:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 111828 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FF49A0555; Wed, 25 May 2022 19:03:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 232C04281C; Wed, 25 May 2022 19:03:42 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 4CB2E427F2 for ; Wed, 25 May 2022 19:03:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653498219; x=1685034219; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=FL5vKTocJn4X3evpEqmdeWjyKnN04RfEXCoLFhELuCU=; b=CNq9jYDOncSFQ6aXeXUy7BSP0bFTunJk5DkBp2u7Ml7awEa9+567y3p4 eciccpYtUO1ohjzx8T6zJc7sqMfWCm94235LxJqoU1w2ym2ACOM1pvGHc 4CamD3ouhqYALM8Pi3NPY6oKp7oJXJNbn7tX1+u3GUeYYWFUREnZXPAgu FJqu6Fjd1faSIX0nbvvWQZu1mCtagMSZYl+/0IGVKI+atIZZn2g7RjVTU rUj76aA4VAGS3D2hASYvyRVgUGfaJxNdfNBWSn6qikDAjqyYmRHGPVfkZ TvbZQd3KzoiLhv+9nmLhYY1qj1hczklr3BA4MD8vs5eSt0Mlsxve8T/aD g==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="273596192" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="273596192" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2022 10:01:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="664502314" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by FMSMGA003.fm.intel.com with ESMTP; 25 May 2022 10:01:14 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal Subject: [PATCH v2 04/14] cryptodev: remove comment about using ephemeral key in dsa Date: Wed, 25 May 2022 16:53:14 +0100 Message-Id: <20220525155324.9288-5-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org - Removed comment that stated dsa can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer but not for private keys. Signed-off-by: Arek Kusztal Acked-by: Akhil Goyal --- lib/cryptodev/rte_crypto_asym.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index 2b427afa3f..ef8686fda8 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -270,13 +270,7 @@ struct rte_crypto_dsa_xform { rte_crypto_uint g; /**< Generator of the subgroup */ rte_crypto_uint x; - /**< x: Private key of the signer in octet-string network - * byte order format. - * Used when app has pre-defined private key. - * Valid only when xform chain is DSA ONLY. - * if xform chain is DH private key generate + DSA, then DSA sign - * compute will use internally generated key. - */ + /**< x: Private key of the signer */ }; /**