From patchwork Mon May 30 14:31:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 112068 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27478A0542; Mon, 30 May 2022 17:40:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BA6E4282A; Mon, 30 May 2022 17:39:46 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 1064041611 for ; Mon, 30 May 2022 17:39:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653925183; x=1685461183; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=wZ5DBqXfnqdcIGZwqal1S9d/1ecUNMSQI/cDtHOfjLw=; b=h/U7X0j0sZomfQfnV/q9AHVJSrcekFeEwsdP0RaE/Udw6PcMXCp85NCN phqSzju/OzBFtuMidpzCWKopd6VI5cTNmIUMDN2e3SePhhlIGNuoLaaT0 6xkXNES4QBweU+b9HpJaTv7tD9rJUkOBUNGb0aXRyDN0gerDEXTYdtK/g JG2d1Cd4xCIt/TuPZSHU0zuT7q/QAs78KWbEM7o46W3pMjr4ksbI7lNN5 WcxynCi497rTXyFc1jFRQBAJaNQFRaQRtB1tEe1TUEqKwQQCM0LkEZCK1 kAS3jz9eCzkTB/cuMBWm045xZnrsOx8MOmYy/Fe889zpul/dHRD84zigC w==; X-IronPort-AV: E=McAfee;i="6400,9594,10363"; a="338069434" X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="338069434" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 08:39:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="751678111" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by orsmga005.jf.intel.com with ESMTP; 30 May 2022 08:39:41 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal Subject: [PATCH v3 03/12] cryptodev: remove comment about using ephemeral key in dsa Date: Mon, 30 May 2022 15:31:50 +0100 Message-Id: <20220530143159.13672-4-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20220530143159.13672-1-arkadiuszx.kusztal@intel.com> References: <20220530143159.13672-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org - Removed comment that stated DSA can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer, but not for private keys. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index e496588c7a..eb753b4016 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -292,13 +292,7 @@ struct rte_crypto_dsa_xform { rte_crypto_uint g; /**< Generator of the subgroup */ rte_crypto_uint x; - /**< x: Private key of the signer in octet-string network - * byte order format. - * Used when app has pre-defined private key. - * Valid only when xform chain is DSA ONLY. - * if xform chain is DH private key generate + DSA, then DSA sign - * compute will use internally generated key. - */ + /**< x: Private key of the signer */ }; /**