From patchwork Wed Jun 1 09:02:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 112213 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53546A0548; Wed, 1 Jun 2022 12:11:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0603442B82; Wed, 1 Jun 2022 12:10:53 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 4947B4003F for ; Wed, 1 Jun 2022 12:10:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654078251; x=1685614251; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=wZ5DBqXfnqdcIGZwqal1S9d/1ecUNMSQI/cDtHOfjLw=; b=d+f8Z2xhUl4zTEibQGRfwingV8uki8m0b62CrLzdoXJRB6FUoUKVdODc 2bEKB+f4jrqLv/fxrl64oeIK8BHOCenvg+agzepOQnrPPXE6LJ2B4TAG0 pzwo5wS57bloq9Bur1tTxK6mxNIn61sAv6GNDGUknx1Q86owL3UFZiUOi V+aoybYdteAsd4WjVJMTYBAP79RyrlbocxcbfjC/gfCKvaEz6/Ilrssjj t2YQCCmeYu91GSmjPwuoerzxsVn8UJZU/PTrIzOPNjlBXQasEzkZ1u+DJ ZxfkNVaLG+vUZnpmXPpKHwAJJnv5RXLU0ZDyPVvgXTP6Jc4s5FP6ZedBT g==; X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="275616395" X-IronPort-AV: E=Sophos;i="5.91,266,1647327600"; d="scan'208";a="275616395" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2022 03:10:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,266,1647327600"; d="scan'208";a="606185859" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by orsmga008.jf.intel.com with ESMTP; 01 Jun 2022 03:10:31 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal Subject: [PATCH v5 03/12] cryptodev: remove comment about using ephemeral key in dsa Date: Wed, 1 Jun 2022 10:02:40 +0100 Message-Id: <20220601090249.86865-4-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20220601090249.86865-1-arkadiuszx.kusztal@intel.com> References: <20220601090249.86865-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org - Removed comment that stated DSA can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer, but not for private keys. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index e496588c7a..eb753b4016 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -292,13 +292,7 @@ struct rte_crypto_dsa_xform { rte_crypto_uint g; /**< Generator of the subgroup */ rte_crypto_uint x; - /**< x: Private key of the signer in octet-string network - * byte order format. - * Used when app has pre-defined private key. - * Valid only when xform chain is DSA ONLY. - * if xform chain is DH private key generate + DSA, then DSA sign - * compute will use internally generated key. - */ + /**< x: Private key of the signer */ }; /**