From patchwork Thu Jun 2 01:52:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jin Liu X-Patchwork-Id: 112241 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3100CA0548; Thu, 2 Jun 2022 03:54:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DDA74069F; Thu, 2 Jun 2022 03:54:25 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2137.outbound.protection.outlook.com [40.107.100.137]) by mails.dpdk.org (Postfix) with ESMTP id AE8FC427EA for ; Thu, 2 Jun 2022 03:54:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UwmCpgdTUZPaE9tgXAI2JKEcW1nNk7azbYo1A0BzWTGju086TCuSdWbYCIMu8PDfcdtAWv9UzeHZy65RriPyo+7Xm6JtcPmGV35G4YiIz+i2j1MKnn0Z6NfzwTkK7QMyGAryZrCA0mUEyxb7v6Haxvgrw+DVfrDZje1pcgLU32aOZe95zMRj6Ap0XPqrEK7meyfadMc/g5kl2Rc6qO09nUW50BP1IuYnbfRDZ8HkhscdhKhMcI8nqDEqKcdPCT5NdUGI91uxgKWzoQbEXDPBCdFHIaliK0bNPdu4nElpNvVbIz0xmdbx39p1DvF2rHxTQewHZXI7/BHAnEaS46Jhmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lxYcfnVKM+An3mCvq8ymHnfO7sJD5oe+dvmXry8rKa4=; b=e5mRpDLvDq+a4S/hsVTn4CLXTLZd0hVU2b9g2+Zo53hC0FnlvL4cJ70CaujoQoZsa+vUXIUxuyIw43Cpfnb2YkLvRDeSftwJcnPt/VMondbg3ixk9urP+IaRWNBLgjdzozZukx6zjP74sbsQ/DHLW4VO2DhCfnLOSw/I4xgPdVUiMCMcpa4hP7Nf/1rNqjxKtu7hG9x29gXxQ4UDOs65+lslbzwhMqAf6fsccPJjqEBPf7Y747TaaGn3bOOD0S72IHMSR01jyuhkoMxEVZBZG+22G1Rm885o0/GhXoOcSzQ7OUjVxVMrZRw7SWeTU4zu9GYGSwysxKWN3uAr/dzEgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lxYcfnVKM+An3mCvq8ymHnfO7sJD5oe+dvmXry8rKa4=; b=Dcz++zp4+rJKcWov38mTC4E8+4gjHC9TkIjYiutHuiZJrSpaz9ILsvxG8H8i91Uzy3WLDsug2On2AbAuT8eQQDGDsghqk8TFlYSw6KG2NAv5dDPuz9rs3aKcxlkpq3okmtCGum7llbrACZv0NLxYLbNHuqWpYQRZw3gt6x37Y48= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB3004.namprd13.prod.outlook.com (2603:10b6:5:191::21) by CY4PR13MB1349.namprd13.prod.outlook.com (2603:10b6:903:a0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Thu, 2 Jun 2022 01:54:22 +0000 Received: from DM6PR13MB3004.namprd13.prod.outlook.com ([fe80::d902:ed7d:82bb:c753]) by DM6PR13MB3004.namprd13.prod.outlook.com ([fe80::d902:ed7d:82bb:c753%4]) with mapi id 15.20.5314.013; Thu, 2 Jun 2022 01:54:22 +0000 From: Jin Liu To: dev@dpdk.org Cc: niklas.soderlund@corigine.com, Chaoyong He , Jin Liu Subject: [PATCH 02/14] net/nfp: remove unnecessary forward function declaration Date: Thu, 2 Jun 2022 03:52:52 +0200 Message-Id: <20220602015304.710197-3-jin.liu@corigine.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220602015304.710197-1-jin.liu@corigine.com> References: <20220602015304.710197-1-jin.liu@corigine.com> X-ClientProxiedBy: LO4P123CA0457.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::12) To DM6PR13MB3004.namprd13.prod.outlook.com (2603:10b6:5:191::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7927bfa9-bce7-4981-d165-08da443ad02a X-MS-TrafficTypeDiagnostic: CY4PR13MB1349:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ICBV1EE6ghllJgK8uKLKLs0qsf+El6TnyzHzASBmXSOke6ErgfG/1JWK03UJ36t10Zz8WSdxHwK9jmPgqC7Hc1AE2Br0IuQYOjVWHBuMoG4cYIV2WcS1jVH+CVy+B26XyznIP+9Hf58D7QGSTQt7QVwlfoMMCJyssW0MNaSGVmsx3WyowSgp4S7J/emcBOjnaMvZFWECPENdJsLkbswspG1KGGAyPqgHZsiaw0zi48QQMTeTkSxFshF1YK6zdkVN7VAuQndfdPWVcb+p6yDGxdwUkQhWBxBWs7/Aba98392HVIA/xgmWD7ovRGX/EZEWeaP6u1e67FuRaG6xfhzeyhQsEMTyLR4SgAMAlOlLDwnAsjhm9o7MCBFNsHy9c+6xGa3/VxWTFYE0Ze1KR8IWyHk/4l9HnDCHtTpUU/fAuzRFzBLVdfbPBKm7POCnQfiRsOJEHaFBmYVPCY1Iii8yvjnxtlLtT/s+XiU4FVzsz/oS/okCa/W6LqXqupE6SH2YcrcoM60d0De1BPOL5taJbfUCP5r+to3NJ86a0DsIEbt9butdxLBCJ1GgqyZx00FYZQUcdwyWrGKzzuUDjrI2zRQIhA0q80/rM/v0y9y/nFMb4F5K4FsJ6vjJ+KKVEq5AN4acF391VxDHcEzv2luabeVYXLYWtlnXpftFONCBV/JE//bFwAg38iVCJYVH2Bbqze/u2PWASnWTgn+IwRMJLw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB3004.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(39840400004)(136003)(376002)(346002)(396003)(6512007)(83380400001)(8936002)(38350700002)(8676002)(66476007)(316002)(4326008)(38100700002)(26005)(66946007)(66556008)(2906002)(6506007)(6486002)(5660300002)(508600001)(6666004)(52116002)(107886003)(1076003)(36756003)(186003)(86362001)(41300700001)(66574015)(44832011)(2616005)(54906003)(6916009); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ePcQMrSK5Z2HSQ72YSJ5XuMG/X0G?= =?utf-8?q?fHG56x3CoPHCrJw2qF1fpNCdKrIp3LVHkR69pgXmLpu72g2yUwn9321N9dqVX2eNG?= =?utf-8?q?wW53GcHzqHmXifkOKkwSNussICaK5sXtNJts6ZUuV9/aRGe8opM/kQVP+VynJ23L+?= =?utf-8?q?amvCdhoqhnuKH5MMaDUZORQDVL5erWE02YQLTSKPcKApxOkYVgOwdd7L0kxgaOg9+?= =?utf-8?q?nBwm03nGBMZzn9VIWoAOVL1YSHkJXl4xVqJfs8Zno6JrgnWyos1xbtzLSL+1HN+RR?= =?utf-8?q?ZlDtvhTqsnYwImU4MLMA9WfuHEd5/eaAm6JaNoQLbcDvg151z4aOaZEJnpQuxgtoP?= =?utf-8?q?IOjAj6mFLwzh9z2yQBcxKu/kA2SZ65mrBV5soR3sRIVf1NoVygSl5zUqlxhNYqRYD?= =?utf-8?q?Aj5fB0H4xrVnHzP9uq/vLax/NtiOdIPuDsCGgxlaRrVXY8ikTs0pvsLozZyHtBPeS?= =?utf-8?q?NWFOWiWVha91BGs0sSLjADOyKpCAdXLtc87cQ+ZwyWQCCt24CqFil/yKkOnITR774?= =?utf-8?q?ZDIYbFZjjtqIsd1DGwzGB8Byked/flq7Hez+SAcjlYhzdOcIZPqjfVtn8Kv6QFpjn?= =?utf-8?q?mBhZ3gLK9M8ZsKeDTaYUFaGz7X/7S41ytG5m6IO7WQOxOroIGafxMCdvJOoS4PkTs?= =?utf-8?q?xrzzcXKmbWtlJekt9qOYkuwtAlD4O8itPqXpOZGw/2Jgg+4rGF+Tthjkscyr9E6Yu?= =?utf-8?q?h/m9DQoFIqVp4dR6UFIgVR3FWT3z8M1Zvvscvx0DJBRaxJjwDrF+H2ur+9xU7j5zu?= =?utf-8?q?c8PV6blAIQvkYUjLYD/qLxCP8JoNr8fPSB4/KZyjbFdoV6hnbGdVy5BD+jA+29XVw?= =?utf-8?q?9I6pmpOt2DEl/zJuhsr7f+a2GXyzqb9fyg3fWlkYeodI2RJ+i1VzlDvB0Tu9CqFnR?= =?utf-8?q?6DjTIQkW/dxYWfdJ6AeK+/vn9xHC8zHKQn/owtXcMKDERp7yRQY/xufZeoXrEQxs/?= =?utf-8?q?4sVJC62fEj6GBNp4AJZsyc8qkCtRsO3b7iGYrp1N+GSQ+0NStPlE+Bq/3od5i1J7T?= =?utf-8?q?or12J0VRhyhJ+jxXZcEvTviZYr9tEY9aKIA2IPnmPkhBEs89kTuFxI+mRxLnK71Nr?= =?utf-8?q?7/bAZCcj4QDrsymEaHlBJpQQuRMA6eMpun2BFVbiwO5EPglfmZyCqsckKMeFgynGD?= =?utf-8?q?s6yr2EDdgId7i0Q+0zWm+oVUwFZFEEWvZ7MjSU8Jj418/EgFMeB7p9Z3IGue+N5f6?= =?utf-8?q?QLZBAg4VRyFR2bjw7CsPPclmD8dgwLcfr/4a37cwlNHQkNKzJaQPdEnLLaWgnkR8z?= =?utf-8?q?pBIqXNGQqvluPCBXPgLmBCSUfAUjhYTI1TRXzxY8IBwjsIzXhtknAUmQvb/43XQ+r?= =?utf-8?q?0gbqErSVRpBO+0WlNc6u4jr5z0H6jF6qHblcRDNjVUKIILyjDgxqI8KpsgGSQ75xy?= =?utf-8?q?kknKeWMLb/f3AEbA29rI/y1llT2O+X3L6z1B0mMsT4ZWEzNvKJ2zMeE4cX/Wc0DML?= =?utf-8?q?KFRq04DQGzCNB7YAigT/0oimdvdcxs6CIb4Fb2F4LnBDkY9DOM2Cc1CwcGMYp2s5w?= =?utf-8?q?PXGf+A7m6tcXqMjIWt1cUmm4a1jry9zE2FaDTyG4tX7+YD2Nvp8I7BbxRWrAgMyNG?= =?utf-8?q?o3voCo82n5Rr1mi85nt/qsja/XK/lzVNJGFDUJuH9H54vTQ7X9+RNkGeMUT8TeDjT?= =?utf-8?q?zXeebMxH96GxD890FlhWM4TYcgE4BoxA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7927bfa9-bce7-4981-d165-08da443ad02a X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB3004.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 01:54:22.0261 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SQ5EbA4yd8/rQiUDnfHieU9B2aj/LhnMg7DOXT7fzYPW/xKaDBF0aYe7/aqHbbnreNjDJSTAFJ8KQFE6Qr/VKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR13MB1349 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Chaoyong He This commit remove some unnecessary forward function declarations. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c | 22 ---------------------- drivers/net/nfp/nfp_ethdev_vf.c | 12 ------------ drivers/net/nfp/nfp_rxtx.c | 21 --------------------- 3 files changed, 55 deletions(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index ea92ca3f68..790d575bb8 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -38,28 +38,6 @@ #include "nfp_ctrl.h" #include "nfp_cpp_bridge.h" - -static int nfp_net_pf_read_mac(struct nfp_pf_dev *pf_dev, int port); -static int nfp_net_start(struct rte_eth_dev *dev); -static int nfp_net_stop(struct rte_eth_dev *dev); -static int nfp_net_set_link_up(struct rte_eth_dev *dev); -static int nfp_net_set_link_down(struct rte_eth_dev *dev); -static int nfp_net_close(struct rte_eth_dev *dev); -static int nfp_net_init(struct rte_eth_dev *eth_dev); -static int nfp_fw_upload(struct rte_pci_device *dev, - struct nfp_nsp *nsp, char *card); -static int nfp_fw_setup(struct rte_pci_device *dev, - struct nfp_cpp *cpp, - struct nfp_eth_table *nfp_eth_table, - struct nfp_hwinfo *hwinfo); -static int nfp_init_phyports(struct nfp_pf_dev *pf_dev); -static int nfp_pf_init(struct rte_pci_device *pci_dev); -static int nfp_pf_secondary_init(struct rte_pci_device *pci_dev); -static int nfp_pf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, - struct rte_pci_device *dev); -static int nfp_pci_uninit(struct rte_eth_dev *eth_dev); -static int eth_nfp_pci_remove(struct rte_pci_device *pci_dev); - static int nfp_net_pf_read_mac(struct nfp_pf_dev *pf_dev, int port) { diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c index 4aaccc91df..69d9e0ee47 100644 --- a/drivers/net/nfp/nfp_ethdev_vf.c +++ b/drivers/net/nfp/nfp_ethdev_vf.c @@ -23,18 +23,6 @@ #include "nfp_logs.h" #include "nfp_ctrl.h" -static void nfp_netvf_read_mac(struct nfp_net_hw *hw); -static int nfp_netvf_start(struct rte_eth_dev *dev); -static int nfp_netvf_stop(struct rte_eth_dev *dev); -static int nfp_netvf_set_link_up(struct rte_eth_dev *dev); -static int nfp_netvf_set_link_down(struct rte_eth_dev *dev); -static int nfp_netvf_close(struct rte_eth_dev *dev); -static int nfp_netvf_init(struct rte_eth_dev *eth_dev); -static int nfp_vf_pci_uninit(struct rte_eth_dev *eth_dev); -static int eth_nfp_vf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, - struct rte_pci_device *pci_dev); -static int eth_nfp_vf_pci_remove(struct rte_pci_device *pci_dev); - static void nfp_netvf_read_mac(struct nfp_net_hw *hw) { diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 335a90b2c9..cd7faa2c58 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -21,27 +21,6 @@ #include "nfp_logs.h" #include "nfp_ctrl.h" -/* Prototypes */ -static int nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq); -static inline void nfp_net_mbuf_alloc_failed(struct nfp_net_rxq *rxq); -static inline void nfp_net_set_hash(struct nfp_net_rxq *rxq, - struct nfp_net_rx_desc *rxd, - struct rte_mbuf *mbuf); -static inline void nfp_net_rx_cksum(struct nfp_net_rxq *rxq, - struct nfp_net_rx_desc *rxd, - struct rte_mbuf *mb); -static void nfp_net_rx_queue_release_mbufs(struct nfp_net_rxq *rxq); -static int nfp_net_tx_free_bufs(struct nfp_net_txq *txq); -static void nfp_net_tx_queue_release_mbufs(struct nfp_net_txq *txq); -static inline uint32_t nfp_free_tx_desc(struct nfp_net_txq *txq); -static inline uint32_t nfp_net_txq_full(struct nfp_net_txq *txq); -static inline void nfp_net_tx_tso(struct nfp_net_txq *txq, - struct nfp_net_tx_desc *txd, - struct rte_mbuf *mb); -static inline void nfp_net_tx_cksum(struct nfp_net_txq *txq, - struct nfp_net_tx_desc *txd, - struct rte_mbuf *mb); - static int nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq) {