diff mbox series

test/hash: avoid out of bound access

Message ID 20220604083711.64199-1-heinrich.schuchardt@canonical.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series test/hash: avoid out of bound access |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-aarch64-unit-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Heinrich Schuchardt June 4, 2022, 8:37 a.m. UTC 
  rwc_non_lf_results->multi_rw, rwc_lf_results->multi_rw, and
rwc_perf_results->multi_rw are accessed at indexes
[0..NUM_TEST-1][0..1][0..NUMTEST-1]. Currently the first index
overflows the array size in struct rwc_perf.

Fixes: c7eb0972e74b ("test/test/test_hash_readwrite_lf.c")
Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>
Cc: stable@dpdk.org 
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 app/test/test_hash_readwrite_lf_perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon June 26, 2022, 3:03 p.m. UTC | #1 
04/06/2022 10:37, Heinrich Schuchardt:
> rwc_non_lf_results->multi_rw, rwc_lf_results->multi_rw, and
> rwc_perf_results->multi_rw are accessed at indexes
> [0..NUM_TEST-1][0..1][0..NUMTEST-1]. Currently the first index
> overflows the array size in struct rwc_perf.
> 
> Fixes: c7eb0972e74b ("test/test/test_hash_readwrite_lf.c")
> Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Cc: stable@dpdk.org 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test/test_hash_readwrite_lf_perf.c b/app/test/test_hash_readwrite_lf_perf.c
index 8120cf43be..32f9ec9250 100644
--- a/app/test/test_hash_readwrite_lf_perf.c
+++ b/app/test/test_hash_readwrite_lf_perf.c
@@ -59,7 +59,7 @@  struct rwc_perf {
 	uint32_t w_ks_r_hit_nsp[2][NUM_TEST];
 	uint32_t w_ks_r_hit_sp[2][NUM_TEST];
 	uint32_t w_ks_r_miss[2][NUM_TEST];
-	uint32_t multi_rw[NUM_TEST - 1][2][NUM_TEST];
+	uint32_t multi_rw[NUM_TEST][2][NUM_TEST];
 	uint32_t w_ks_r_hit_extbkt[2][NUM_TEST];
 	uint32_t writer_add_del[NUM_TEST];
 };