diff mbox series

event/dlb2: fix advertized capabilities

Message ID 20220606154044.1225683-1-timothy.mcdaniel@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series event/dlb2: fix advertized capabilities |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Timothy McDaniel June 6, 2022, 3:40 p.m. UTC 
  1) Remove RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support
queue priority
2) Add RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
3) Add RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK

Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
Cc: stable@dpdk.org

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 drivers/event/dlb2/dlb2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Jerin Jacob June 9, 2022, 5:05 p.m. UTC | #1 
On Mon, Jun 6, 2022 at 9:31 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>

Be more descriptive,

> 1) Remove RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support
> queue priority
> 2) Add RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
> 3) Add RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK

file doc/guides/eventdevs/features/dlb2.ini is not updated. It is out of sync.

>
> Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> Cc: stable@dpdk.org
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
>  drivers/event/dlb2/dlb2.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 36f07d0061..5c30d5ce35 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -61,11 +61,12 @@ static struct rte_event_dev_info evdev_dlb2_default_info = {
>         .max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
>         .max_single_link_event_port_queue_pairs =
>                 DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
> -       .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
> -                         RTE_EVENT_DEV_CAP_EVENT_QOS |
> +       .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
>                           RTE_EVENT_DEV_CAP_BURST_MODE |
>                           RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
>                           RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
> +                         RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
> +                         RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
>                           RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
>                           RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
>  };
> --
> 2.25.1
>
Timothy McDaniel June 9, 2022, 6:02 p.m. UTC | #2 
I will update both the description and doc/guides/eventdevs/features/dlb2.ini

Thanks,
Tim

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, June 9, 2022 12:06 PM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org>; dpdk stable
> <stable@dpdk.org>
> Subject: Re: [PATCH] event/dlb2: fix advertized capabilities
> 
> On Mon, Jun 6, 2022 at 9:31 PM Timothy McDaniel
> <timothy.mcdaniel@intel.com> wrote:
> >
> 
> Be more descriptive,
> 
> > 1) Remove RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support
> > queue priority
> > 2) Add RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
> > 3) Add RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
> 
> file doc/guides/eventdevs/features/dlb2.ini is not updated. It is out of sync.
> 
> >
> > Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> > ---
> >  drivers/event/dlb2/dlb2.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> > index 36f07d0061..5c30d5ce35 100644
> > --- a/drivers/event/dlb2/dlb2.c
> > +++ b/drivers/event/dlb2/dlb2.c
> > @@ -61,11 +61,12 @@ static struct rte_event_dev_info
> evdev_dlb2_default_info = {
> >         .max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
> >         .max_single_link_event_port_queue_pairs =
> >                 DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
> > -       .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
> > -                         RTE_EVENT_DEV_CAP_EVENT_QOS |
> > +       .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
> >                           RTE_EVENT_DEV_CAP_BURST_MODE |
> >                           RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
> >                           RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
> > +                         RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
> > +                         RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
> >                           RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
> >                           RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
> >  };
> > --
> > 2.25.1
> >
diff mbox series

Patch

diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 36f07d0061..5c30d5ce35 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -61,11 +61,12 @@  static struct rte_event_dev_info evdev_dlb2_default_info = {
 	.max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
 	.max_single_link_event_port_queue_pairs =
 		DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
-	.event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
-			  RTE_EVENT_DEV_CAP_EVENT_QOS |
+	.event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
 			  RTE_EVENT_DEV_CAP_BURST_MODE |
 			  RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
 			  RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
+			  RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
+			  RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
 			  RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
 			  RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
 };