diff mbox series

[3/3] ci: use crossbuild-essential-riscv64 for compiling

Message ID 20220609121701.716299-4-kda@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series Fix xmm_t to rte_xmm_t scalar conversion |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Stanislaw Kardach June 9, 2022, 12:17 p.m. UTC 
  The current packages installed for RISC-V build check do not contain a
C++ compiler, which hid an issue with C++ type conversion in the
rte_vect.h header on RISC-V or in the scalar implementation of the LPM
x4 lookup. Now that this issue is fixed, use the full toolchain install
to enable the C++ test.

Besides, the user's guide for RISC-V cross-compilation recommends the
use of crossbuild-essential-riscv64.

Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
---
 .github/workflows/build.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Marchand June 13, 2022, 9:29 a.m. UTC | #1 
On Thu, Jun 9, 2022 at 2:17 PM Stanislaw Kardach <kda@semihalf.com> wrote:
>
> The current packages installed for RISC-V build check do not contain a
> C++ compiler, which hid an issue with C++ type conversion in the
> rte_vect.h header on RISC-V or in the scalar implementation of the LPM
> x4 lookup. Now that this issue is fixed, use the full toolchain install
> to enable the C++ test.
>
> Besides, the user's guide for RISC-V cross-compilation recommends the
> use of crossbuild-essential-riscv64.
>
> Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Aaron Conole June 14, 2022, 12:31 p.m. UTC | #2 
Stanislaw Kardach <kda@semihalf.com> writes:

> The current packages installed for RISC-V build check do not contain a
> C++ compiler, which hid an issue with C++ type conversion in the
> rte_vect.h header on RISC-V or in the scalar implementation of the LPM
> x4 lookup. Now that this issue is fixed, use the full toolchain install
> to enable the C++ test.
>
> Besides, the user's guide for RISC-V cross-compilation recommends the
> use of crossbuild-essential-riscv64.
>
> Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>
diff mbox series

Patch

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 7c8528cb04..c0d2829d0e 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -139,8 +139,7 @@  jobs:
         pkg-config-powerpc-linux-gnu
     - name: Install riscv64 cross compiling packages
       if: env.RISCV64 == 'true'
-      run: sudo apt install -y gcc-riscv64-linux-gnu libc6-dev-riscv64-cross
-        pkg-config-riscv64-linux-gnu
+      run: sudo apt install -y crossbuild-essential-riscv64
     - name: Install test tools packages
       if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RISCV64 != 'true' || env.RUN_TESTS == 'true'
       run: sudo apt install -y gdb