diff mbox series

[2/2] ci: use crossbuild-essential packages

Message ID 20220621122824.187905-3-kda@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series fix C++ include checks in cross-compilation |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Stanislaw Kardach June 21, 2022, 12:28 p.m. UTC 
  The crossbuild-essential-<arch> packages contain all necessary
dependencies to cross-compile binaries for a given architecture
including C and C++ compilers. Therefore use those instead of listing
packages directly. This way C++ compiler is also installed and C++
include checks will be checked in CI for PowerPC and ARM.

Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
---
 .github/workflows/build.yml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

David Marchand June 23, 2022, 8:04 a.m. UTC | #1 
On Tue, Jun 21, 2022 at 2:28 PM Stanislaw Kardach <kda@semihalf.com> wrote:
>
> The crossbuild-essential-<arch> packages contain all necessary
> dependencies to cross-compile binaries for a given architecture
> including C and C++ compilers. Therefore use those instead of listing
> packages directly. This way C++ compiler is also installed and C++
> include checks will be checked in CI for PowerPC and ARM.
>
> Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
diff mbox series

Patch

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index c0d2829d0e..1106256539 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -128,15 +128,13 @@  jobs:
       run: sudo apt install -y gcc-multilib g++-multilib
     - name: Install aarch64 cross compiling packages
       if: env.AARCH64 == 'true'
-      run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
-        pkg-config-aarch64-linux-gnu
+      run: sudo apt install -y crossbuild-essential-arm64
     - name: Install mingw cross compiling packages
       if: env.MINGW == 'true'
       run: sudo apt install -y mingw-w64 mingw-w64-tools
     - name: Install ppc64le cross compiling packages
       if: env.PPC64LE == 'true'
-      run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross
-        pkg-config-powerpc-linux-gnu
+      run: sudo apt install -y crossbuild-essential-ppc64el
     - name: Install riscv64 cross compiling packages
       if: env.RISCV64 == 'true'
       run: sudo apt install -y crossbuild-essential-riscv64