config/riscv: name the cross file properly
Checks
Commit Message
Since the riscv64_linux_gcc was in fact a Ubuntu-specific cross-file,
rename it.
Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
---
.ci/linux-build.sh | 2 +-
config/riscv/{riscv64_linux_gcc => riscv64_linux_gcc_ubuntu} | 0
devtools/test-meson-builds.sh | 2 +-
doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst | 4 ++--
4 files changed, 4 insertions(+), 4 deletions(-)
rename config/riscv/{riscv64_linux_gcc => riscv64_linux_gcc_ubuntu} (100%)
Comments
On Tue, 21 Jun 2022 14:29:23 +0200
Stanislaw Kardach <kda@semihalf.com> wrote:
> Since the riscv64_linux_gcc was in fact a Ubuntu-specific cross-file,
> rename it.
>
> Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> ---
Patch is out dated, and needs to be rebased.
Best to avoid OS variant specific cross files.
Staszek, can you update your email? (same with uprev@semihalf.com?)
On Wed, Oct 2, 2024 at 6:51 PM 'Stephen Hemminger' via upstream
<upstream@semihalf.com> wrote:
>
> On Tue, 21 Jun 2022 14:29:23 +0200
> Stanislaw Kardach <kda@semihalf.com> wrote:
>
> > Since the riscv64_linux_gcc was in fact a Ubuntu-specific cross-file,
> > rename it.
> >
> > Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> > ---
>
> Patch is out dated, and needs to be rebased.
> Best to avoid OS variant specific cross files.
I already did, though to my personal one. This patch is from a way
back, I did forget about it.
On Thu, Oct 3, 2024 at 2:29 PM Radoslaw Biernacki <biernacki@google.com> wrote:
>
> Staszek, can you update your email? (same with uprev@semihalf.com?)
>
> On Wed, Oct 2, 2024 at 6:51 PM 'Stephen Hemminger' via upstream
> <upstream@semihalf.com> wrote:
> >
> > On Tue, 21 Jun 2022 14:29:23 +0200
> > Stanislaw Kardach <kda@semihalf.com> wrote:
> >
> > > Since the riscv64_linux_gcc was in fact a Ubuntu-specific cross-file,
> > > rename it.
> > >
> > > Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> > > ---
> >
> > Patch is out dated, and needs to be rebased.
> > Best to avoid OS variant specific cross files.
@@ -75,7 +75,7 @@ if [ "$PPC64LE" = "true" ]; then
fi
if [ "$RISCV64" = "true" ]; then
- cross_file=config/riscv/riscv64_linux_gcc
+ cross_file=config/riscv/riscv64_linux_gcc_ubuntu
fi
if [ -n "$cross_file" ]; then
similarity index 100%
rename from config/riscv/riscv64_linux_gcc
rename to config/riscv/riscv64_linux_gcc_ubuntu
@@ -265,7 +265,7 @@ f=$srcdir/config/ppc/ppc64le-power8-linux-gcc
build build-ppc64-power8-gcc $f ABI $use_shared
# generic RISC-V
-f=$srcdir/config/riscv/riscv64_linux_gcc
+f=$srcdir/config/riscv/riscv64_linux_gcc_ubuntu
build build-riscv64-generic-gcc $f ABI $use_shared
# Test installation of the x86-generic target, to be used for checking
@@ -74,7 +74,7 @@ To cross-compile DPDK for a desired target machine use the following command::
For example if the target machine is a generic rv64gc RISC-V, use the following
command::
- meson riscv64-build-gcc --cross-file config/riscv/riscv64_linux_gcc
+ meson riscv64-build-gcc --cross-file config/riscv/riscv64_linux_gcc_ubuntu
ninja -C riscv64-build-gcc
If riscv-gnu-toolchain is used, binary names should be updated to match. Update
@@ -106,7 +106,7 @@ Supported cross-compilation targets
Currently the following targets are supported:
-* Generic rv64gc ISA: ``config/riscv/riscv64_linux_gcc``
+* Generic rv64gc ISA: ``config/riscv/riscv64_linux_gcc_ubuntu``
* SiFive U740 SoC: ``config/riscv/riscv64_sifive_u740_linux_gcc``