diff mbox series

net/vhost: fix compliant offloading flag

Message ID 20220628094246.97223-1-xuan.ding@intel.com (mailing list archive)
State Rejected, archived
Delegated to: Maxime Coquelin
Headers
Series net/vhost: fix compliant offloading flag |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-intel-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Ding, Xuan June 28, 2022, 9:42 a.m. UTC 
  From: Xuan Ding <xuan.ding@intel.com>

This patch fixes the check to set compliant offloading flag.
Compliant offloading flag should be set when the
'legacy-ol-flags' is true.

Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
 drivers/net/vhost/rte_eth_vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Coquelin June 28, 2022, 9:57 a.m. UTC | #1 
On 6/28/22 11:42, xuan.ding@intel.com wrote:
> From: Xuan Ding <xuan.ding@intel.com>
> 
> This patch fixes the check to set compliant offloading flag.
> Compliant offloading flag should be set when the
> 'legacy-ol-flags' is true.
> 
> Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
>   drivers/net/vhost/rte_eth_vhost.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index d75d256040..24049df58a 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1735,7 +1735,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
>   			goto out_free;
>   	}
>   
> -	if (legacy_ol_flags == 0)
> +	if (legacy_ol_flags == 1)
>   		flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
>   
>   	if (dev->device.numa_node == SOCKET_ID_ANY)

Nack, legacy OL flags is NOT compliant. So current implementation is
good.

Regards,
Maxime
Ding, Xuan June 28, 2022, 10:28 a.m. UTC | #2 
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, June 28, 2022 5:57 PM
> To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> Subject: Re: [PATCH] net/vhost: fix compliant offloading flag
> 
> 
> 
> On 6/28/22 11:42, xuan.ding@intel.com wrote:
> > From: Xuan Ding <xuan.ding@intel.com>
> >
> > This patch fixes the check to set compliant offloading flag.
> > Compliant offloading flag should be set when the 'legacy-ol-flags' is
> > true.
> >
> > Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
> >
> > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > ---
> >   drivers/net/vhost/rte_eth_vhost.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/vhost/rte_eth_vhost.c
> > b/drivers/net/vhost/rte_eth_vhost.c
> > index d75d256040..24049df58a 100644
> > --- a/drivers/net/vhost/rte_eth_vhost.c
> > +++ b/drivers/net/vhost/rte_eth_vhost.c
> > @@ -1735,7 +1735,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device
> *dev)
> >   			goto out_free;
> >   	}
> >
> > -	if (legacy_ol_flags == 0)
> > +	if (legacy_ol_flags == 1)
> >   		flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
> >
> >   	if (dev->device.numa_node == SOCKET_ID_ANY)
> 
> Nack, legacy OL flags is NOT compliant. So current implementation is good.

Sorry, it's a wrong fix, the compliant mode is enabled by default.

Regards,
Xuan

> 
> Regards,
> Maxime
Ling, WeiX June 28, 2022, 10:58 a.m. UTC | #3 
> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Tuesday, June 28, 2022 6:29 PM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> Subject: RE: [PATCH] net/vhost: fix compliant offloading flag
> 
> 
> 
> > -----Original Message-----
> > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Sent: Tuesday, June 28, 2022 5:57 PM
> > To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo
> > <chenbo.xia@intel.com>
> > Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> > Subject: Re: [PATCH] net/vhost: fix compliant offloading flag
> >
> >
> >
> > On 6/28/22 11:42, xuan.ding@intel.com wrote:
> > > From: Xuan Ding <xuan.ding@intel.com>
> > >
> > > This patch fixes the check to set compliant offloading flag.
> > > Compliant offloading flag should be set when the 'legacy-ol-flags'
> > > is true.
> > >
> > > Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
> > >
> > > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > > ---

Tested-by: Wei Ling <weix.ling@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index d75d256040..24049df58a 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1735,7 +1735,7 @@  rte_pmd_vhost_probe(struct rte_vdev_device *dev)
 			goto out_free;
 	}
 
-	if (legacy_ol_flags == 0)
+	if (legacy_ol_flags == 1)
 		flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
 
 	if (dev->device.numa_node == SOCKET_ID_ANY)